Changeset 276639 in webkit

Timestamp:

Apr 27, 2021 8:29:29 AM (15 months ago)

Author:

graouts@webkit.org

Message:

Fix animation of the visibility CSS property between "hidden" and "collapse"
​https://bugs.webkit.org/show_bug.cgi?id=225103

Reviewed by Antti Koivisto.

LayoutTests/imported/w3c:

Mark 1 WPT progression.

• web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-002-expected.txt:

Source/WebCore:

The Web Animations spec details the special behavior when animating the visibility property
in ​https://drafts.csswg.org/web-animations-1/#animating-visibility. There it says that when
interpolating between non-visible values, we should use discrete interpolation formula.

• animation/CSSPropertyAnimation.cpp:

(WebCore::blendFunc):

Location:

trunk

Files:

• LayoutTests/imported/w3c/ChangeLog (modified) (1 diff)
• LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-002-expected.txt (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/animation/CSSPropertyAnimation.cpp (modified) (1 diff)

trunk/LayoutTests/imported/w3c/ChangeLog

@@ +1 @@
+2021-04-27  Antoine Quint  <graouts@webkit.org>
+
+        Fix animation of the visibility CSS property between "hidden" and "collapse"
+        https://bugs.webkit.org/show_bug.cgi?id=225103
+
+        Reviewed by Antti Koivisto.
+
+        Mark 1 WPT progression.
+
+        * web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-002-expected.txt:
+
 2021-04-27  Antoine Quint  <graouts@webkit.org>
 

trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-002-expected.txt

@@ -226 +226 @@
 PASS visibility uses visibility animation when animating from "visible" to "hidden"
 PASS visibility uses visibility animation when animating from "hidden" to "visible"
-FAIL visibility uses visibility animation when animating from "hidden" to "collapse" assert_equals: The value should be hidden at 0ms expected "hidden" but got "collapse"
+PASS visibility uses visibility animation when animating from "hidden" to "collapse"
 PASS visibility uses visibility animation when animating from "visible" to "hidden" with easeInOutBack easing
 PASS white-space (type: discrete) has testInterpolation function

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2021-04-27  Antoine Quint  <graouts@webkit.org>
+
+        Fix animation of the visibility CSS property between "hidden" and "collapse"
+        https://bugs.webkit.org/show_bug.cgi?id=225103
+
+        Reviewed by Antti Koivisto.
+
+        The Web Animations spec details the special behavior when animating the visibility property
+        in https://drafts.csswg.org/web-animations-1/#animating-visibility. There it says that when
+        interpolating between non-visible values, we should use discrete interpolation formula.
+
+        * animation/CSSPropertyAnimation.cpp:
+        (WebCore::blendFunc):
+
 2021-04-27  Antoine Quint  <graouts@webkit.org>
 

trunk/Source/WebCore/animation/CSSPropertyAnimation.cpp

@@ -380 +380 @@
 static inline Visibility blendFunc(Visibility from, Visibility to, const CSSPropertyBlendingContext& context)
 {
+    if (from != Visibility::Visible && to != Visibility::Visible)
+        return context.progress < 0.5 ? from : to;
+
     // Any non-zero result means we consider the object to be visible. Only at 0 do we consider the object to be
     // invisible. The invisible value we use (Visibility::Hidden vs. Visibility::Collapse) depends on the specified from/to values.