Changeset 276837 in webkit

Timestamp:

Apr 30, 2021 7:24:32 AM (15 months ago)

Author:

Oriol Brufau

Message:

[css-logical] Fix logical shorthands with var()
​https://bugs.webkit.org/show_bug.cgi?id=224594

Reviewed by Manuel Rego Casasnovas.

LayoutTests/imported/w3c:

Add a new test.
Some cases still fail because of bug 225206 and bug 225209.

• web-platform-tests/css/css-logical/logicalprops-with-variables-expected.txt: Added.
• web-platform-tests/css/css-logical/logicalprops-with-variables.html: Added.

Source/WebCore:

Logical shorthands with var() were not working because when resolving
the pending-substitution value of the equivalent physical longhand,
parseValueWithVariableReferences would parse the logical shorthand into
the logical longhands, which would be different properties than the
physical longhand being resolved.

So this patch compares with the equivalent physical property instead.

Test: imported/w3c/web-platform-tests/css/css-logical/logicalprops-with-variables.html

• css/parser/CSSParser.cpp:

(WebCore::CSSParser::parseValueWithVariableReferences):

Location:

trunk

Files:

• LayoutTests/imported/w3c/ChangeLog (modified) (1 diff)
• LayoutTests/imported/w3c/web-platform-tests/css/css-logical/logicalprops-with-variables-expected.txt (added)
• LayoutTests/imported/w3c/web-platform-tests/css/css-logical/logicalprops-with-variables.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/css/parser/CSSParser.cpp (modified) (1 diff)

trunk/LayoutTests/imported/w3c/ChangeLog

@@ +1 @@
+2021-04-30  Oriol Brufau  <obrufau@igalia.com>
+
+        [css-logical] Fix logical shorthands with var()
+        https://bugs.webkit.org/show_bug.cgi?id=224594
+
+        Reviewed by Manuel Rego Casasnovas.
+
+        Add a new test.
+        Some cases still fail because of bug 225206 and bug 225209.
+
+        * web-platform-tests/css/css-logical/logicalprops-with-variables-expected.txt: Added.
+        * web-platform-tests/css/css-logical/logicalprops-with-variables.html: Added.
+
 2021-04-30  Sergio Villar Senin  <svillar@igalia.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2021-04-30  Oriol Brufau  <obrufau@igalia.com>
+
+        [css-logical] Fix logical shorthands with var()
+        https://bugs.webkit.org/show_bug.cgi?id=224594
+
+        Reviewed by Manuel Rego Casasnovas.
+
+        Logical shorthands with var() were not working because when resolving
+        the pending-substitution value of the equivalent physical longhand,
+        parseValueWithVariableReferences would parse the logical shorthand into
+        the logical longhands, which would be different properties than the
+        physical longhand being resolved.
+
+        So this patch compares with the equivalent physical property instead.
+
+        Test: imported/w3c/web-platform-tests/css/css-logical/logicalprops-with-variables.html
+
+        * css/parser/CSSParser.cpp:
+        (WebCore::CSSParser::parseValueWithVariableReferences):
+
 2021-04-30  Antti Koivisto  <antti@apple.com>
 

trunk/Source/WebCore/css/parser/CSSParser.cpp

@@ -200 +200 @@
 
         for (auto& property : parsedProperties) {
-            if (property.id() == propID)
+            CSSPropertyID currentId = property.id();
+            if (CSSProperty::isDirectionAwareProperty(currentId))
+                currentId = CSSProperty::resolveDirectionAwareProperty(currentId, direction, writingMode);
+            if (currentId == propID)
                 return property.value();
         }