Changeset 277212 in webkit

Timestamp:

May 7, 2021 4:59:38 PM (15 months ago)

Author:

Patrick Angle

Message:

Web Inspector: Default source for new test cases is minified
​https://bugs.webkit.org/show_bug.cgi?id=225546

Reviewed by Devin Rousso.

Move the placeholder test code to WI.DefaultAudits as part of the non-minified sources so that new audit test
cases do not have their default placeholder script minified. This also allows us to remove
WI.AuditTestCase.stringifyFunction as it is no longer needed.

• UserInterface/Models/AuditTestCase.js:

(WI.AuditTestCase.stringifyFunction): Deleted.

• UserInterface/NonMinified/DefaultAudits.js:

(WI.DefaultAudits.newAuditPlaceholder):

• UserInterface/Views/CreateAuditPopover.js:

(WI.CreateAuditPopover.prototype.dismiss):
(WI.CreateAuditPopover.prototype.dismiss.const.placeholderTestFunction): Deleted.

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Models/AuditTestCase.js (modified) (1 diff)
• UserInterface/NonMinified/DefaultAudits.js (modified) (1 diff)
• UserInterface/Views/CreateAuditPopover.js (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2021-05-07  Patrick Angle  <pangle@apple.com>
+
+        Web Inspector: Default source for new test cases is minified
+        https://bugs.webkit.org/show_bug.cgi?id=225546
+
+        Reviewed by Devin Rousso.
+
+        Move the placeholder test code to `WI.DefaultAudits` as part of the non-minified sources so that new audit test
+        cases do not have their default placeholder script minified. This also allows us to remove
+        `WI.AuditTestCase.stringifyFunction` as it is no longer needed.
+
+        * UserInterface/Models/AuditTestCase.js:
+        (WI.AuditTestCase.stringifyFunction): Deleted.
+        * UserInterface/NonMinified/DefaultAudits.js:
+        (WI.DefaultAudits.newAuditPlaceholder):
+        * UserInterface/Views/CreateAuditPopover.js:
+        (WI.CreateAuditPopover.prototype.dismiss):
+        (WI.CreateAuditPopover.prototype.dismiss.const.placeholderTestFunction): Deleted.
+
 2021-05-04  Devin Rousso  <drousso@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Models/AuditTestCase.js

@@ -78 +78 @@
     }
 
-    static stringifyFunction(func, indentLevel)
-    {
-        let string = func.toString();
-
-        // Remove spaces to make the function look unindented.
-        string = string.replaceAll(new RegExp(`^ {${indentLevel}}`, "gm"), "");
-
-        // Replace remaining indentations with the user set indent string.
-        string = string.replaceAll(/^    /gm, WI.indentString());
-
-        return string;
-    }
-
     // Public
 

trunk/Source/WebInspectorUI/UserInterface/NonMinified/DefaultAudits.js

@@ -680 +680 @@
     return {level: domNodes.length ? "fail" : "pass", domNodes, domAttributes: ["aria-hidden"]};
 };
+
+WI.DefaultAudits.newAuditPlaceholder = function() {
+    let result = {
+        level: "pass",
+    };
+    return result;
+};

trunk/Source/WebInspectorUI/UserInterface/Views/CreateAuditPopover.js

@@ -87 +87 @@
     dismiss()
     {
-        const placeholderTestFunction = function() {
-            let result = {
-                level: "pass",
-            };
-            return result;
-        };
-        const placeholderTestFunctionString = WI.AuditTestCase.stringifyFunction(placeholderTestFunction, 8);
+        const placeholderTestFunctionString = WI.DefaultAudits.newAuditPlaceholder.toString();
 
         let type = this._typeSelectElement.value;