Changeset 277588 in webkit


Ignore:
Timestamp:
May 17, 2021 11:12:36 AM (14 months ago)
Author:
jer.noble@apple.com
Message:

MediaSession action handlers aren't treated as having a user gesture
​https://bugs.webkit.org/show_bug.cgi?id=225875

Reviewed by Eric Carlson.

Source/WebCore:

Test: media/media-session/user-gesture-action-handlers.html

We treat remote control commands as having a user gesture, but not when firing
a MediaSession action handler; we should treat them the same.

  • Modules/mediasession/MediaSession.cpp:

(WebCore::MediaSession::callActionHandler):

LayoutTests:

  • media/media-session/user-gesture-action-handlers-expected.txt: Added.
  • media/media-session/user-gesture-action-handlers.html: Added.
Location:
trunk
Files:
2 added
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r277582 r277588  
     12021-05-17  Jer Noble  <jer.noble@apple.com>
     2
     3        MediaSession action handlers aren't treated as having a user gesture
     4        https://bugs.webkit.org/show_bug.cgi?id=225875
     5
     6        Reviewed by Eric Carlson.
     7
     8        * media/media-session/user-gesture-action-handlers-expected.txt: Added.
     9        * media/media-session/user-gesture-action-handlers.html: Added.
     10
    1112021-05-17  Diego Pino Garcia  <dpino@igalia.com>
    212

  • trunk/Source/WebCore/ChangeLog

    r277586 r277588  
     12021-05-17  Jer Noble  <jer.noble@apple.com>
     2
     3        MediaSession action handlers aren't treated as having a user gesture
     4        https://bugs.webkit.org/show_bug.cgi?id=225875
     5
     6        Reviewed by Eric Carlson.
     7
     8        Test: media/media-session/user-gesture-action-handlers.html
     9
     10        We treat remote control commands as having a user gesture, but not when firing
     11        a MediaSession action handler; we should treat them the same.
     12
     13        * Modules/mediasession/MediaSession.cpp:
     14        (WebCore::MediaSession::callActionHandler):
     15
    1162021-05-17  Chris Dumez  <cdumez@apple.com>
    217

  • trunk/Source/WebCore/Modules/mediasession/MediaSession.cpp

    r277573 r277588  
    276276{
    277277    if (auto handler = m_actionHandlers.get(actionDetails.action)) {
     278        UserGestureIndicator gestureIndicator(ProcessingUserGesture, document());
    278279        handler->handleEvent(actionDetails);
    279280        return true;
Note: See TracChangeset for help on using the changeset viewer.