Changeset 277868 in webkit

Timestamp:

May 21, 2021 10:16:20 AM (14 months ago)

Author:

commit-queue@webkit.org

Message:

grid track size should reject unitless length
​https://bugs.webkit.org/show_bug.cgi?id=189137

Patch by Rob Buis <​rbuis@igalia.com> on 2021-05-21
Reviewed by Sergio Villar Senin.

LayoutTests/imported/w3c:

Update improved test result.

• web-platform-tests/quirks/unitless-length/excluded-properties-001-expected.txt:

Source/WebCore:

Reject unitless length's for grid track sizes in quirks mode.

Behavior matches Chrome and Firefox.

• css/parser/CSSPropertyParser.cpp:

(WebCore::consumeGridBreadth):

Location:

trunk

Files:

• LayoutTests/imported/w3c/ChangeLog (modified) (1 diff)
• LayoutTests/imported/w3c/web-platform-tests/quirks/unitless-length/excluded-properties-001-expected.txt (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/css/parser/CSSPropertyParser.cpp (modified) (1 diff)

trunk/LayoutTests/imported/w3c/ChangeLog

@@ +1 @@
+2021-05-21  Rob Buis  <rbuis@igalia.com>
+
+        grid track size should reject unitless length
+        https://bugs.webkit.org/show_bug.cgi?id=189137
+
+        Reviewed by Sergio Villar Senin.
+
+        Update improved test result.
+
+        * web-platform-tests/quirks/unitless-length/excluded-properties-001-expected.txt:
+
 2021-05-20  Alexey Shvayka  <shvaikalesh@gmail.com>
 

trunk/LayoutTests/imported/w3c/web-platform-tests/quirks/unitless-length/excluded-properties-001-expected.txt

@@ -11 +11 @@
 PASS Property column-width does not support quirky length
 PASS Property flex-basis does not support quirky length
-FAIL Property grid-auto-columns does not support quirky length assert_equals: expected "567px" but got "1234px"
-FAIL Property grid-auto-rows does not support quirky length assert_equals: expected "567px" but got "1234px"
-FAIL Property grid-template-columns does not support quirky length assert_equals: expected "567px" but got "1234px"
-FAIL Property grid-template-rows does not support quirky length assert_equals: expected "567px" but got "1234px"
+PASS Property grid-auto-columns does not support quirky length
+PASS Property grid-auto-rows does not support quirky length
+PASS Property grid-template-columns does not support quirky length
+PASS Property grid-template-rows does not support quirky length
 PASS Property inline-size does not support quirky length
 PASS Property inset does not support quirky length

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2021-05-21  Rob Buis  <rbuis@igalia.com>
+
+        grid track size should reject unitless length
+        https://bugs.webkit.org/show_bug.cgi?id=189137
+
+        Reviewed by Sergio Villar Senin.
+
+        Reject unitless length's for grid track sizes in quirks mode.
+
+        Behavior matches Chrome and Firefox.
+
+        * css/parser/CSSPropertyParser.cpp:
+        (WebCore::consumeGridBreadth):
+
 2021-05-21  Jer Noble  <jer.noble@apple.com>
 

trunk/Source/WebCore/css/parser/CSSPropertyParser.cpp

@@ -3441 +3441 @@
         return CSSPrimitiveValue::create(range.consumeIncludingWhitespace().numericValue(), CSSUnitType::CSS_FR);
     }
-    return consumeLengthOrPercent(range, cssParserMode, ValueRange::NonNegative, UnitlessQuirk::Allow);
+    return consumeLengthOrPercent(range, cssParserMode, ValueRange::NonNegative);
 }