Changeset 278510 in webkit

Timestamp:

Jun 4, 2021 4:44:21 PM (14 months ago)

Author:

ysuzuki@apple.com

Message:

[JSC] Private static method should define privateClassBrandIdentifier in class-scope
​https://bugs.webkit.org/show_bug.cgi?id=226656
rdar://78313139

Reviewed by Keith Miller.

JSTests:

• stress/private-in-error.js: Added.

(shouldThrow):
(x):
(prototype.foo):

• stress/private-static-method-declaration-error.js: Added.

(shouldThrow):
(prototype.get x):
(prototype.foo.D.a):
(prototype.foo.D.prototype.b):
(prototype.foo.D):
(prototype.foo):

Source/JavaScriptCore:

We accidentally made declaresStaticPrivateMethod always false.
This patch fixes that so that we properly define privateClassBrandIdentifier field in the class-scope if static-private-method is defined.

• parser/Parser.cpp:

(JSC::Parser<LexerType>::parseClass):

Location:

trunk

Files:

• JSTests/ChangeLog (modified) (1 diff)
• JSTests/stress/private-in-error.js (added)
• JSTests/stress/private-static-method-declaration-error.js (added)
• Source/JavaScriptCore/ChangeLog (modified) (1 diff)
• Source/JavaScriptCore/parser/Parser.cpp (modified) (1 diff)

trunk/JSTests/ChangeLog

@@ +1 @@
+2021-06-04  Yusuke Suzuki  <ysuzuki@apple.com>
+
+        [JSC] Private static method should define privateClassBrandIdentifier in class-scope
+        https://bugs.webkit.org/show_bug.cgi?id=226656
+        rdar://78313139
+
+        Reviewed by Keith Miller.
+
+        * stress/private-in-error.js: Added.
+        (shouldThrow):
+        (x):
+        (prototype.foo):
+        * stress/private-static-method-declaration-error.js: Added.
+        (shouldThrow):
+        (prototype.get x):
+        (prototype.foo.D.a):
+        (prototype.foo.D.prototype.b):
+        (prototype.foo.D):
+        (prototype.foo):
+
 2021-06-04  Mark Lam  <mark.lam@apple.com>
 

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2021-06-04  Yusuke Suzuki  <ysuzuki@apple.com>
+
+        [JSC] Private static method should define privateClassBrandIdentifier in class-scope
+        https://bugs.webkit.org/show_bug.cgi?id=226656
+        rdar://78313139
+
+        Reviewed by Keith Miller.
+
+        We accidentally made `declaresStaticPrivateMethod` always `false`.
+        This patch fixes that so that we properly define privateClassBrandIdentifier field in the class-scope if static-private-method is defined.
+
+        * parser/Parser.cpp:
+        (JSC::Parser<LexerType>::parseClass):
+
 2021-06-04  Filip Pizlo  <fpizlo@apple.com>
 

trunk/Source/JavaScriptCore/parser/Parser.cpp

@@ -3034 +3034 @@
 
                 if (tag == ClassElementTag::Static)
-                    declaresStaticPrivateAccessor = true;
+                    declaresStaticPrivateMethod = true;
                 else
                     declaresPrivateMethod = true;