Changeset 279383 in webkit


Ignore:
Timestamp:
Jun 29, 2021 1:36:58 PM (13 months ago)
Author:
Darin Adler
Message:

CSS style sheets loaded by HTMLLinkElement do not fall back correctly when charset is an invalid encoding name
​https://bugs.webkit.org/show_bug.cgi?id=227498

Reviewed by Sam Weinig.

LayoutTests/imported/w3c:

  • web-platform-tests/css/css-syntax/charset/page-windows-1251-charset-attribute-bogus-expected.txt:

Expect a pass instead of a fail.

Source/WebCore:

  • html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::process): Check for invalid text encoding names rather than
just empty string.

Location:
trunk
Files:
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/imported/w3c/ChangeLog

    r279380 r279383  
     12021-06-29  Darin Adler  <darin@apple.com>
     2
     3        CSS style sheets loaded by HTMLLinkElement do not fall back correctly when charset is an invalid encoding name
     4        https://bugs.webkit.org/show_bug.cgi?id=227498
     5
     6        Reviewed by Sam Weinig.
     7
     8        * web-platform-tests/css/css-syntax/charset/page-windows-1251-charset-attribute-bogus-expected.txt:
     9        Expect a pass instead of a fail.
     10
    1112021-06-29  Alex Christensen  <achristensen@webkit.org>
    212

  • trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-syntax/charset/page-windows-1251-charset-attribute-bogus-expected.txt

    r251635 r279383  
    11
    2 FAIL CSS charset: page windows-1251, charset attribute bogus assert_equals: expected "hidden" but got "visible"
     2PASS CSS charset: page windows-1251, charset attribute bogus
    33

  • trunk/Source/WebCore/ChangeLog

    r279382 r279383  
     12021-06-29  Darin Adler  <darin@apple.com>
     2
     3        CSS style sheets loaded by HTMLLinkElement do not fall back correctly when charset is an invalid encoding name
     4        https://bugs.webkit.org/show_bug.cgi?id=227498
     5
     6        Reviewed by Sam Weinig.
     7
     8        * html/HTMLLinkElement.cpp:
     9        (WebCore::HTMLLinkElement::process): Check for invalid text encoding names rather than
     10        just empty string.
     11
    1122021-06-29  Commit Queue  <commit-queue@webkit.org>
    213

  • trunk/Source/WebCore/html/HTMLLinkElement.cpp

    r278253 r279383  
    288288    if (m_disabledState != Disabled && treatAsStyleSheet && document().frame() && url.isValid()) {
    289289        String charset = attributeWithoutSynchronization(charsetAttr);
    290         if (charset.isEmpty())
     290        if (!TextEncoding { charset }.isValid())
    291291            charset = document().charset();
    292292
Note: See TracChangeset for help on using the changeset viewer.