Changeset 280037 in webkit

Timestamp:

Jul 19, 2021 11:06:51 AM (12 months ago)

Author:

Patrick Angle

Message:

Web Inspector: Elements: selecting a sibling node in the breadcrumb navigation doesn't do anything
​https://bugs.webkit.org/show_bug.cgi?id=227893

Reviewed by Devin Rousso.

The WI.HierarchicalPathComponent.Event.Clicked event is only fired when there are no sibling path components
to select, therefor we must also listen for the WI.HierarchicalPathComponent.Event.SiblingWasSelected event to
be able to then reveal and highlight the correct DOM node in the tree.

• UserInterface/Views/DOMTreeContentView.js:

(WI.DOMTreeContentView.prototype.get selectionPathComponents):
(WI.DOMTreeContentView.prototype._handlePathComponentSelected):
Drive-by to match our style of _handle* event handler naming.

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/DOMTreeContentView.js (modified) (2 diffs)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2021-07-19  Patrick Angle  <pangle@apple.com>
+
+        Web Inspector: Elements: selecting a sibling node in the breadcrumb navigation doesn't do anything
+        https://bugs.webkit.org/show_bug.cgi?id=227893
+
+        Reviewed by Devin Rousso.
+
+        The `WI.HierarchicalPathComponent.Event.Clicked` event is only fired when there are no sibling path components
+        to select, therefor we must also listen for the `WI.HierarchicalPathComponent.Event.SiblingWasSelected` event to
+        be able to then reveal and highlight the correct DOM node in the tree.
+
+        * UserInterface/Views/DOMTreeContentView.js:
+        (WI.DOMTreeContentView.prototype.get selectionPathComponents):
+        (WI.DOMTreeContentView.prototype._handlePathComponentSelected):
+        Drive-by to match our style of `_handle*` event handler naming.
+
 2021-07-19  Patrick Angle  <pangle@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeContentView.js

@@ -182 +182 @@
 
             var pathComponent = new WI.DOMTreeElementPathComponent(treeElement, treeElement.representedObject);
-            pathComponent.addEventListener(WI.HierarchicalPathComponent.Event.Clicked, this._pathComponentSelected, this);
+            pathComponent.addEventListener(WI.HierarchicalPathComponent.Event.Clicked, this._handlePathComponentSelected, this);
+            pathComponent.addEventListener(WI.HierarchicalPathComponent.Event.SiblingWasSelected, this._handlePathComponentSelected, this);
             pathComponents.unshift(pathComponent);
             treeElement = treeElement.parent;
@@ -532 +533 @@
     }
 
-    _pathComponentSelected(event)
+    _handlePathComponentSelected(event)
     {
         if (!event.data.pathComponent)