Changeset 280566 in webkit

Timestamp:

Aug 2, 2021 3:54:05 PM (12 months ago)

Author:

Nikita Vasilyev

Message:

Web Inspector: Network: sorting of transfer size for failed requests is causing the ordering to change every layout
​https://bugs.webkit.org/show_bug.cgi?id=228712

Reviewed by Devin Rousso.

• UserInterface/Views/NetworkTableContentView.js:

(WI.NetworkTableContentView.prototype._generateSortComparator):
Don't change the item order when both values are NaN.

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/NetworkTableContentView.js (modified) (2 diffs)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2021-08-02  Nikita Vasilyev  <nvasilyev@apple.com>
+
+        Web Inspector: Network: sorting of transfer size for failed requests is causing the ordering to change every layout
+        https://bugs.webkit.org/show_bug.cgi?id=228712
+
+        Reviewed by Devin Rousso.
+
+        * UserInterface/Views/NetworkTableContentView.js:
+        (WI.NetworkTableContentView.prototype._generateSortComparator):
+        Don't change the item order when both values are NaN.
+
 2021-07-26  Qiaosong Zhou  <qiaosong_zhou@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js

@@ -1035 +1035 @@
             comparator = (a, b) => {
                 let aValue = a[sortColumnIdentifier];
+                let bValue = b[sortColumnIdentifier];
+
+                if (isNaN(aValue) && isNaN(bValue))
+                    return 0;
                 if (isNaN(aValue))
                     return 1;
-                let bValue = b[sortColumnIdentifier];
                 if (isNaN(bValue))
                     return -1;
@@ -1059 +1062 @@
                 let transferSizeA = a.transferSize;
                 let transferSizeB = b.transferSize;
+
+                if (isNaN(transferSizeA) && isNaN(transferSizeB))
+                    return 0;
 
                 // Treat NaN as the largest value.