Changeset 280989 in webkit

Timestamp:

Aug 12, 2021 3:50:45 PM (11 months ago)

Author:

Patrick Angle

Message:

Web Inspector: Adding execution contexts after page load doesn't show a hidden execution selector
​https://bugs.webkit.org/show_bug.cgi?id=229053

Reviewed by Devin Rousso.

Add a handler for execution contexts being added to update the display of the execution context list, as when
there is only a single context at page load the dropdown will be hidden and thus needs to be shown when an
execution context is added after page load.

• UserInterface/Views/QuickConsole.js:

(WI.QuickConsole):
(WI.QuickConsole.prototype._handleFrameExecutionContextAdded):

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/QuickConsole.js (modified) (2 diffs)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2021-08-12  Patrick Angle  <pangle@apple.com>
+
+        Web Inspector: Adding execution contexts after page load doesn't show a hidden execution selector
+        https://bugs.webkit.org/show_bug.cgi?id=229053
+
+        Reviewed by Devin Rousso.
+
+        Add a handler for execution contexts being added to update the display of the execution context list, as when
+        there is only a single context at page load the dropdown will be hidden and thus needs to be shown when an
+        execution context is added after page load.
+
+        * UserInterface/Views/QuickConsole.js:
+        (WI.QuickConsole):
+        (WI.QuickConsole.prototype._handleFrameExecutionContextAdded):
+
 2021-08-12  Nikita Vasilyev  <nvasilyev@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/QuickConsole.js

@@ -70 +70 @@
         WI.Frame.addEventListener(WI.Frame.Event.PageExecutionContextChanged, this._handleFramePageExecutionContextChanged, this);
         WI.Frame.addEventListener(WI.Frame.Event.ExecutionContextsCleared, this._handleFrameExecutionContextsCleared, this);
+        WI.Frame.addEventListener(WI.Frame.Event.ExecutionContextAdded, this._handleFrameExecutionContextAdded, this);
 
         WI.debuggerManager.addEventListener(WI.DebuggerManager.Event.ActiveCallFrameDidChange, this._handleDebuggerActiveCallFrameDidChange, this);
@@ -373 +374 @@
     }
 
+    _handleFrameExecutionContextAdded(event)
+    {
+        this._updateActiveExecutionContextDisplay();
+    }
+
     _handleFrameExecutionContextsCleared(event)
     {