Changeset 281013 in webkit

Timestamp:

Aug 13, 2021 4:57:19 AM (11 months ago)

Author:

Jean-Yves Avenard

Message:

nexttrack and previoustrack MediaSession handlers not working
​https://bugs.webkit.org/show_bug.cgi?id=229068
rdar://80100092

Reviewed by Youenn Fablet.

Map between MediaSession action next/previousTrack and RemoteControlCommandType ones
were inverted.
There is no infrastrure in place to ensure that the right MRMediaRemoteCommand is
used with the MediaRemote backend, which prevents automating the test.

• Modules/mediasession/MediaSession.cpp:

(WebCore::platformCommandForMediaSessionAction):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• Modules/mediasession/MediaSession.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2021-08-13  Jean-Yves Avenard  <jya@apple.com>
+
+        nexttrack and previoustrack MediaSession handlers not working
+        https://bugs.webkit.org/show_bug.cgi?id=229068
+        rdar://80100092
+
+        Reviewed by Youenn Fablet.
+
+        Map between MediaSession action next/previousTrack and RemoteControlCommandType ones
+        were inverted.
+        There is no infrastrure in place to ensure that the right MRMediaRemoteCommand is
+        used with the MediaRemote backend, which prevents automating the test.
+
+        * Modules/mediasession/MediaSession.cpp:
+        (WebCore::platformCommandForMediaSessionAction):
+
 2021-08-13  Youenn Fablet  <youenn@apple.com>
 

trunk/Source/WebCore/Modules/mediasession/MediaSession.cpp

@@ -65 +65 @@
             { MediaSessionAction::Seekforward, PlatformMediaSession::SkipForwardCommand },
             { MediaSessionAction::Seekbackward, PlatformMediaSession::SkipBackwardCommand },
-            { MediaSessionAction::Previoustrack, PlatformMediaSession::NextTrackCommand },
-            { MediaSessionAction::Nexttrack, PlatformMediaSession::PreviousTrackCommand },
+            { MediaSessionAction::Previoustrack, PlatformMediaSession::PreviousTrackCommand },
+            { MediaSessionAction::Nexttrack, PlatformMediaSession::NextTrackCommand },
             { MediaSessionAction::Stop, PlatformMediaSession::StopCommand },
             { MediaSessionAction::Seekto, PlatformMediaSession::SeekToPlaybackPositionCommand },