Changeset 281441 in webkit

Timestamp:

Aug 23, 2021 7:20:50 AM (11 months ago)

Author:

Razvan Caliman

Message:

Web Inspector: CSS Changes: changes are not updated live
​https://bugs.webkit.org/show_bug.cgi?id=229153
<rdar://problem/81989328>

Reviewed by Devin Rousso.

Dispatch an event whenever the list of modified styles changes.
Re-layout the Changes details sidebar panel in response to this event
to reflect the latest state of the modified styles.

• UserInterface/Controllers/CSSManager.js:

(WI.CSSManager.prototype.addModifiedStyle):
(WI.CSSManager.prototype.removeModifiedStyle):

• UserInterface/Views/ChangesDetailsSidebarPanel.js:

(WI.ChangesDetailsSidebarPanel.prototype.attached):
(WI.ChangesDetailsSidebarPanel.prototype.detached):

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Controllers/CSSManager.js (modified) (3 diffs)
• UserInterface/Views/ChangesDetailsSidebarPanel.js (modified) (2 diffs)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2021-08-23  Razvan Caliman  <rcaliman@apple.com>
+
+        Web Inspector: CSS Changes: changes are not updated live
+        https://bugs.webkit.org/show_bug.cgi?id=229153
+        <rdar://problem/81989328>
+
+        Reviewed by Devin Rousso.
+
+        Dispatch an event whenever the list of modified styles changes.
+        Re-layout the Changes details sidebar panel in response to this event
+        to reflect the latest state of the modified styles.
+
+        * UserInterface/Controllers/CSSManager.js:
+        (WI.CSSManager.prototype.addModifiedStyle):
+        (WI.CSSManager.prototype.removeModifiedStyle):
+        * UserInterface/Views/ChangesDetailsSidebarPanel.js:
+        (WI.ChangesDetailsSidebarPanel.prototype.attached):
+        (WI.ChangesDetailsSidebarPanel.prototype.detached):
+
 2021-08-19  Alex Christensen  <achristensen@webkit.org>
 

trunk/Source/WebInspectorUI/UserInterface/Controllers/CSSManager.js

@@ -356 +356 @@
     {
         this._modifiedStyles.set(style.stringId, style);
+
+        this.dispatchEventToListeners(WI.CSSManager.Event.ModifiedStylesChanged);
     }
 
@@ -366 +368 @@
     {
         this._modifiedStyles.delete(style.stringId);
+
+        this.dispatchEventToListeners(WI.CSSManager.Event.ModifiedStylesChanged);
     }
 
@@ -675 +679 @@
     StyleSheetAdded: "css-manager-style-sheet-added",
     StyleSheetRemoved: "css-manager-style-sheet-removed",
+    ModifiedStylesChanged: "css-manager-modified-styles-changed",
     DefaultAppearanceDidChange: "css-manager-default-appearance-did-change",
     ForcedAppearanceDidChange: "css-manager-forced-appearance-did-change",

trunk/Source/WebInspectorUI/UserInterface/Views/ChangesDetailsSidebarPanel.js

@@ -46 +46 @@
 
         WI.Frame.addEventListener(WI.Frame.Event.MainResourceDidChange, this._mainResourceDidChange, this);
+        WI.CSSManager.addEventListener(WI.CSSManager.Event.ModifiedStylesChanged, this.needsLayout, this);
     }
 
@@ -51 +52 @@
     {
         WI.Frame.removeEventListener(WI.Frame.Event.MainResourceDidChange, this._mainResourceDidChange, this);
+        WI.CSSManager.removeEventListener(WI.CSSManager.Event.ModifiedStylesChanged, this.needsLayout, this);
 
         super.detached();