Changeset 281683 in webkit

Timestamp:

Aug 26, 2021 8:52:54 PM (11 months ago)

Author:

Simon Fraser

Message:

CSS keyframed animations don't respect edges in 4 value background-position
​https://bugs.webkit.org/show_bug.cgi?id=228995

Reviewed by Darin Adler.

For some background-position animations we'd fail to set backgroundOriginX/Y in the
destination style's FillLayer, because this is not set in the destination style initially.

So have FillLayerPositionPropertyWrapper::blend() always set it.

Source/WebCore:

Test: animations/background-position.html

• animation/CSSPropertyAnimation.cpp:

LayoutTests:

• animations/background-position-expected.html: Added.
• animations/background-position.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/animations/background-position-expected.html (added)
• LayoutTests/animations/background-position.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/animation/CSSPropertyAnimation.cpp (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2021-08-26  Simon Fraser  <simon.fraser@apple.com>
+
+        CSS keyframed animations don't respect edges in 4 value background-position
+        https://bugs.webkit.org/show_bug.cgi?id=228995
+
+        Reviewed by Darin Adler.
+
+        For some background-position animations we'd fail to set backgroundOriginX/Y in the
+        destination style's FillLayer, because this is not set in the destination style initially.
+        
+        So have FillLayerPositionPropertyWrapper::blend() always set it.
+
+        * animations/background-position-expected.html: Added.
+        * animations/background-position.html: Added.
+
 2021-08-26  Simon Fraser  <simon.fraser@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2021-08-26  Simon Fraser  <simon.fraser@apple.com>
+
+        CSS keyframed animations don't respect edges in 4 value background-position
+        https://bugs.webkit.org/show_bug.cgi?id=228995
+
+        Reviewed by Darin Adler.
+
+        For some background-position animations we'd fail to set backgroundOriginX/Y in the
+        destination style's FillLayer, because this is not set in the destination style initially.
+        
+        So have FillLayerPositionPropertyWrapper::blend() always set it.
+
+        Test: animations/background-position.html
+
+        * animation/CSSPropertyAnimation.cpp:
+
 2021-08-26  Simon Fraser  <simon.fraser@apple.com>
 

trunk/Source/WebCore/animation/CSSPropertyAnimation.cpp

@@ -1644 +1644 @@
         Edge toEdge = (to->*m_originGetter)();
         
+        Edge destinationEdge = toEdge;
         if (fromEdge != toEdge) {
             // Convert the right/bottom into a calc expression,
@@ -1650 +1651 @@
             else if (toEdge == m_farEdge) {
                 toLength = convertTo100PercentMinusLength(toLength);
-                (destination->*m_originSetter)(fromEdge); // Now we have a calc(100% - l), it's relative to the left/top edge.
+                destinationEdge = fromEdge; // Now we have a calc(100% - l), it's relative to the left/top edge.
             }
         }
 
+        (destination->*m_originSetter)(destinationEdge);
         (destination->*m_lengthSetter)(blendFunc(fromLength, toLength, context));
     }