Changeset 281770 in webkit

Timestamp:

Aug 30, 2021 11:30:23 AM (11 months ago)

Author:

Chris Dumez

Message:

SubmitEvent.submitter property isn't set for <button type="submit">
​https://bugs.webkit.org/show_bug.cgi?id=229660

Reviewed by Ryosuke Niwa.

Source/WebCore:

Make sure HTMLButtonElement::defaultEventHandler() properly passes |this| as submitter
when calling HTMLFormElement::submitIfPossible(). This was causing the SubmitEvent.submitter
property to not be set when submitting a form by clicking a <button type="submit">.

Test: fast/forms/submit-button-submit-event.html

• html/HTMLButtonElement.cpp:

(WebCore::HTMLButtonElement::defaultEventHandler):

LayoutTests:

Add layout test coverage.

• fast/forms/submit-button-submit-event-expected.txt: Added.
• fast/forms/submit-button-submit-event.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/forms/submit-button-submit-event-expected.txt (added)
• LayoutTests/fast/forms/submit-button-submit-event.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/html/HTMLButtonElement.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2021-08-30  Chris Dumez  <cdumez@apple.com>
+
+        SubmitEvent.submitter property isn't set for <button type="submit">
+        https://bugs.webkit.org/show_bug.cgi?id=229660
+
+        Reviewed by Ryosuke Niwa.
+
+        Add layout test coverage.
+
+        * fast/forms/submit-button-submit-event-expected.txt: Added.
+        * fast/forms/submit-button-submit-event.html: Added.
+
 2021-08-30  Ayumi Kojima  <ayumi_kojima@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2021-08-30  Chris Dumez  <cdumez@apple.com>
+
+        SubmitEvent.submitter property isn't set for <button type="submit">
+        https://bugs.webkit.org/show_bug.cgi?id=229660
+
+        Reviewed by Ryosuke Niwa.
+
+        Make sure HTMLButtonElement::defaultEventHandler() properly passes |this| as submitter
+        when calling HTMLFormElement::submitIfPossible(). This was causing the SubmitEvent.submitter
+        property to not be set when submitting a form by clicking a `<button type="submit">`.
+
+        Test: fast/forms/submit-button-submit-event.html
+
+        * html/HTMLButtonElement.cpp:
+        (WebCore::HTMLButtonElement::defaultEventHandler):
+
 2021-08-30  Alan Bujtas  <zalan@apple.com>
 

trunk/Source/WebCore/html/HTMLButtonElement.cpp

@@ -139 +139 @@
                 if (m_type == SUBMIT) {
                     SetForScope<bool> activatedSubmitState(m_isActivatedSubmit, true);
-                    currentForm->submitIfPossible(&event);
+                    currentForm->submitIfPossible(&event, this);
                 }