Changeset 282085 in webkit

Timestamp:

Sep 7, 2021 8:00:21 AM (11 months ago)

Author:

svillar@igalia.com

Message:

Interoperability issue in margin collapsing with overflow:hidden elements
​https://bugs.webkit.org/show_bug.cgi?id=224185

Reviewed by Alan Bujtas.

Source/WebCore:

Margins should not self collapse for those elements that create new formatting contexts
like when using overflow:hidden.

Test: fast/block/margin-collapse/self-collapsing-block-with-overflow-hidden.html

• rendering/RenderBlock.cpp:

(WebCore::RenderBlock::isSelfCollapsingBlock const): Boxes that create new formatting context should
not self collapse.

LayoutTests:

• TestExpectations: Unskipped 3 flexbox tests that are working fine now.
• fast/block/margin-collapse/self-collapsing-block-with-overflow-hidden-expected.html: Added.
• fast/block/margin-collapse/self-collapsing-block-with-overflow-hidden.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/TestExpectations (modified) (1 diff)
• LayoutTests/fast/block/margin-collapse/self-collapsing-block-with-overflow-hidden-expected.html (added)
• LayoutTests/fast/block/margin-collapse/self-collapsing-block-with-overflow-hidden.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/rendering/RenderBlock.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2021-08-26  Sergio Villar Senin  <svillar@igalia.com>
+
+        Interoperability issue in margin collapsing with overflow:hidden elements
+        https://bugs.webkit.org/show_bug.cgi?id=224185
+
+        Reviewed by Alan Bujtas.
+
+        * TestExpectations: Unskipped 3 flexbox tests that are working fine now.
+        * fast/block/margin-collapse/self-collapsing-block-with-overflow-hidden-expected.html: Added.
+        * fast/block/margin-collapse/self-collapsing-block-with-overflow-hidden.html: Added.
+
 2021-09-01  Sergio Villar Senin  <svillar@igalia.com>
 

trunk/LayoutTests/TestExpectations

@@ -4161 +4161 @@
 webkit.org/b/221474 imported/w3c/web-platform-tests/css/css-flexbox/svg-root-as-flex-item-003.html [ ImageOnlyFailure ]
 
-# Writing modes in flexbox.
-webkit.org/b/221475 imported/w3c/web-platform-tests/css/css-flexbox/flexbox-writing-mode-013.html [ ImageOnlyFailure ]
-webkit.org/b/221475 imported/w3c/web-platform-tests/css/css-flexbox/flexbox-writing-mode-014.html [ ImageOnlyFailure ]
-webkit.org/b/221475 imported/w3c/web-platform-tests/css/css-flexbox/flexbox-writing-mode-015.html [ ImageOnlyFailure ]
-
 webkit.org/b/221468 imported/w3c/web-platform-tests/css/css-flexbox/flexbox-align-self-horiz-002.xhtml [ ImageOnlyFailure ]
 webkit.org/b/221468 imported/w3c/web-platform-tests/css/css-flexbox/flexbox-align-self-vert-002.xhtml [ ImageOnlyFailure ]

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2021-08-26  Sergio Villar Senin  <svillar@igalia.com>
+
+        Interoperability issue in margin collapsing with overflow:hidden elements
+        https://bugs.webkit.org/show_bug.cgi?id=224185
+
+        Reviewed by Alan Bujtas.
+
+        Margins should not self collapse for those elements that create new formatting contexts
+        like when using overflow:hidden.
+
+        Test: fast/block/margin-collapse/self-collapsing-block-with-overflow-hidden.html
+
+        * rendering/RenderBlock.cpp:
+        (WebCore::RenderBlock::isSelfCollapsingBlock const): Boxes that create new formatting context should
+        not self collapse.
+
 2021-09-07  Brent Fulgham  <bfulgham@apple.com>
 

trunk/Source/WebCore/rendering/RenderBlock.cpp

@@ -510 +510 @@
     // on whether we have content that is all self-collapsing or not.
     if (hasAutoHeight || ((logicalHeightLength.isFixed() || logicalHeightLength.isPercentOrCalculated()) && logicalHeightLength.isZero()))
-        return !childrenPreventSelfCollapsing();
+        return !createsNewFormattingContext() && !childrenPreventSelfCollapsing();
+
 
     return false;