Changeset 282204 in webkit

Timestamp:

Sep 9, 2021 2:38:41 AM (10 months ago)

Author:

mmaxfield@apple.com

Message:

FontFaceSet.has() needs to react to style changes
​https://bugs.webkit.org/show_bug.cgi?id=229848

Reviewed by Antti Koivisto.

LayoutTests/imported/w3c:

This test was landed upstream in ​https://github.com/web-platform-tests/wpt/pull/30322

• web-platform-tests/css/css-font-loading/fontfaceset-has-expected.txt: Added.
• web-platform-tests/css/css-font-loading/fontfaceset-has.html: Added.

Source/WebCore:

When content says "document.fonts.has(...)", the ".has(...)" part needs to
update style instead of the "document.fonts" part. This is because it's
totally legal for content to say:

var f = document.fonts;
Modify style here
... f.has(...) ... <=== This needs to reflect the style changes.

Test: imported/w3c/web-platform-tests/css/css-font-loading/fontfaceset-has.html

• css/FontFaceSet.cpp:

(WebCore::FontFaceSet::has const):

Location:

trunk

Files:

• LayoutTests/imported/w3c/ChangeLog (modified) (1 diff)
• LayoutTests/imported/w3c/web-platform-tests/css/css-font-loading/fontfaceset-has-expected.txt (added)
• LayoutTests/imported/w3c/web-platform-tests/css/css-font-loading/fontfaceset-has.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/css/FontFaceSet.cpp (modified) (1 diff)

trunk/LayoutTests/imported/w3c/ChangeLog

@@ +1 @@
+2021-09-09  Myles C. Maxfield  <mmaxfield@apple.com>
+
+        FontFaceSet.has() needs to react to style changes
+        https://bugs.webkit.org/show_bug.cgi?id=229848
+
+        Reviewed by Antti Koivisto.
+
+        This test was landed upstream in https://github.com/web-platform-tests/wpt/pull/30322
+
+        * web-platform-tests/css/css-font-loading/fontfaceset-has-expected.txt: Added.
+        * web-platform-tests/css/css-font-loading/fontfaceset-has.html: Added.
+
 2021-09-09  Cameron McCormack  <heycam@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2021-09-09  Myles C. Maxfield  <mmaxfield@apple.com>
+
+        FontFaceSet.has() needs to react to style changes
+        https://bugs.webkit.org/show_bug.cgi?id=229848
+
+        Reviewed by Antti Koivisto.
+
+        When content says "document.fonts.has(...)", the ".has(...)" part needs to
+        update style instead of the "document.fonts" part. This is because it's
+        totally legal for content to say:
+
+        var f = document.fonts;
+        // Modify style here
+        ... f.has(...) ... <=== This needs to reflect the style changes.
+
+        Test: imported/w3c/web-platform-tests/css/css-font-loading/fontfaceset-has.html
+
+        * css/FontFaceSet.cpp:
+        (WebCore::FontFaceSet::has const):
+
 2021-09-09  Antti Koivisto  <antti@apple.com>
 

trunk/Source/WebCore/css/FontFaceSet.cpp

@@ -108 +108 @@
 bool FontFaceSet::has(FontFace& face) const
 {
+    if (face.backing().cssConnection())
+        m_backing->updateStyleIfNeeded();
     return m_backing->hasFace(face.backing());
 }