Changeset 282261 in webkit


Ignore:
Timestamp:
Sep 9, 2021 11:42:31 PM (10 months ago)
Author:
mmaxfield@apple.com
Message:

FontFaceSet.load() needs to react to style changes
​https://bugs.webkit.org/show_bug.cgi?id=230132

Reviewed by Antti Koivisto.

LayoutTests/imported/w3c:

This test is being upstreamed in ​https://github.com/web-platform-tests/wpt/pull/30491

  • web-platform-tests/css/css-font-loading/fontfaceset-load-css-connected-expected.txt: Added.
  • web-platform-tests/css/css-font-loading/fontfaceset-load-css-connected.html: Added.

Source/WebCore:

If content does something like
let fonts = document.fonts;
... modify style sheets ...
fonts.load(...)

The load() function needs to see the result of hte style sheet modification.

Test: imported/w3c/web-platform-tests/css/css-font-loading/fontfaceset-load-css-connected.html

  • css/FontFaceSet.cpp:

(WebCore::FontFaceSet::load):

Location:
trunk
Files:
2 added
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/imported/w3c/ChangeLog

    r282234 r282261  
     12021-09-09  Myles C. Maxfield  <mmaxfield@apple.com>
     2
     3        FontFaceSet.load() needs to react to style changes
     4        https://bugs.webkit.org/show_bug.cgi?id=230132
     5
     6        Reviewed by Antti Koivisto.
     7
     8        This test is being upstreamed in https://github.com/web-platform-tests/wpt/pull/30491
     9
     10        * web-platform-tests/css/css-font-loading/fontfaceset-load-css-connected-expected.txt: Added.
     11        * web-platform-tests/css/css-font-loading/fontfaceset-load-css-connected.html: Added.
     12
    1132021-09-09  Simon Fraser  <simon.fraser@apple.com>
    214

  • trunk/Source/WebCore/ChangeLog

    r282260 r282261  
     12021-09-09  Myles C. Maxfield  <mmaxfield@apple.com>
     2
     3        FontFaceSet.load() needs to react to style changes
     4        https://bugs.webkit.org/show_bug.cgi?id=230132
     5
     6        Reviewed by Antti Koivisto.
     7
     8        If content does something like
     9        let fonts = document.fonts;
     10        ... modify style sheets ...
     11        fonts.load(...)
     12
     13        The load() function needs to see the result of hte style sheet modification.
     14
     15        Test: imported/w3c/web-platform-tests/css/css-font-loading/fontfaceset-load-css-connected.html
     16
     17        * css/FontFaceSet.cpp:
     18        (WebCore::FontFaceSet::load):
     19
    1202021-09-09  Frédéric Wang  <fwang@igalia.com>
    221

  • trunk/Source/WebCore/css/FontFaceSet.cpp

    r282204 r282261  
    150150void FontFaceSet::load(const String& font, const String& text, LoadPromise&& promise)
    151151{
     152    m_backing->updateStyleIfNeeded();
    152153    auto matchingFacesResult = m_backing->matchingFacesExcludingPreinstalledFonts(font, text);
    153154    if (matchingFacesResult.hasException()) {
Note: See TracChangeset for help on using the changeset viewer.