Changeset 282316 in webkit

Timestamp:

Sep 12, 2021 11:40:39 AM (10 months ago)

Author:

Simon Fraser

Message:

Implement getClientRects() for SVG elements
​https://bugs.webkit.org/show_bug.cgi?id=230197

Reviewed by Sam Weinig.

Source/WebCore:

For SVG elements we can just use absoluteQuads().

Test: svg/custom/getClientRects.xhtml

• dom/Element.cpp:

(WebCore::Element::getClientRects):

LayoutTests:

• svg/custom/getClientRects-expected.txt: Added.
• svg/custom/getClientRects.xhtml: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/ios-wk2/svg/custom (added)
• LayoutTests/platform/ios-wk2/svg/custom/getClientRects-expected.txt (added)
• LayoutTests/svg/custom/getClientRects-expected.txt (added)
• LayoutTests/svg/custom/getClientRects.xhtml (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/dom/Element.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2021-09-12  Simon Fraser  <simon.fraser@apple.com>
+
+        Implement getClientRects() for SVG elements
+        https://bugs.webkit.org/show_bug.cgi?id=230197
+
+        Reviewed by Sam Weinig.
+
+        * svg/custom/getClientRects-expected.txt: Added.
+        * svg/custom/getClientRects.xhtml: Added.
+
 2021-09-11  Philippe Normand  <pnormand@igalia.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2021-09-12  Simon Fraser  <simon.fraser@apple.com>
+
+        Implement getClientRects() for SVG elements
+        https://bugs.webkit.org/show_bug.cgi?id=230197
+
+        Reviewed by Sam Weinig.
+
+        For SVG elements we can just use absoluteQuads().
+
+        Test: svg/custom/getClientRects.xhtml
+
+        * dom/Element.cpp:
+        (WebCore::Element::getClientRects):
+
 2021-09-11  Simon Fraser  <simon.fraser@apple.com>
 

trunk/Source/WebCore/dom/Element.cpp

@@ -1642 +1642 @@
     } else if (auto* renderBoxModelObject = this->renderBoxModelObject())
         renderBoxModelObject->absoluteQuads(quads);
-
-    // FIXME: Handle SVG elements.
+    else if (isSVGElement() && renderer)
+        renderer->absoluteQuads(quads);
+
     // FIXME: Handle table/inline-table with a caption.