Changeset 283075 in webkit


Ignore:
Timestamp:
Sep 25, 2021 12:16:22 AM (10 months ago)
Author:
mmaxfield@apple.com
Message:

Make sure empty font families do the right thing for font palettes
​https://bugs.webkit.org/show_bug.cgi?id=230598
<rdar://problem/83383955>

Reviewed by Tim Horton.

It already works.

These tests are being upstreamed in ​https://github.com/web-platform-tests/wpt/pull/30957.

  • web-platform-tests/css/css-fonts/font-palette-empty-font-family-expected-mismatch.html: Added.
  • web-platform-tests/css/css-fonts/font-palette-empty-font-family.html: Added.
  • web-platform-tests/css/css-fonts/parsing/font-palette-values-invalid-expected.txt:
  • web-platform-tests/css/css-fonts/parsing/font-palette-values-invalid.html:
Location:
trunk/LayoutTests/imported/w3c
Files:
2 added
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/imported/w3c/ChangeLog

    r283073 r283075  
     12021-09-25  Myles C. Maxfield  <mmaxfield@apple.com>
     2
     3        Make sure empty font families do the right thing for font palettes
     4        https://bugs.webkit.org/show_bug.cgi?id=230598
     5        <rdar://problem/83383955>
     6
     7        Reviewed by Tim Horton.
     8
     9        It already works.
     10
     11        These tests are being upstreamed in https://github.com/web-platform-tests/wpt/pull/30957.
     12
     13        * web-platform-tests/css/css-fonts/font-palette-empty-font-family-expected-mismatch.html: Added.
     14        * web-platform-tests/css/css-fonts/font-palette-empty-font-family.html: Added.
     15        * web-platform-tests/css/css-fonts/parsing/font-palette-values-invalid-expected.txt:
     16        * web-platform-tests/css/css-fonts/parsing/font-palette-values-invalid.html:
     17
    1182021-09-24  Nikos Mouchtaris  <nmouchtaris@apple.com>
    219

  • trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-palette-values-invalid-expected.txt

    r282806 r283075  
    1414PASS CSS Fonts Module Level 4: parsing @font-palette-values 12
    1515PASS CSS Fonts Module Level 4: parsing @font-palette-values 13
     16PASS CSS Fonts Module Level 4: parsing @font-palette-values 14
    1617

  • trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-palette-values-invalid.html

    r282806 r283075  
    7979    override-color: 0;
    8080}
     81
     82/* 13 */
     83@font-palette-values A {
     84    font-family: "";
     85}
    8186</style>
    8287</head>
    … …  
    8590let rules = document.getElementById("style").sheet.cssRules;
    8691test(function() {
    87     assert_equals(rules.length, 13);
     92    assert_equals(rules.length, 14);
    8893});
    8994
    … …  
    178183    assert_equals(rule.size, 0);
    179184});
     185
     186test(function() {
     187    let text = rules[13].cssText;
     188    let rule = rules[13];
     189    // I see nothing in the spec that indicates an empty string is a parse error.
     190    assert_not_equals(text.indexOf("font-family"), -1);
     191});
    180192</script>
    181193</body>
Note: See TracChangeset for help on using the changeset viewer.