Changeset 283130 in webkit


Ignore:
Timestamp:
Sep 27, 2021 12:50:12 PM (10 months ago)
Author:
mmaxfield@apple.com
Message:

The CSS Fonts spec has deleted CSSRule.FONT_PALETTE_VALUES_RULE
​https://bugs.webkit.org/show_bug.cgi?id=230786
<rdar://problem/83528219>

Reviewed by Antti Koivisto.

LayoutTests/imported/w3c:

The test is being upstreamed at ​https://github.com/web-platform-tests/wpt/pull/30959.

  • web-platform-tests/css/css-fonts/idlharness-expected.txt:
  • web-platform-tests/css/css-fonts/parsing/font-palette-values-invalid-expected.txt:
  • web-platform-tests/css/css-fonts/parsing/font-palette-values-invalid.html:
  • web-platform-tests/css/css-fonts/parsing/font-palette-values-valid.html:
  • web-platform-tests/interfaces/css-fonts.idl:

Source/WebCore:

Update WebKit according to
​https://github.com/w3c/csswg-drafts/commit/45bda92646e0438c1fcd44497144aa86f0df1b61.

Test: web-platform-tests/css/css-fonts/parsing/font-palette-values-invalid.html

  • css/CSSRule.h:
  • css/CSSRule.idl:
  • css/StyleRuleType.h:
Location:
trunk
Files:
10 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/imported/w3c/ChangeLog

    r283120 r283130  
     12021-09-27  Myles C. Maxfield  <mmaxfield@apple.com>
     2
     3        The CSS Fonts spec has deleted CSSRule.FONT_PALETTE_VALUES_RULE
     4        https://bugs.webkit.org/show_bug.cgi?id=230786
     5        <rdar://problem/83528219>
     6
     7        Reviewed by Antti Koivisto.
     8
     9        The test is being upstreamed at https://github.com/web-platform-tests/wpt/pull/30959.
     10
     11        * web-platform-tests/css/css-fonts/idlharness-expected.txt:
     12        * web-platform-tests/css/css-fonts/parsing/font-palette-values-invalid-expected.txt:
     13        * web-platform-tests/css/css-fonts/parsing/font-palette-values-invalid.html:
     14        * web-platform-tests/css/css-fonts/parsing/font-palette-values-valid.html:
     15        * web-platform-tests/interfaces/css-fonts.idl:
     16
    1172021-09-27  Antti Koivisto  <antti@apple.com>
    218

  • trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/idlharness-expected.txt

    r282806 r283130  
    44PASS Partial interface CSSRule: original interface defined
    55PASS Partial interface CSSRule: member names are unique
    6 PASS Partial interface CSSRule[2]: original interface defined
    7 PASS Partial interface CSSRule[2]: member names are unique
    86PASS CSSFontFaceRule interface: existence and properties of interface object
    97PASS CSSFontFaceRule interface object length
    … …  
    1715PASS CSSFontFaceRule interface: cssFontFaceRule must inherit property "style" with the proper type
    1816FAIL CSSRule interface: cssFontFaceRule must inherit property "FONT_FEATURE_VALUES_RULE" with the proper type assert_inherits: property "FONT_FEATURE_VALUES_RULE" not found in prototype chain
    19 FAIL CSSRule interface: cssFontFaceRule must inherit property "FONT_PALETTE_VALUES_RULE" with the proper type assert_equals: expected 15 but got 19
    2017FAIL CSSFontFeatureValuesRule interface: existence and properties of interface object assert_own_property: self does not have own property "CSSFontFeatureValuesRule" expected property "CSSFontFeatureValuesRule" missing
    2118FAIL CSSFontFeatureValuesRule interface object length assert_own_property: self does not have own property "CSSFontFeatureValuesRule" expected property "CSSFontFeatureValuesRule" missing
    … …  
    4845FAIL CSSRule interface: constant FONT_FEATURE_VALUES_RULE on interface object assert_own_property: expected property "FONT_FEATURE_VALUES_RULE" missing
    4946FAIL CSSRule interface: constant FONT_FEATURE_VALUES_RULE on interface prototype object assert_own_property: expected property "FONT_FEATURE_VALUES_RULE" missing
    50 FAIL CSSRule interface: constant FONT_PALETTE_VALUES_RULE on interface object assert_equals: property has wrong value expected 15 but got 19
    51 FAIL CSSRule interface: constant FONT_PALETTE_VALUES_RULE on interface prototype object assert_equals: property has wrong value expected 15 but got 19
    5247FAIL CSSRule interface: cssRule must inherit property "FONT_FEATURE_VALUES_RULE" with the proper type assert_inherits: property "FONT_FEATURE_VALUES_RULE" not found in prototype chain
    53 FAIL CSSRule interface: cssRule must inherit property "FONT_PALETTE_VALUES_RULE" with the proper type assert_equals: expected 15 but got 19
    5448

  • trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-palette-values-invalid-expected.txt

    r283076 r283130  
    1818PASS CSS Fonts Module Level 4: parsing @font-palette-values 16
    1919PASS CSS Fonts Module Level 4: parsing @font-palette-values 17
     20PASS CSS Fonts Module Level 4: parsing @font-palette-values 18
    2021

  • trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-palette-values-invalid.html

    r283076 r283130  
    235235    assert_equals(rule.basePalette, "");
    236236});
     237
     238test(function() {
     239    assert_equals(CSSRule.FONT_PALETTE_VALUES_RULE, undefined);
     240});
    237241</script>
    238242</body>

  • trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-palette-values-valid.html

    r283053 r283130  
    118118test(function() {
    119119    let rule = rules[0];
    120     assert_equals(rule.type, CSSRule.FONT_PALETTE_VALUES_RULE);
    121120    assert_equals(rule.constructor.name, "CSSFontPaletteValuesRule");
    122121    assert_equals(rule.fontFamily, "");

  • trunk/LayoutTests/imported/w3c/web-platform-tests/interfaces/css-fonts.idl

    r269214 r283130  
    2929};
    3030
    31 partial interface CSSRule {  const unsigned short FONT_PALETTE_VALUES_RULE = 15;
    32 };
    33 
    3431[Exposed=Window]
    3532interface CSSFontPaletteValuesRule : CSSRule {

  • trunk/Source/WebCore/ChangeLog

    r283127 r283130  
     12021-09-27  Myles C. Maxfield  <mmaxfield@apple.com>
     2
     3        The CSS Fonts spec has deleted CSSRule.FONT_PALETTE_VALUES_RULE
     4        https://bugs.webkit.org/show_bug.cgi?id=230786
     5        <rdar://problem/83528219>
     6
     7        Reviewed by Antti Koivisto.
     8
     9        Update WebKit according to
     10        https://github.com/w3c/csswg-drafts/commit/45bda92646e0438c1fcd44497144aa86f0df1b61.
     11
     12        Test: web-platform-tests/css/css-fonts/parsing/font-palette-values-invalid.html
     13
     14        * css/CSSRule.h:
     15        * css/CSSRule.idl:
     16        * css/StyleRuleType.h:
     17
    1182021-09-27  Andres Gonzalez  <andresg_22@apple.com>
    219

  • trunk/Source/WebCore/css/CSSRule.h

    r282806 r283130  
    5252        COUNTER_STYLE_RULE = 11,
    5353        SUPPORTS_RULE = 12,
    54         FONT_PALETTE_VALUES_RULE = 19 // https://github.com/w3c/csswg-drafts/issues/6623
     54        FONT_PALETTE_VALUES_RULE = 19
    5555    };
    5656

  • trunk/Source/WebCore/css/CSSRule.idl

    r282806 r283130  
    4545    [EnabledBySetting=CSSCounterStyleAtRules] const unsigned short COUNTER_STYLE_RULE = 11;
    4646    const unsigned short SUPPORTS_RULE = 12;
    47     const unsigned short FONT_PALETTE_VALUES_RULE = 19; /* https://github.com/w3c/csswg-drafts/issues/6623 */
    4847
    4948    // Legacy synonyms for the above, kept to avoid breaking existing content.

  • trunk/Source/WebCore/css/StyleRuleType.h

    r282806 r283130  
    4242    CounterStyle = 11,
    4343    Supports = 12,
    44     FontPaletteValues = 19, // https://github.com/w3c/csswg-drafts/issues/6623
     44    FontPaletteValues = 19,
    4545    Layer = 20
    4646};
Note: See TracChangeset for help on using the changeset viewer.