Changeset 283140 in webkit

Timestamp:

Sep 27, 2021 3:19:30 PM (10 months ago)

Author:

mmaxfield@apple.com

Message:

Add support for CSSFontPaletteValuesRule.name
​https://bugs.webkit.org/show_bug.cgi?id=230787
<rdar://problem/83528540>

Reviewed by Tim Horton.

LayoutTests/imported/w3c:

This is being upstreamed in ​https://github.com/web-platform-tests/wpt/pull/30960.

• web-platform-tests/css/css-fonts/parsing/font-palette-values-valid.html:

Source/WebCore:

This was added to the CSS spec in
​https://github.com/w3c/csswg-drafts/commit/8868476c571d63b7f3f2718e22601a711a2d8683.

Test: web-platform-tests/css/css-fonts/parsing/font-palette-values-valid.html

• css/CSSFontPaletteValuesRule.cpp:

(WebCore::CSSFontPaletteValuesRule::name const):

• css/CSSFontPaletteValuesRule.h:
• css/CSSFontPaletteValuesRule.idl:

Location:

trunk

Files:

• LayoutTests/imported/w3c/ChangeLog (modified) (1 diff)
• LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-palette-values-valid.html (modified) (16 diffs)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/css/CSSFontPaletteValuesRule.cpp (modified) (1 diff)
• Source/WebCore/css/CSSFontPaletteValuesRule.h (modified) (1 diff)
• Source/WebCore/css/CSSFontPaletteValuesRule.idl (modified) (1 diff)

trunk/LayoutTests/imported/w3c/ChangeLog

@@ +1 @@
+2021-09-27  Myles C. Maxfield  <mmaxfield@apple.com>
+
+        Add support for CSSFontPaletteValuesRule.name
+        https://bugs.webkit.org/show_bug.cgi?id=230787
+        <rdar://problem/83528540>
+
+        Reviewed by Tim Horton.
+
+        This is being upstreamed in https://github.com/web-platform-tests/wpt/pull/30960.
+
+        * web-platform-tests/css/css-fonts/parsing/font-palette-values-valid.html:
+
 2021-09-27  Myles C. Maxfield  <mmaxfield@apple.com>
 

trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-fonts/parsing/font-palette-values-valid.html

@@ -119 +119 @@
     let rule = rules[0];
     assert_equals(rule.constructor.name, "CSSFontPaletteValuesRule");
+    assert_equals(rule.name, "A");
     assert_equals(rule.fontFamily, "");
     assert_equals(rule.basePalette, "");
@@ -131 +132 @@
 test(function() {
     let rule = rules[1];
+    assert_equals(rule.name, "B");
     assert_equals(rule.fontFamily, "");
     assert_equals(rule.basePalette, "");
@@ -150 +152 @@
 test(function() {
     let rule = rules[2];
+    assert_equals(rule.name, "C");
     assert_equals(rule.fontFamily, "bar");
     assert_equals(rule.basePalette, "2");
@@ -167 +170 @@
 test(function() {
     let rule = rules[3];
+    assert_equals(rule.name, "D");
     assert_equals(rule.fontFamily, "");
     assert_equals(rule.basePalette, "bar");
@@ -182 +186 @@
 test(function() {
     let rule = rules[4];
+    assert_equals(rule.name, "E");
     assert_equals(rule.fontFamily, "");
     assert_equals(rule.basePalette, "");
@@ -196 +201 @@
 test(function() {
     let rule = rules[5];
+    assert_equals(rule.name, "F");
     assert_equals(rule.fontFamily, "foo");
     assert_equals(rule.basePalette, "");
@@ -209 +215 @@
 test(function() {
     let rule = rules[6];
+    assert_equals(rule.name, "G");
     assert_equals(rule.fontFamily, "");
     assert_equals(rule.basePalette, "");
@@ -225 +232 @@
 test(function() {
     let rule = rules[7];
+    assert_equals(rule.name, "H");
     assert_equals(rule.fontFamily, "");
     assert_equals(rule.basePalette, "");
@@ -240 +248 @@
 test(function() {
     let rule = rules[8];
+    assert_equals(rule.name, "I");
     assert_equals(rule.fontFamily, "");
     assert_equals(rule.basePalette, "-3");
@@ -252 +261 @@
 test(function() {
     let rule = rules[9];
+    assert_equals(rule.name, "J");
     assert_equals(rule.fontFamily, "");
     assert_equals(rule.basePalette, "");
@@ -267 +277 @@
 test(function() {
     let rule = rules[10];
+    assert_equals(rule.name, "K");
     assert_equals(rule.fontFamily, "");
     assert_equals(rule.basePalette, "");
@@ -281 +292 @@
 test(function() {
     let rule = rules[11];
+    assert_equals(rule.name, "L");
     assert_equals(rule.fontFamily, "");
     assert_equals(rule.basePalette, "");
@@ -295 +307 @@
 test(function() {
     let rule = rules[12];
+    assert_equals(rule.name, "M");
     assert_equals(rule.fontFamily, "");
     assert_equals(rule.basePalette, "");
@@ -309 +322 @@
 test(function() {
     let rule = rules[13];
+    assert_equals(rule.name, "N");
     assert_equals(rule.fontFamily, "");
     assert_equals(rule.basePalette, "");
@@ -323 +337 @@
 test(function() {
     let rule = rules[14];
+    assert_equals(rule.name, "O");
     assert_equals(rule.fontFamily, "");
     assert_equals(rule.basePalette, "");
@@ -337 +352 @@
 test(function() {
     let rule = rules[15];
+    assert_equals(rule.name, "P");
     assert_equals(rule.fontFamily, "");
     assert_equals(rule.basePalette, "");

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2021-09-27  Myles C. Maxfield  <mmaxfield@apple.com>
+
+        Add support for CSSFontPaletteValuesRule.name
+        https://bugs.webkit.org/show_bug.cgi?id=230787
+        <rdar://problem/83528540>
+
+        Reviewed by Tim Horton.
+
+        This was added to the CSS spec in
+        https://github.com/w3c/csswg-drafts/commit/8868476c571d63b7f3f2718e22601a711a2d8683.
+
+        Test: web-platform-tests/css/css-fonts/parsing/font-palette-values-valid.html
+
+        * css/CSSFontPaletteValuesRule.cpp:
+        (WebCore::CSSFontPaletteValuesRule::name const):
+        * css/CSSFontPaletteValuesRule.h:
+        * css/CSSFontPaletteValuesRule.idl:
+
 2021-09-27  Takashi Komori  <Takashi.Komori@sony.com>
 

trunk/Source/WebCore/css/CSSFontPaletteValuesRule.cpp

@@ -45 +45 @@
 CSSFontPaletteValuesRule::~CSSFontPaletteValuesRule()
 {
+}
+
+String CSSFontPaletteValuesRule::name() const
+{
+    return m_fontPaletteValuesRule->name();
 }
 

trunk/Source/WebCore/css/CSSFontPaletteValuesRule.h

@@ -43 +43 @@
     virtual ~CSSFontPaletteValuesRule();
 
+    String name() const;
     String fontFamily() const;
     String basePalette() const;

trunk/Source/WebCore/css/CSSFontPaletteValuesRule.idl

@@ -24 +24 @@
 ] interface CSSFontPaletteValuesRule : CSSRule {
     readonly maplike<unsigned long, CSSOMString>;
+    readonly attribute CSSOMString name;
     readonly attribute CSSOMString fontFamily;
     readonly attribute CSSOMString basePalette;