Changeset 283197 in webkit

Timestamp:

Sep 28, 2021 3:03:46 PM (10 months ago)

Author:

mmaxfield@apple.com

Message:

Negative integers in @font-palette-values are invalid
​https://bugs.webkit.org/show_bug.cgi?id=230788

Reviewed by Simon Fraser.
<rdar://problem/83528806>

Addressing post-commit review.

No new tests because there is no behavior change.

• platform/graphics/cocoa/FontCacheCoreText.cpp:

(WebCore::addAttributesForFontPalettes):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/cocoa/FontCacheCoreText.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2021-09-28  Myles C. Maxfield  <mmaxfield@apple.com>
+
+        Negative integers in @font-palette-values are invalid
+        https://bugs.webkit.org/show_bug.cgi?id=230788
+
+        Reviewed by Simon Fraser.
+        <rdar://problem/83528806>
+
+        Addressing post-commit review.
+
+        No new tests because there is no behavior change.
+
+        * platform/graphics/cocoa/FontCacheCoreText.cpp:
+        (WebCore::addAttributesForFontPalettes):
+
 2021-09-28  Cameron McCormack  <heycam@apple.com>
 

trunk/Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp

@@ -453 +453 @@
         break;
     case FontPalette::Type::Light: {
-        auto light = kCTFontPaletteLight;
+        CFIndex light = kCTFontPaletteLight;
         auto number = adoptCF(CFNumberCreate(kCFAllocatorDefault, kCFNumberCFIndexType, &light));
         CFDictionaryAddValue(attributes, kCTFontPaletteAttribute, number.get());
@@ -459 +459 @@
     }
     case FontPalette::Type::Dark: {
-        auto dark = kCTFontPaletteDark;
+        CFIndex dark = kCTFontPaletteDark;
         auto number = adoptCF(CFNumberCreate(kCFAllocatorDefault, kCFNumberCFIndexType, &dark));
         CFDictionaryAddValue(attributes, kCTFontPaletteAttribute, number.get());