Changeset 283794 in webkit


Ignore:
Timestamp:
Oct 8, 2021 12:57:33 AM (10 months ago)
Author:
mmaxfield@apple.com
Message:

font-families inside @font-palette-values need to be case insensitive
​https://bugs.webkit.org/show_bug.cgi?id=231215
<rdar://problem/83871643>

Reviewed by Antti Koivisto.

LayoutTests/imported/w3c:

  • web-platform-tests/css/css-fonts/font-palette-33-expected.html: Added.
  • web-platform-tests/css/css-fonts/font-palette-33.html: Added.
  • web-platform-tests/css/css-fonts/font-palette-34-expected.html: Added.
  • web-platform-tests/css/css-fonts/font-palette-34.html: Added.

Source/WebCore:

​https://drafts.csswg.org/css-fonts-4/#font-family-2-desc says:

The value of this descriptor matches the definition of the <family-name> for the font-family property.

Tests: imported/w3c/web-platform-tests/css/css-fonts/font-palette-33.html

imported/w3c/web-platform-tests/css/css-fonts/font-palette-34.html

  • css/CSSFontSelector.h:
Location:
trunk
Files:
4 added
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/imported/w3c/ChangeLog

    r283765 r283794  
     12021-10-08  Myles C. Maxfield  <mmaxfield@apple.com>
     2
     3        font-families inside @font-palette-values need to be case insensitive
     4        https://bugs.webkit.org/show_bug.cgi?id=231215
     5        <rdar://problem/83871643>
     6
     7        Reviewed by Antti Koivisto.
     8
     9        * web-platform-tests/css/css-fonts/font-palette-33-expected.html: Added.
     10        * web-platform-tests/css/css-fonts/font-palette-33.html: Added.
     11        * web-platform-tests/css/css-fonts/font-palette-34-expected.html: Added.
     12        * web-platform-tests/css/css-fonts/font-palette-34.html: Added.
     13
    1142021-10-07  Alexey Shvayka  <shvaikalesh@gmail.com>
    215

  • trunk/Source/WebCore/ChangeLog

    r283793 r283794  
     12021-10-08  Myles C. Maxfield  <mmaxfield@apple.com>
     2
     3        font-families inside @font-palette-values need to be case insensitive
     4        https://bugs.webkit.org/show_bug.cgi?id=231215
     5        <rdar://problem/83871643>
     6
     7        Reviewed by Antti Koivisto.
     8
     9        https://drafts.csswg.org/css-fonts-4/#font-family-2-desc says:
     10        > The value of this descriptor matches the definition of the <family-name> for the font-family property.
     11
     12        Tests: imported/w3c/web-platform-tests/css/css-fonts/font-palette-33.html
     13               imported/w3c/web-platform-tests/css/css-fonts/font-palette-34.html
     14
     15        * css/CSSFontSelector.h:
     16
    1172021-10-07  Simon Fraser  <simon.fraser@apple.com>
    218

  • trunk/Source/WebCore/css/CSSFontSelector.h

    r283756 r283794  
    129129    HashSet<FontSelectorClient*> m_clients;
    130130
    131     HashMap<std::pair<AtomString, AtomString>, FontPaletteValues> m_paletteMap;
     131    struct PaletteMapHash : WTF::DefaultHash<std::pair<AtomString, AtomString>> {
     132        static unsigned hash(const std::pair<AtomString, AtomString>& key)
     133        {
     134            return pairIntHash(ASCIICaseInsensitiveHash::hash(key.first), WTF::DefaultHash<AtomString>::hash(key.second));
     135        }
     136
     137        static bool equal(const std::pair<AtomString, AtomString>& a, const std::pair<AtomString, AtomString>& b)
     138        {
     139            return ASCIICaseInsensitiveHash::equal(a.first, b.first) && WTF::DefaultHash<AtomString>::equal(a.second, b.second);
     140        }
     141    };
     142    HashMap<std::pair<AtomString, AtomString>, FontPaletteValues, PaletteMapHash> m_paletteMap;
    132143
    133144    HashSet<RefPtr<CSSFontFace>> m_cssConnectionsPossiblyToRemove;
Note: See TracChangeset for help on using the changeset viewer.