Changeset 284986 in webkit

Timestamp:

Oct 28, 2021 9:28:03 AM (9 months ago)

Author:

Razvan Caliman

Message:

Web Inspector: Audit: testForLinkLabels Accessibility audit should ignore anchors if aria-hidden
​https://bugs.webkit.org/show_bug.cgi?id=231038
<rdar://problem/83783868>

Update testForLinkLabels accessibility audit test to exclude hidden links.
See AccessibilityObject->isHidden()

Reviewed by BJ Burg.

• UserInterface/NonMinified/DefaultAudits.js:

(WI.DefaultAudits.testForLinkLabels):

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/NonMinified/DefaultAudits.js (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2021-10-28  Razvan Caliman  <rcaliman@apple.com>
+
+        Web Inspector: Audit: testForLinkLabels Accessibility audit should ignore anchors if aria-hidden
+        https://bugs.webkit.org/show_bug.cgi?id=231038
+        <rdar://problem/83783868>
+
+        Update `testForLinkLabels` accessibility audit test to exclude hidden links.
+        See `AccessibilityObject->isHidden()`
+
+        Reviewed by BJ Burg.
+
+        * UserInterface/NonMinified/DefaultAudits.js:
+        (WI.DefaultAudits.testForLinkLabels):
+
 2021-10-27  BJ Burg  <bburg@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/NonMinified/DefaultAudits.js

@@ -239 +239 @@
 WI.DefaultAudits.testForLinkLabels = function() {
     let links = WebInspectorAudit.Accessibility.getElementsByComputedRole("link");
-    let domNodes = links.filter((link) => !WebInspectorAudit.Accessibility.getComputedProperties(link).label);
+    let domNodes = links.filter((link) => {
+        let properties = WebInspectorAudit.Accessibility.getComputedProperties(link);
+        return !properties.label && !properties.hidden;
+    });
     return {level: domNodes.length ? "fail" : "pass", domNodes, domAttributes: ["aria-label", "aria-labelledby", "title"]};
 };