Changeset 285021 in webkit


Ignore:
Timestamp:
Oct 29, 2021 2:13:24 AM (9 months ago)
Author:
Martin Robinson
Message:

opacity should flatten when combined with transform-style: preserve-3d
​https://bugs.webkit.org/show_bug.cgi?id=73267

Reviewed by Simon Fraser.

LayoutTests/imported/w3c:

  • web-platform-tests/css/css-transforms/preserve-3d-flat-grouping-properties-expected.txt: Update expectations to

show newly passing test.

Source/WebCore:

No new tests. This is covered by the existing WPT test:

  • imported/w3c/web-platform-tests/css/css-transforms/preserve-3d-flat-grouping-properties.html
  • style/StyleAdjuster.cpp:

(WebCore::Style::Adjuster::adjust const):

LayoutTests:

  • compositing/geometry/preserve-3d-switching-expected.txt:
  • platform/ios/compositing/geometry/preserve-3d-switching-expected.txt:
Location:
trunk
Files:
7 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r285016 r285021  
     12021-10-29  Martin Robinson  <mrobinson@webkit.org>
     2
     3        opacity should flatten when combined with transform-style: preserve-3d
     4        https://bugs.webkit.org/show_bug.cgi?id=73267
     5
     6        Reviewed by Simon Fraser.
     7
     8        * compositing/geometry/preserve-3d-switching-expected.txt:
     9        * platform/ios/compositing/geometry/preserve-3d-switching-expected.txt:
     10
    1112021-10-28  Gabriel Nava Marino  <gnavamarino@apple.com>
    212

  • trunk/LayoutTests/compositing/geometry/preserve-3d-switching-expected.txt

    r168244 r285021  
    2020              (opacity 0.80)
    2121              (contentsOpaque 1)
    22               (preserves3D 1)
    23               (drawsContent 1)
    2422              (transform [0.77 -0.56 -0.32 0.00] [0.00 0.50 -0.87 0.00] [0.64 0.66 0.38 0.00] [0.00 0.00 0.00 1.00])
    2523              (children 1

  • trunk/LayoutTests/imported/w3c/ChangeLog

    r285012 r285021  
     12021-10-29  Martin Robinson  <mrobinson@webkit.org>
     2
     3        opacity should flatten when combined with transform-style: preserve-3d
     4        https://bugs.webkit.org/show_bug.cgi?id=73267
     5
     6        Reviewed by Simon Fraser.
     7
     8        * web-platform-tests/css/css-transforms/preserve-3d-flat-grouping-properties-expected.txt: Update expectations to
     9        show newly passing test.
     10
    1112021-10-28  Chris Dumez  <cdumez@apple.com>
    212

  • trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/preserve-3d-flat-grouping-properties-expected.txt

    r284869 r285021  
    11
    22PASS Preserve-3d element not flattened
    3 FAIL Preserve-3d element flattened due to opacity assert_not_equals: got disallowed value 0
     3PASS Preserve-3d element flattened due to opacity
    44PASS Preserve-3d element flattened due to overflow clip
    55PASS Preserve-3d element flattened due to filter

  • trunk/LayoutTests/platform/ios/compositing/geometry/preserve-3d-switching-expected.txt

    r223799 r285021  
    2020              (opacity 0.80)
    2121              (contentsOpaque 1)
    22               (preserves3D 1)
    23               (drawsContent 1)
    2422              (transform [0.77 -0.56 -0.32 0.00] [0.00 0.50 -0.87 0.00] [0.64 0.66 0.38 0.00] [0.00 0.00 0.00 1.00])
    2523              (children 1

  • trunk/Source/WebCore/ChangeLog

    r285017 r285021  
     12021-10-29  Martin Robinson  <mrobinson@webkit.org>
     2
     3        opacity should flatten when combined with transform-style: preserve-3d
     4        https://bugs.webkit.org/show_bug.cgi?id=73267
     5
     6        Reviewed by Simon Fraser.
     7
     8        No new tests. This is covered by the existing WPT test:
     9            - imported/w3c/web-platform-tests/css/css-transforms/preserve-3d-flat-grouping-properties.html
     10
     11        * style/StyleAdjuster.cpp:
     12        (WebCore::Style::Adjuster::adjust const):
     13
    1142021-10-28  Tim Horton  <timothy_horton@apple.com>
    215

  • trunk/Source/WebCore/style/StyleAdjuster.cpp

    r284314 r285021  
    500500        style.setUnique();
    501501
    502     // FIXME: when dropping the -webkit prefix on transform-style, we should also have opacity < 1 cause flattening.
    503502    if (style.preserves3D() && (style.overflowX() != Overflow::Visible
     503        || style.hasOpacity()
    504504        || style.overflowY() != Overflow::Visible
    505505        || style.hasClip()
Note: See TracChangeset for help on using the changeset viewer.