Changeset 285216 in webkit


Ignore:
Timestamp:
Nov 3, 2021 10:59:39 AM (9 months ago)
Author:
Devin Rousso
Message:

[Modern Media Controls] should show tracks button/menu for <audio>
​https://bugs.webkit.org/show_bug.cgi?id=232597

Reviewed by Eric Carlson.

Source/WebCore:

There's nothing preventing <audio> from having multiple <source>. We should have a
language picker for <audio> just like what we have for <video>.

Tests: media/modern-media-controls/tracks-support/audio-multiple-tracks.html

media/modern-media-controls/tracks-support/audio-single-track.html

  • Modules/modern-media-controls/controls/inline-media-controls.js:

(InlineMediaControls.prototype._rightContainerButtons):

LayoutTests:

  • media/modern-media-controls/tracks-support/audio-multiple-tracks.html: Added.
  • media/modern-media-controls/tracks-support/audio-multiple-tracks-expected.txt: Added.
  • media/modern-media-controls/tracks-support/audio-single-track.html: Added.
  • media/modern-media-controls/tracks-support/audio-single-track-expected.txt: Added.
  • media/modern-media-controls/audio/audio-controls-buttons.html:
  • media/modern-media-controls/audio/audio-controls-buttons-expected.txt:
  • platform/ios-wk2/TestExpectations:
Location:
trunk
Files:
4 added
6 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r285214 r285216  
     12021-11-03  Devin Rousso  <drousso@apple.com>
     2
     3        [Modern Media Controls] should show tracks button/menu for <audio>
     4        https://bugs.webkit.org/show_bug.cgi?id=232597
     5
     6        Reviewed by Eric Carlson.
     7
     8        * media/modern-media-controls/tracks-support/audio-multiple-tracks.html: Added.
     9        * media/modern-media-controls/tracks-support/audio-multiple-tracks-expected.txt: Added.
     10        * media/modern-media-controls/tracks-support/audio-single-track.html: Added.
     11        * media/modern-media-controls/tracks-support/audio-single-track-expected.txt: Added.
     12
     13        * media/modern-media-controls/audio/audio-controls-buttons.html:
     14        * media/modern-media-controls/audio/audio-controls-buttons-expected.txt:
     15
     16        * platform/ios-wk2/TestExpectations:
     17
    1182021-11-03  Chris Dumez  <cdumez@apple.com>
    219

  • trunk/LayoutTests/media/modern-media-controls/audio/audio-controls-buttons-expected.txt

    r273004 r285216  
    66Making AirPlay routes available.
    77AirPlay routes became available.
    8 PASS mediaController.controls.rightContainer.children.length is 3
     8PASS mediaController.controls.rightContainer.children.length is 4
    99PASS mediaController.controls.rightContainer.children[0] is mediaController.controls.muteButton
    1010PASS mediaController.controls.rightContainer.children[1] is mediaController.controls.airplayButton

  • trunk/LayoutTests/media/modern-media-controls/audio/audio-controls-buttons.html

    r273004 r285216  
    4343    media.removeEventListener('webkitplaybacktargetavailabilitychanged', playbackTargetAvailabilityChangedAgain, true);
    4444
    45     shouldBe("mediaController.controls.rightContainer.children.length", "3");
     45    shouldBe("mediaController.controls.rightContainer.children.length", "4");
    4646    shouldBe("mediaController.controls.rightContainer.children[0]", "mediaController.controls.muteButton");
    4747    shouldBe("mediaController.controls.rightContainer.children[1]", "mediaController.controls.airplayButton");

  • trunk/LayoutTests/platform/ios-wk2/TestExpectations

    r285134 r285216  
    6969webkit.org/b/231187 media/modern-media-controls/tracks-support/click-track-in-contextmenu.html [ Timeout ]
    7070webkit.org/b/231187 media/modern-media-controls/tracks-support/auto-text-track.html [ Timeout ]
     71webkit.org/b/231187 media/modern-media-controls/tracks-support/audio-multiple-tracks.html [ Timeout ]
     72webkit.org/b/231187 media/modern-media-controls/tracks-support/audio-single-track.html [ Timeout ]
    7173
    7274fast/images/text-recognition [ Pass ]

  • trunk/Source/WebCore/ChangeLog

    r285214 r285216  
     12021-11-03  Devin Rousso  <drousso@apple.com>
     2
     3        [Modern Media Controls] should show tracks button/menu for <audio>
     4        https://bugs.webkit.org/show_bug.cgi?id=232597
     5
     6        Reviewed by Eric Carlson.
     7
     8        There's nothing preventing `<audio>` from having multiple `<source>`. We should have a
     9        language picker for `<audio>` just like what we have for `<video>`.
     10
     11        Tests: media/modern-media-controls/tracks-support/audio-multiple-tracks.html
     12               media/modern-media-controls/tracks-support/audio-single-track.html
     13
     14        * Modules/modern-media-controls/controls/inline-media-controls.js:
     15        (InlineMediaControls.prototype._rightContainerButtons):
     16
    1172021-11-03  Chris Dumez  <cdumez@apple.com>
    218

  • trunk/Source/WebCore/Modules/modern-media-controls/controls/inline-media-controls.js

    r279547 r285216  
    269269    {
    270270        if (this._shouldUseAudioLayout)
    271             return [this.muteButton, this.airplayButton, this.overflowButton];
     271            return [this.muteButton, this.airplayButton, this.tracksButton, this.overflowButton];
    272272
    273273        if (this._shouldUseSingleBarLayout)
Note: See TracChangeset for help on using the changeset viewer.