Changeset 285482 in webkit


Ignore:
Timestamp:
Nov 9, 2021 12:05:39 AM (8 months ago)
Author:
Martin Robinson
Message:

A mask or isolation should set transform-style to flat
​https://bugs.webkit.org/show_bug.cgi?id=232491

Reviewed by Simon Fraser.

LayoutTests/imported/w3c:

Update test results showing newly passing test.

  • web-platform-tests/css/css-transforms/preserve-3d-flat-grouping-properties-expected.txt:

Source/WebCore:

Tests: transforms/preserve-3d-flat-webkit-grouping-properties-expected.txt: Added.

transforms/preserve-3d-flat-webkit-grouping-properties.html: Added.

This is covered by an existing WPT test:

imported/w3c/web-platform-tests/css/css-transforms/preserve-3d-flat-grouping-properties.html

Ensure that values of mask-image other than none, mask-border-source other than none,
and isolation: isolate all force used style of preserve-3d: flat.

  • style/StyleAdjuster.cpp:

(WebCore::Style::Adjuster::adjust const):

LayoutTests:

  • transforms/3d/preserve-3d-flat-webkit-grouping-properties-expected.txt: Added.
  • transforms/3d/preserve-3d-flat-webkit-grouping-properties.html: Added.
Location:
trunk
Files:
2 added
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r285481 r285482  
     12021-11-09  Martin Robinson  <mrobinson@webkit.org>
     2
     3        A mask or isolation should set transform-style to flat
     4        https://bugs.webkit.org/show_bug.cgi?id=232491
     5
     6        Reviewed by Simon Fraser.
     7
     8        * transforms/3d/preserve-3d-flat-webkit-grouping-properties-expected.txt: Added.
     9        * transforms/3d/preserve-3d-flat-webkit-grouping-properties.html: Added.
     10
    1112021-11-08  Said Abou-Hallawa  <said@apple.com>
    212

  • trunk/LayoutTests/imported/w3c/ChangeLog

    r285478 r285482  
     12021-11-09  Martin Robinson  <mrobinson@webkit.org>
     2
     3        A mask or isolation should set transform-style to flat
     4        https://bugs.webkit.org/show_bug.cgi?id=232491
     5
     6        Reviewed by Simon Fraser.
     7
     8        Update test results showing newly passing test.
     9
     10        * web-platform-tests/css/css-transforms/preserve-3d-flat-grouping-properties-expected.txt:
     11
    1122021-11-08  Patrick Griffis  <pgriffis@igalia.com>
    213

  • trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-transforms/preserve-3d-flat-grouping-properties-expected.txt

    r285021 r285482  
    88PASS Preserve-3d element flattened due to clip CSS
    99PASS Preserve-3d element flattened due to clip-path
    10 FAIL Preserve-3d element flattened due to isolation assert_not_equals: got disallowed value 0
    11 FAIL Preserve-3d element flattened due to mask assert_not_equals: got disallowed value 0
     10PASS Preserve-3d element flattened due to isolation
     11PASS Preserve-3d element flattened due to mask
    1212

  • trunk/Source/WebCore/ChangeLog

    r285481 r285482  
     12021-11-09  Martin Robinson  <mrobinson@webkit.org>
     2
     3        A mask or isolation should set transform-style to flat
     4        https://bugs.webkit.org/show_bug.cgi?id=232491
     5
     6        Reviewed by Simon Fraser.
     7
     8        Tests: transforms/preserve-3d-flat-webkit-grouping-properties-expected.txt: Added.
     9               transforms/preserve-3d-flat-webkit-grouping-properties.html: Added.
     10
     11        This is covered by an existing WPT test:
     12            imported/w3c/web-platform-tests/css/css-transforms/preserve-3d-flat-grouping-properties.html
     13
     14        Ensure that values of `mask-image` other than `none`, `mask-border-source` other than `none`,
     15        and `isolation: isolate` all force used style of `preserve-3d: flat`.
     16
     17        * style/StyleAdjuster.cpp:
     18        (WebCore::Style::Adjuster::adjust const):
     19
    1202021-11-08  Said Abou-Hallawa  <said@apple.com>
    221

  • trunk/Source/WebCore/style/StyleAdjuster.cpp

    r285021 r285482  
    506506        || style.clipPath()
    507507        || style.hasFilter()
     508        || style.hasIsolation()
     509        || style.hasMask()
    508510#if ENABLE(FILTERS_LEVEL_2)
    509511        || style.hasBackdropFilter()
Note: See TracChangeset for help on using the changeset viewer.