Changeset 285808 in webkit

Timestamp:

Nov 15, 2021 9:32:18 AM (8 months ago)

Author:

commit-queue@webkit.org

Message:

Empty <input type=file> controls don't show up in the urlencoded and text/plain enctypes
​https://bugs.webkit.org/show_bug.cgi?id=221549

Patch by Andreu Botella <​andreu@andreubotella.com> on 2021-11-15
Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

• web-platform-tests/html/semantics/forms/form-submission-0/form-data-set-empty-file.window-expected.txt:

Source/WebCore:

In the HTML spec, and in Firefox and Chrome's implementations, an empty <input type="file">
control is represented in form submission as if it were an empty file with an empty
filename. WebKit, however, does not include a form entry corresponding to the file input at
all in the application/x-www-form-urlencoded and text/plain enctypes. This change fixes it.

Tests: imported/w3c/web-platform-tests/html/semantics/forms/form-submission-0/form-data-set-empty-file.window.html

• html/FileInputType.cpp:

(WebCore::FileInputType::appendFormData const):

Location:

trunk

Files:

• LayoutTests/imported/w3c/ChangeLog (modified) (1 diff)
• LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/form-submission-0/form-data-set-empty-file.window-expected.txt (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/html/FileInputType.cpp (modified) (1 diff)

trunk/LayoutTests/imported/w3c/ChangeLog

@@ +1 @@
+2021-11-15  Andreu Botella  <andreu@andreubotella.com>
+
+        Empty <input type=file> controls don't show up in the urlencoded and text/plain enctypes
+        https://bugs.webkit.org/show_bug.cgi?id=221549
+
+        Reviewed by Chris Dumez.
+
+        * web-platform-tests/html/semantics/forms/form-submission-0/form-data-set-empty-file.window-expected.txt:
+
 2021-11-15  Cathie Chen  <cathiechen@igalia.com>
 

trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/form-submission-0/form-data-set-empty-file.window-expected.txt

@@ -1 +1 @@
 
 FAIL Empty <input type=file> is still added to the form's entry list assert_equals: type expected "application/octet-stream" but got ""
-FAIL Empty <input type=file> shows up in the urlencoded serialization assert_equals: expected "hi=" but got ""
+PASS Empty <input type=file> shows up in the urlencoded serialization
 PASS Empty <input type=file> shows up in the multipart/form-data serialization
-FAIL Empty <input type=file> shows up in the text/plain serialization assert_equals: expected "hi=\n" but got ""
+FAIL Empty <input type=file> shows up in the text/plain serialization assert_equals: expected "hi=\n" but got "hi="
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2021-11-15  Andreu Botella  <andreu@andreubotella.com>
+
+        Empty <input type=file> controls don't show up in the urlencoded and text/plain enctypes
+        https://bugs.webkit.org/show_bug.cgi?id=221549
+
+        Reviewed by Chris Dumez.
+
+        In the HTML spec, and in Firefox and Chrome's implementations, an empty <input type="file">
+        control is represented in form submission as if it were an empty file with an empty
+        filename. WebKit, however, does not include a form entry corresponding to the file input at
+        all in the application/x-www-form-urlencoded and text/plain enctypes. This change fixes it.
+
+        Tests: imported/w3c/web-platform-tests/html/semantics/forms/form-submission-0/form-data-set-empty-file.window.html
+
+        * html/FileInputType.cpp:
+        (WebCore::FileInputType::appendFormData const):
+
 2021-11-15  Antti Koivisto  <antti@apple.com>
 

trunk/Source/WebCore/html/FileInputType.cpp

@@ -171 +171 @@
         // 4.10.16.4 and 4.10.16.6 sections in HTML5.
 
-        // Unlike the multipart case, we have no special handling for the empty
-        // fileList because Netscape doesn't support for non-multipart
-        // submission of file inputs, and Firefox doesn't add "name=" query
-        // parameter.
+        if (fileList->isEmpty())
+            formData.append(name, "");
+
         for (auto& file : fileList->files())
             formData.append(name, file->name());