Changeset 286149 in webkit

Timestamp:

Nov 24, 2021 7:45:40 AM (8 months ago)

Author:

commit-queue@webkit.org

Message:

[JSC] Implement Date.prototype.toTemporalInstant()
​https://bugs.webkit.org/show_bug.cgi?id=232075

Patch by Aditi Singh <​asingh@igalia.com> on 2021-11-24
Reviewed by Yusuke Suzuki.

JSTests:

• stress/date-to-temporal-instant.js: Added.

(shouldBe):
(shouldThrow):

Source/JavaScriptCore:

• runtime/CommonIdentifiers.h:
• runtime/DatePrototype.cpp:

(JSC::DatePrototype::finishCreation):
(JSC::JSC_DEFINE_HOST_FUNCTION):

Location:

trunk

Files:

• JSTests/ChangeLog (modified) (1 diff)
• JSTests/stress/date-to-temporal-instant.js (added)
• Source/JavaScriptCore/ChangeLog (modified) (1 diff)
• Source/JavaScriptCore/runtime/CommonIdentifiers.h (modified) (1 diff)
• Source/JavaScriptCore/runtime/DatePrototype.cpp (modified) (4 diffs)

trunk/JSTests/ChangeLog

@@ +1 @@
+2021-11-24  Aditi Singh  <asingh@igalia.com>
+
+        [JSC] Implement Date.prototype.toTemporalInstant()
+        https://bugs.webkit.org/show_bug.cgi?id=232075
+
+        Reviewed by Yusuke Suzuki.
+
+        * stress/date-to-temporal-instant.js: Added.
+        (shouldBe):
+        (shouldThrow):
+
 2021-11-19  Asumu Takikawa  <asumu@igalia.com>
 

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2021-11-24  Aditi Singh  <asingh@igalia.com>
+
+        [JSC] Implement Date.prototype.toTemporalInstant()
+        https://bugs.webkit.org/show_bug.cgi?id=232075
+
+        Reviewed by Yusuke Suzuki.
+
+        * runtime/CommonIdentifiers.h:
+        * runtime/DatePrototype.cpp:
+        (JSC::DatePrototype::finishCreation):
+        (JSC::JSC_DEFINE_HOST_FUNCTION):
+
 2021-11-23  Don Olmstead  <don.olmstead@sony.com>
 

trunk/Source/JavaScriptCore/runtime/CommonIdentifiers.h

@@ -252 +252 @@
     macro(toPrecision) \
     macro(toString) \
+    macro(toTemporalInstant) \
     macro(trailingZeroDisplay) \
     macro(type) \

trunk/Source/JavaScriptCore/runtime/DatePrototype.cpp

@@ -35 +35 @@
 #include "JSObject.h"
 #include "JSString.h"
+#include "TemporalInstant.h"
 #include <wtf/Assertions.h>
 
@@ -80 +81 @@
 static JSC_DECLARE_HOST_FUNCTION(dateProtoFuncToISOString);
 static JSC_DECLARE_HOST_FUNCTION(dateProtoFuncToJSON);
+static JSC_DECLARE_HOST_FUNCTION(dateProtoFuncToTemporalInstant);
 
 }
@@ -283 +285 @@
     putDirectWithoutTransition(vm, vm.propertyNames->toPrimitiveSymbol, toPrimitiveFunction, PropertyAttribute::DontEnum | PropertyAttribute::ReadOnly);
 
+    if (Options::useTemporal()) {
+        Identifier toTemporalInstantName = Identifier::fromString(vm, "toTemporalInstant"_s);
+        JSFunction* toTemporalInstantFunction = JSFunction::create(vm, globalObject, 0, toTemporalInstantName.string(), dateProtoFuncToTemporalInstant);
+        putDirectWithoutTransition(vm, toTemporalInstantName, toTemporalInstantFunction, static_cast<unsigned>(PropertyAttribute::DontEnum));
+    }
     // The constructor will be added later, after DateConstructor has been built.
 }
@@ -905 +912 @@
 }
 
+JSC_DEFINE_HOST_FUNCTION(dateProtoFuncToTemporalInstant, (JSGlobalObject* globalObject, CallFrame* callFrame))
+{
+    VM& vm = globalObject->vm();
+    auto scope = DECLARE_THROW_SCOPE(vm);
+    JSValue thisValue = callFrame->thisValue();
+    auto* thisDateObj = jsDynamicCast<DateInstance*>(vm, thisValue);
+    if (UNLIKELY(!thisDateObj))
+        return throwVMTypeError(globalObject, scope);
+
+    double epochMilliseconds = thisDateObj->internalNumber();
+    if (!isInteger(epochMilliseconds)) 
+        return throwVMError(globalObject, scope, createRangeError(globalObject, "Invalid integer number of Epoch Millseconds"_s));
+
+    ASSERT(epochMilliseconds >= std::numeric_limits<int64_t>::min() && epochMilliseconds <= std::numeric_limits<int64_t>::max());
+    ISO8601::ExactTime exactTime = ISO8601::ExactTime::fromEpochMilliseconds(epochMilliseconds);
+    return JSValue::encode(TemporalInstant::create(vm, globalObject->instantStructure(), exactTime));
+}
+
 } // namespace JSC