Changeset 286539 in webkit

Timestamp:

Dec 6, 2021 12:05:45 AM (8 months ago)

Author:

youenn@apple.com

Message:

Close WebRTC allocation sequence shared socket in case of sequence network failure
​https://bugs.webkit.org/show_bug.cgi?id=233808

Reviewed by Geoffrey Garen.

• Source/webrtc/p2p/client/basic_port_allocator.cc:
• Source/webrtc/p2p/client/basic_port_allocator.h:

Location:

trunk/Source/ThirdParty/libwebrtc

Files:

• ChangeLog (modified) (1 diff)
• Source/webrtc/p2p/client/basic_port_allocator.cc (modified) (1 diff)
• Source/webrtc/p2p/client/basic_port_allocator.h (modified) (1 diff)

trunk/Source/ThirdParty/libwebrtc/ChangeLog

@@ +1 @@
+2021-12-06  Youenn Fablet  <youenn@apple.com>
+
+        Close WebRTC allocation sequence shared socket in case of sequence network failure
+        https://bugs.webkit.org/show_bug.cgi?id=233808
+
+        Reviewed by Geoffrey Garen.
+
+        * Source/webrtc/p2p/client/basic_port_allocator.cc:
+        * Source/webrtc/p2p/client/basic_port_allocator.h:
+
 2021-11-22  Youenn Fablet  <youenn@apple.com>
 

trunk/Source/ThirdParty/libwebrtc/Source/webrtc/p2p/client/basic_port_allocator.cc

@@ -1273 +1273 @@
 }
 
+#if defined(WEBRTC_WEBKIT_BUILD)
+void AllocationSequence::set_network_failed()
+{
+  network_failed_ = true;
+  if (udp_socket_) {
+    udp_socket_->SetError(ENETDOWN);
+    udp_socket_->Close();
+  }
+}
+#endif
+
 void AllocationSequence::OnNetworkFailed() {
   RTC_DCHECK(!network_failed_);
-  network_failed_ = true;
+#if defined(WEBRTC_WEBKIT_BUILD)
+  set_network_failed();
+#endif
   // Stop the allocation sequence if its network failed.
   Stop();

trunk/Source/ThirdParty/libwebrtc/Source/webrtc/p2p/client/basic_port_allocator.h

@@ -356 +356 @@
 
   bool network_failed() const { return network_failed_; }
+#if defined(WEBRTC_WEBKIT_BUILD)
+  void set_network_failed();
+#else
   void set_network_failed() { network_failed_ = true; }
+#endif
 
   // Disables the phases for a new sequence that this one already covers for an