Changeset 286803 in webkit

Timestamp:

Dec 9, 2021 2:47:24 PM (7 months ago)

Author:

Brent Fulgham

Message:

Unprefix CSS value text-align: -webkit-match-parent
​https://bugs.webkit.org/show_bug.cgi?id=229496
<rdar://problem/82628618>

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Rebaseline to show new passing tests.

• web-platform-tests/css/css-text/parsing/text-align-computed-expected.txt:
• web-platform-tests/css/css-text/parsing/text-align-valid-expected.txt:

Source/WebCore:

Tested by web-platform-tests: css/css-text/parsing/text-align-computed.html,

css/css-text/parsing/text-align-valid.html

SSIA.

• css/CSSProperties.json: Add the unprefixed version.
• css/CSSValueKeywords.in: Ditto.
• css/html.css:

(li): Use the unprefixed version.

• style/StyleBuilderConverter.h:

(WebCore::Style::BuilderConverter::convertTextAlign): Handle the new unprefixed version.

Source/WebInspectorUI:

• UserInterface/Models/CSSKeywordCompletions.js: Add 'match-parent'

Location:

trunk

Files:

• LayoutTests/imported/w3c/ChangeLog (modified) (1 diff)
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/parsing/text-align-computed-expected.txt (modified) (1 diff)
• LayoutTests/imported/w3c/web-platform-tests/css/css-text/parsing/text-align-valid-expected.txt (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/css/CSSProperties.json (modified) (2 diffs)
• Source/WebCore/css/CSSValueKeywords.in (modified) (1 diff)
• Source/WebCore/css/html.css (modified) (1 diff)
• Source/WebCore/style/StyleBuilderConverter.h (modified) (1 diff)
• Source/WebInspectorUI/ChangeLog (modified) (1 diff)
• Source/WebInspectorUI/UserInterface/Models/CSSKeywordCompletions.js (modified) (1 diff)

trunk/LayoutTests/imported/w3c/ChangeLog

@@ +1 @@
+2021-12-09  Brent Fulgham  <bfulgham@apple.com>
+
+        Unprefix CSS value text-align: -webkit-match-parent
+        https://bugs.webkit.org/show_bug.cgi?id=229496
+        <rdar://problem/82628618>
+
+        Reviewed by Darin Adler.
+
+        Rebaseline to show new passing tests.
+
+        * web-platform-tests/css/css-text/parsing/text-align-computed-expected.txt:
+        * web-platform-tests/css/css-text/parsing/text-align-valid-expected.txt:
+
 2021-12-09  Matt Woodrow  <matt.woodrow@gmail.com>
 

trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-text/parsing/text-align-computed-expected.txt

@@ -6 +6 @@
 PASS Property text-align value 'center'
 PASS Property text-align value 'justify'
-FAIL Property text-align value 'match-parent' assert_true: 'match-parent' is a supported value for text-align. expected true got false
+PASS Property text-align value 'match-parent'
 

trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-text/parsing/text-align-valid-expected.txt

@@ -6 +6 @@
 PASS e.style['text-align'] = "center" should set the property value
 PASS e.style['text-align'] = "justify" should set the property value
-FAIL e.style['text-align'] = "match-parent" should set the property value assert_not_equals: property should be set got disallowed value ""
+PASS e.style['text-align'] = "match-parent" should set the property value
 FAIL e.style['text-align'] = "justify-all" should set the property value assert_not_equals: property should be set got disallowed value ""
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2021-12-09  Brent Fulgham  <bfulgham@apple.com>
+
+        Unprefix CSS value text-align: -webkit-match-parent
+        https://bugs.webkit.org/show_bug.cgi?id=229496
+        <rdar://problem/82628618>
+
+        Reviewed by Darin Adler.
+
+        Tested by web-platform-tests: css/css-text/parsing/text-align-computed.html,
+            css/css-text/parsing/text-align-valid.html 
+
+        SSIA.
+
+        * css/CSSProperties.json: Add the unprefixed version.
+        * css/CSSValueKeywords.in: Ditto.
+        * css/html.css:
+        (li): Use the unprefixed version.
+        * style/StyleBuilderConverter.h:
+        (WebCore::Style::BuilderConverter::convertTextAlign): Handle the new unprefixed version.
+
 2021-12-09  Alan Bujtas  <zalan@apple.com>
 

trunk/Source/WebCore/css/CSSProperties.json

@@ -4502 +4502 @@
                 "center",
                 "justify",
+                {
+                    "value": "match-parent",
+                    "url": "https://www.w3.org/TR/css-text-3/#text-align"
+                },
                 "-webkit-left",
                 "-webkit-right",
@@ -4507 +4511 @@
                 {
                     "value": "-webkit-match-parent",
-                    "url": "https://www.w3.org/TR/css-text-3/#text-align"
+                    "url": "non-standard"
                 },
                 {

trunk/Source/WebCore/css/CSSValueKeywords.in

@@ -343 +343 @@
 -webkit-right
 -webkit-center
+match-parent
 -webkit-match-parent
+//start
+//end
 //
 // CSS_PROP_TEXT_JUSTIFY:

trunk/Source/WebCore/css/html.css

@@ -300 +300 @@
 li {
     display: list-item;
-    text-align: -webkit-match-parent;
+    text-align: match-parent;
 }
 

trunk/Source/WebCore/style/StyleBuilderConverter.h

@@ -613 +613 @@
     ASSERT(primitiveValue.isValueID());
 
-    if (primitiveValue.valueID() != CSSValueWebkitMatchParent)
+    if (primitiveValue.valueID() != CSSValueWebkitMatchParent && primitiveValue.valueID() != CSSValueMatchParent)
         return primitiveValue;
 

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2021-12-09  Brent Fulgham  <bfulgham@apple.com>
+
+        Unprefix CSS value text-align: -webkit-match-parent
+        https://bugs.webkit.org/show_bug.cgi?id=229496
+        <rdar://problem/82628618>
+
+        Reviewed by Darin Adler.
+
+        * UserInterface/Models/CSSKeywordCompletions.js: Add 'match-parent'
+
 2021-12-08  BJ Burg  <bburg@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Models/CSSKeywordCompletions.js

@@ -1347 +1347 @@
     ],
     "text-align": [
-        "-webkit-auto", "left", "right", "center", "justify", "-webkit-left", "-webkit-right", "-webkit-center", "-webkit-match-parent", "start", "end",
+        "-webkit-auto", "left", "right", "center", "justify", "match-parent", "-webkit-left", "-webkit-right", "-webkit-center", "-webkit-match-parent", "start", "end",
     ],
     "text-anchor": [