Changeset 286942 in webkit

Timestamp:

Dec 13, 2021 2:29:36 AM (7 months ago)

Author:

Martin Robinson

Message:

transform-origin on SVG elements does not take into account the transform reference box origin
​https://bugs.webkit.org/show_bug.cgi?id=234078

Reviewed by Rob Buis.

Source/WebCore:

No new tests. This is covered by existing WPT tests.

• svg/SVGGraphicsElement.cpp:

(WebCore::SVGGraphicsElement::animatedLocalTransform const): Add the reference box origin
to the calculated reference box offset when calculating the transform origin for SVG.

LayoutTests:

• TestExpectations: Mark tests as passing.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/TestExpectations (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/svg/SVGGraphicsElement.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2021-12-13  Martin Robinson  <mrobinson@webkit.org>
+
+        `transform-origin` on SVG elements does not take into account the transform reference box origin
+        https://bugs.webkit.org/show_bug.cgi?id=234078
+
+        Reviewed by Rob Buis.
+
+        * TestExpectations: Mark tests as passing.
+
 2021-12-12  Alan Bujtas  <zalan@apple.com>
 

trunk/LayoutTests/TestExpectations

@@ -3990 +3990 @@
 webkit.org/b/230080 imported/w3c/web-platform-tests/css/css-transforms/transform-fixed-bg-006.html [ ImageOnlyFailure ]
 webkit.org/b/230080 imported/w3c/web-platform-tests/css/css-transforms/transform-fixed-bg-007.html [ ImageOnlyFailure ]
-webkit.org/b/230080 imported/w3c/web-platform-tests/css/css-transforms/transform-origin/svg-origin-relative-length-016.html [ ImageOnlyFailure ]
-webkit.org/b/230080 imported/w3c/web-platform-tests/css/css-transforms/transform-origin/svg-origin-relative-length-020.html [ ImageOnlyFailure ]
-webkit.org/b/230080 imported/w3c/web-platform-tests/css/css-transforms/transform-origin/svg-origin-relative-length-021.html [ ImageOnlyFailure ]
-webkit.org/b/230080 imported/w3c/web-platform-tests/css/css-transforms/transform-origin/svg-origin-relative-length-022.html [ ImageOnlyFailure ]
-webkit.org/b/230080 imported/w3c/web-platform-tests/css/css-transforms/transform-origin/svg-origin-relative-length-023.html [ ImageOnlyFailure ]
-webkit.org/b/230080 imported/w3c/web-platform-tests/css/css-transforms/transform-origin/svg-origin-relative-length-024.html [ ImageOnlyFailure ]
-webkit.org/b/230080 imported/w3c/web-platform-tests/css/css-transforms/transform-origin/svg-origin-relative-length-025.html [ ImageOnlyFailure ]
-webkit.org/b/230080 imported/w3c/web-platform-tests/css/css-transforms/transform-origin/svg-origin-relative-length-026.html [ ImageOnlyFailure ]
-webkit.org/b/230080 imported/w3c/web-platform-tests/css/css-transforms/transform-origin/svg-origin-relative-length-027.html [ ImageOnlyFailure ]
-webkit.org/b/230080 imported/w3c/web-platform-tests/css/css-transforms/transform-origin/svg-origin-relative-length-028.html [ ImageOnlyFailure ]
-webkit.org/b/230080 imported/w3c/web-platform-tests/css/css-transforms/transform-origin/svg-origin-relative-length-029.html [ ImageOnlyFailure ]
-webkit.org/b/230080 imported/w3c/web-platform-tests/css/css-transforms/transform-origin/svg-origin-relative-length-030.html [ ImageOnlyFailure ]
-webkit.org/b/230080 imported/w3c/web-platform-tests/css/css-transforms/transform-origin/svg-origin-relative-length-031.html [ ImageOnlyFailure ]
-webkit.org/b/230080 imported/w3c/web-platform-tests/css/css-transforms/transform-origin/svg-origin-relative-length-032.html [ ImageOnlyFailure ]
-webkit.org/b/230080 imported/w3c/web-platform-tests/css/css-transforms/transform-origin/svg-origin-relative-length-033.html [ ImageOnlyFailure ]
-webkit.org/b/230080 imported/w3c/web-platform-tests/css/css-transforms/transform-origin/svg-origin-relative-length-034.html [ ImageOnlyFailure ]
-webkit.org/b/230080 imported/w3c/web-platform-tests/css/css-transforms/transform-origin/svg-origin-relative-length-035.html [ ImageOnlyFailure ]
-webkit.org/b/230080 imported/w3c/web-platform-tests/css/css-transforms/transform-origin/svg-origin-relative-length-036.html [ ImageOnlyFailure ]
-webkit.org/b/230080 imported/w3c/web-platform-tests/css/css-transforms/transform-origin/svg-origin-relative-length-037.html [ ImageOnlyFailure ]
-webkit.org/b/230080 imported/w3c/web-platform-tests/css/css-transforms/transform-origin/svg-origin-relative-length-038.html [ ImageOnlyFailure ]
-webkit.org/b/230080 imported/w3c/web-platform-tests/css/css-transforms/transform-origin/svg-origin-relative-length-039.html [ ImageOnlyFailure ]
-webkit.org/b/230080 imported/w3c/web-platform-tests/css/css-transforms/transform-origin/svg-origin-relative-length-040.html [ ImageOnlyFailure ]
-webkit.org/b/230080 imported/w3c/web-platform-tests/css/css-transforms/transform-origin/svg-origin-relative-length-041.html [ ImageOnlyFailure ]
-webkit.org/b/230080 imported/w3c/web-platform-tests/css/css-transforms/transform-origin/svg-origin-relative-length-042.html [ ImageOnlyFailure ]
-webkit.org/b/230080 imported/w3c/web-platform-tests/css/css-transforms/transform-origin/svg-origin-relative-length-043.html [ ImageOnlyFailure ]
-webkit.org/b/230080 imported/w3c/web-platform-tests/css/css-transforms/transform-origin/svg-origin-relative-length-044.html [ ImageOnlyFailure ]
-webkit.org/b/230080 imported/w3c/web-platform-tests/css/css-transforms/transform-origin/svg-origin-relative-length-045.html [ ImageOnlyFailure ]
-webkit.org/b/230080 imported/w3c/web-platform-tests/css/css-transforms/transform-origin/svg-origin-relative-length-046.html [ ImageOnlyFailure ]
 webkit.org/b/230080 imported/w3c/web-platform-tests/css/css-transforms/transform-percent-008.html [ ImageOnlyFailure ]
 webkit.org/b/230080 imported/w3c/web-platform-tests/css/css-transforms/transform-percent-010.html [ ImageOnlyFailure ]

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2021-12-13  Martin Robinson  <mrobinson@webkit.org>
+
+        `transform-origin` on SVG elements does not take into account the transform reference box origin
+        https://bugs.webkit.org/show_bug.cgi?id=234078
+
+        Reviewed by Rob Buis.
+
+        No new tests. This is covered by existing WPT tests.
+
+        * svg/SVGGraphicsElement.cpp:
+        (WebCore::SVGGraphicsElement::animatedLocalTransform const): Add the reference box origin
+        to the calculated reference box offset when calculating the transform origin for SVG.
+
 2021-12-13  Youenn Fablet  <youenn@apple.com>
 

trunk/Source/WebCore/svg/SVGGraphicsElement.cpp

@@ -102 +102 @@
     if (!hasSpecifiedTransform && style) {
         auto boundingBox = SVGRenderSupport::transformReferenceBox(*renderer(), *this, *style);
-        auto t = floatPointForLengthPoint(style->transformOriginXY(), boundingBox.size());
+        auto t = floatPointForLengthPoint(style->transformOriginXY(), boundingBox.size()) + boundingBox.location();
         matrix.translate(t);
         matrix *= transform().concatenate();