Changeset 287509 in webkit


Ignore:
Timestamp:
Jan 1, 2022 11:22:11 PM (7 months ago)
Author:
graouts@webkit.org
Message:

"animation" shorthand does not parse values in the right order
​https://bugs.webkit.org/show_bug.cgi?id=234788

Reviewed by Dean Jackson.

LayoutTests/imported/w3c:

Mark a new WPT progression.

  • web-platform-tests/css/css-animations/parsing/animation-valid-expected.txt:

Source/WebCore:

The animation-name should be parsed last, not first.

  • css/CSSProperties.json:

LayoutTests:

Update the order in which animation-name is serialized in the "animation" shorthand
for some non-WPT tests.

  • fast/css/longhand-overrides-shorthand-prefixing-expected.txt:
  • fast/css/longhand-overrides-shorthand-prefixing.html:
  • fast/css/transform-inline-style-remove-expected.txt:
Location:
trunk
Files:
8 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r287508 r287509  
     12022-01-01  Antoine Quint  <graouts@webkit.org>
     2
     3        "animation" shorthand does not parse values in the right order
     4        https://bugs.webkit.org/show_bug.cgi?id=234788
     5
     6        Reviewed by Dean Jackson.
     7
     8        Update the order in which animation-name is serialized in the "animation" shorthand
     9        for some non-WPT tests.
     10
     11        * fast/css/longhand-overrides-shorthand-prefixing-expected.txt:
     12        * fast/css/longhand-overrides-shorthand-prefixing.html:
     13        * fast/css/transform-inline-style-remove-expected.txt:
     14
    1152022-01-01  Diego Pino Garcia  <dpino@igalia.com>
    216

  • trunk/LayoutTests/fast/css/longhand-overrides-shorthand-prefixing-expected.txt

    r205809 r287509  
    44
    55
    6 Setting "animation" to "move 2s" then "animation-duration" to "10s" accessing "animation"
     6Setting "animation" to "2s move" then "animation-duration" to "10s" accessing "animation"
    77PASS element.style.animation
    88PASS element.style.cssText
    99
    10 Setting "animation" to "move 2s" then "animation-duration" to "10s" accessing "webkitAnimation"
     10Setting "animation" to "2s move" then "animation-duration" to "10s" accessing "webkitAnimation"
    1111PASS element.style.animation
    1212PASS element.style.cssText
    1313
    14 Setting "-webkit-animation" to "move 2s" then "animation-duration" to "10s" accessing "animation"
     14Setting "-webkit-animation" to "2s move" then "animation-duration" to "10s" accessing "animation"
    1515PASS element.style.webkitAnimation
    1616PASS element.style.cssText
    1717
    18 Setting "-webkit-animation" to "move 2s" then "animation-duration" to "10s" accessing "webkitAnimation"
     18Setting "-webkit-animation" to "2s move" then "animation-duration" to "10s" accessing "webkitAnimation"
    1919PASS element.style.webkitAnimation
    2020PASS element.style.cssText
    2121
    22 Setting "animation" to "move 2s" then "-webkit-animation-duration" to "10s" accessing "animation"
     22Setting "animation" to "2s move" then "-webkit-animation-duration" to "10s" accessing "animation"
    2323PASS element.style.animation
    2424PASS element.style.cssText
    2525
    26 Setting "animation" to "move 2s" then "-webkit-animation-duration" to "10s" accessing "webkitAnimation"
     26Setting "animation" to "2s move" then "-webkit-animation-duration" to "10s" accessing "webkitAnimation"
    2727PASS element.style.animation
    2828PASS element.style.cssText
    2929
    30 Setting "-webkit-animation" to "move 2s" then "-webkit-animation-duration" to "10s" accessing "animation"
     30Setting "-webkit-animation" to "2s move" then "-webkit-animation-duration" to "10s" accessing "animation"
    3131PASS element.style.webkitAnimation
    3232PASS element.style.cssText
    3333
    34 Setting "-webkit-animation" to "move 2s" then "-webkit-animation-duration" to "10s" accessing "webkitAnimation"
     34Setting "-webkit-animation" to "2s move" then "-webkit-animation-duration" to "10s" accessing "webkitAnimation"
    3535PASS element.style.webkitAnimation
    3636PASS element.style.cssText

  • trunk/LayoutTests/fast/css/longhand-overrides-shorthand-prefixing.html

    r205809 r287509  
    6464}
    6565
    66 testPropertyVariants("animation", "animation-duration", "move 2s", "move 10s", "10s");
     66testPropertyVariants("animation", "animation-duration", "2s move", "10s move", "10s");
    6767
    6868successfullyParsed = true;

  • trunk/LayoutTests/fast/css/transform-inline-style-remove-expected.txt

    r267644 r287509  
    2020transform origin Y (after):
    2121
    22 animation (before): test 5s ease-in-out infinite alternate
     22animation (before): 5s ease-in-out infinite alternate test
    2323animation name (before): test
    2424animation duration (before): 5s

  • trunk/LayoutTests/imported/w3c/ChangeLog

    r287499 r287509  
     12022-01-01  Antoine Quint  <graouts@webkit.org>
     2
     3        "animation" shorthand does not parse values in the right order
     4        https://bugs.webkit.org/show_bug.cgi?id=234788
     5
     6        Reviewed by Dean Jackson.
     7
     8        Mark a new WPT progression.
     9
     10        * web-platform-tests/css/css-animations/parsing/animation-valid-expected.txt:
     11
    1122021-12-31  Tim Nguyen  <ntim@apple.com>
    213

  • trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-animations/parsing/animation-valid-expected.txt

    r267650 r287509  
    99PASS e.style['animation'] = "none" should set the property value
    1010PASS e.style['animation'] = "anim" should set the property value
    11 FAIL e.style['animation'] = "anim paused both reverse 4 1s -3s cubic-bezier(0, -2, 1, 3)" should set the property value assert_equals: serialization should be canonical expected "1s cubic-bezier(0, -2, 1, 3) -3s 4 reverse both paused anim" but got "anim 1s cubic-bezier(0, -2, 1, 3) -3s 4 reverse both paused"
    12 FAIL e.style['animation'] = "anim paused both reverse, 4 1s -3s cubic-bezier(0, -2, 1, 3)" should set the property value assert_equals: serialization should be canonical expected "0s ease 0s 1 reverse both paused anim, 1s cubic-bezier(0, -2, 1, 3) -3s 4 normal none running none" but got "anim reverse both paused, 1s cubic-bezier(0, -2, 1, 3) -3s 4"
     11PASS e.style['animation'] = "anim paused both reverse 4 1s -3s cubic-bezier(0, -2, 1, 3)" should set the property value
     12FAIL e.style['animation'] = "anim paused both reverse, 4 1s -3s cubic-bezier(0, -2, 1, 3)" should set the property value assert_equals: serialization should be canonical expected "0s ease 0s 1 reverse both paused anim, 1s cubic-bezier(0, -2, 1, 3) -3s 4 normal none running none" but got "reverse both paused anim, 1s cubic-bezier(0, -2, 1, 3) -3s 4"
    1313

  • trunk/Source/WebCore/ChangeLog

    r287507 r287509  
     12022-01-01  Antoine Quint  <graouts@webkit.org>
     2
     3        "animation" shorthand does not parse values in the right order
     4        https://bugs.webkit.org/show_bug.cgi?id=234788
     5
     6        Reviewed by Dean Jackson.
     7
     8        The animation-name should be parsed last, not first.
     9
     10        * css/CSSProperties.json:
     11
    1122022-01-01  Jean-Yves Avenard  <jya@apple.com>
    213

  • trunk/Source/WebCore/css/CSSProperties.json

    r287487 r287509  
    900900                ],
    901901                "longhands": [
    902                     "animation-name",
    903902                    "animation-duration",
    904903                    "animation-timing-function",
    … …  
    907906                    "animation-direction",
    908907                    "animation-fill-mode",
    909                     "animation-play-state"
     908                    "animation-play-state",
     909                    "animation-name"
    910910                ]
    911911            },
Note: See TracChangeset for help on using the changeset viewer.