Changeset 287549 in webkit


Ignore:
Timestamp:
Jan 3, 2022 10:45:11 AM (7 months ago)
Author:
graouts@webkit.org
Message:

[Web Animations] calling setKeyframes() on a running CSS Transition has no immediate effect
​https://bugs.webkit.org/show_bug.cgi?id=234818

Reviewed by Dean Jackson.

LayoutTests/imported/w3c:

Mark WPT progressions.

  • web-platform-tests/css/css-animations/animation-base-response-004-expected.txt:
  • web-platform-tests/css/css-cascade/revert-val-010-expected.txt:
  • web-platform-tests/css/css-transitions/KeyframeEffect-setKeyframes.tentative-expected.txt:
  • web-platform-tests/web-animations/animation-model/keyframe-effects/effect-value-context-filling-expected.txt:
  • web-platform-tests/web-animations/interfaces/KeyframeEffect/setKeyframes-expected.txt:

Source/WebCore:

We must mark the target as dirty if setKeyframes() is called.

  • animation/KeyframeEffect.cpp:

(WebCore::KeyframeEffect::processKeyframes):

Location:
trunk
Files:
8 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/imported/w3c/ChangeLog

    r287548 r287549  
     12022-01-03  Antoine Quint  <graouts@webkit.org>
     2
     3        [Web Animations] calling setKeyframes() on a running CSS Transition has no immediate effect
     4        https://bugs.webkit.org/show_bug.cgi?id=234818
     5
     6        Reviewed by Dean Jackson.
     7
     8        Mark WPT progressions.
     9
     10        * web-platform-tests/css/css-animations/animation-base-response-004-expected.txt:
     11        * web-platform-tests/css/css-cascade/revert-val-010-expected.txt:
     12        * web-platform-tests/css/css-transitions/KeyframeEffect-setKeyframes.tentative-expected.txt:
     13        * web-platform-tests/web-animations/animation-model/keyframe-effects/effect-value-context-filling-expected.txt:
     14        * web-platform-tests/web-animations/interfaces/KeyframeEffect/setKeyframes-expected.txt:
     15
    1162022-01-03  Antoine Quint  <graouts@webkit.org>
    217

  • trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-animations/animation-base-response-004-expected.txt

    r260662 r287549  
    11
    2 FAIL Base is responsive to font-affecting appearing via setKeyframes assert_equals: expected "15px" but got "75px"
     2FAIL Base is responsive to font-affecting appearing via setKeyframes assert_equals: expected "15px" but got "10px"
    33

  • trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/revert-val-010-expected.txt

    r264522 r287549  
    11
    2 FAIL The revert works when appearing in setKeyframes assert_equals: expected 42 but got 126
     2FAIL The revert works when appearing in setKeyframes assert_equals: expected 42 but got 31
    33

  • trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-transitions/KeyframeEffect-setKeyframes.tentative-expected.txt

    r287548 r287549  
    11
    2 FAIL Keyframes set using setKeyframes() are reflected in computed style for a running transition assert_equals: expected "200px" but got "0px"
     2PASS Keyframes set using setKeyframes() are reflected in computed style for a running transition
    33PASS A transition with replaced keyframes still returns the original transitionProperty
    44PASS A transition with no keyframes still returns the original transitionProperty

  • trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/keyframe-effects/effect-value-context-filling-expected.txt

    r285397 r287549  
    44FAIL Filling effect values reflect changes to variables on element assert_equals: Effect value after updating variable expected "200px" but got "100px"
    55FAIL Filling effect values reflect changes to variables on parent element assert_equals: Effect value after updating variable expected "400px" but got "200px"
    6 FAIL Filling effect values reflect changes to the the animation's keyframes assert_equals: Effect value after updating the animation expected "300px" but got "200px"
     6PASS Filling effect values reflect changes to the the animation's keyframes
    77FAIL Filling effect values reflect changes to the the animation's composite mode assert_equals: Effect value after updating the composite mode expected "300px" but got "200px"
    88FAIL Filling effect values reflect changes to the the animation's iteration composite mode assert_equals: Effect value after updating the iteration composite mode expected "200px" but got "100px"
    … …  
    1313PASS Filling effect values reflect changes to underlying animations
    1414FAIL Filling effect values reflect changes to underlying animations via a a parent element assert_equals: Effect value after updating parent font-size expected "400px" but got "300px"
    15 FAIL Filling effect values reflect changes to underlying animations made by directly changing the keyframes assert_equals: Effect value after updating underlying animation expected "300px" but got "200px"
     15PASS Filling effect values reflect changes to underlying animations made by directly changing the keyframes
    1616

  • trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/interfaces/KeyframeEffect/setKeyframes-expected.txt

    r267649 r287549  
    7878PASS KeyframeEffect constructor throws with property-indexed keyframes with an invalid composite value as one of the array values
    7979PASS KeyframeEffect constructor throws with keyframes with an invalid composite value
    80 FAIL Changes made via setKeyframes should be immediately visible in style assert_equals: expected "250px" but got "150px"
     80PASS Changes made via setKeyframes should be immediately visible in style
    8181

  • trunk/Source/WebCore/ChangeLog

    r287548 r287549  
     12022-01-03  Antoine Quint  <graouts@webkit.org>
     2
     3        [Web Animations] calling setKeyframes() on a running CSS Transition has no immediate effect
     4        https://bugs.webkit.org/show_bug.cgi?id=234818
     5
     6        Reviewed by Dean Jackson.
     7
     8        We must mark the target as dirty if setKeyframes() is called.
     9
     10        * animation/KeyframeEffect.cpp:
     11        (WebCore::KeyframeEffect::processKeyframes):
     12
    1132022-01-03  Antoine Quint  <graouts@webkit.org>
    214

  • trunk/Source/WebCore/animation/KeyframeEffect.cpp

    r287524 r287549  
    856856    clearBlendingKeyframes();
    857857
     858    invalidate();
     859
    858860    return { };
    859861}
Note: See TracChangeset for help on using the changeset viewer.