Changeset 287674 in webkit

Timestamp:

Jan 5, 2022 9:51:41 PM (7 months ago)

Author:

Alan Bujtas

Message:

Text-decoration color not changing back after input blur with outline removed
​https://bugs.webkit.org/show_bug.cgi?id=234800
<rdar://problem/87145636>

Reviewed by Antti Koivisto.

Source/WebCore:

This patch fixes the case when a decoration type of style value changes on the input
element (e.g. text-decoration-color) and the inner renderer does not get notified through the usual styleDidChange
flow because the property is non-inherited.

Test: fast/forms/dynamic-text-decoration-change.html

• rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::styleDidChange):

LayoutTests:

• fast/forms/dynamic-text-decoration-change-expected.html: Added.
• fast/forms/dynamic-text-decoration-change.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/forms/dynamic-text-decoration-change-expected.txt (added)
• LayoutTests/fast/forms/dynamic-text-decoration-change.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/rendering/RenderTextControl.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2022-01-05  Alan Bujtas  <zalan@apple.com>
+
+        Text-decoration color not changing back after input blur with outline removed
+        https://bugs.webkit.org/show_bug.cgi?id=234800
+        <rdar://problem/87145636>
+
+        Reviewed by Antti Koivisto.
+
+        * fast/forms/dynamic-text-decoration-change-expected.html: Added.
+        * fast/forms/dynamic-text-decoration-change.html: Added.
+
 2021-10-30  Myles C. Maxfield  <mmaxfield@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2022-01-05  Alan Bujtas  <zalan@apple.com>
+
+        Text-decoration color not changing back after input blur with outline removed
+        https://bugs.webkit.org/show_bug.cgi?id=234800
+        <rdar://problem/87145636>
+
+        Reviewed by Antti Koivisto.
+
+        This patch fixes the case when a decoration type of style value changes on the input
+        element (e.g. text-decoration-color) and the inner renderer does not get notified through the usual styleDidChange
+        flow because the property is non-inherited.
+
+        Test: fast/forms/dynamic-text-decoration-change.html
+
+        * rendering/RenderTextControl.cpp:
+        (WebCore::RenderTextControl::styleDidChange):
+
 2022-01-05  Wenson Hsieh  <wenson_hsieh@apple.com>
 

trunk/Source/WebCore/rendering/RenderTextControl.cpp

@@ -72 +72 @@
         if (newInnerTextStyle != oldInnerTextStyle)
             innerTextRenderer->setStyle(WTFMove(newInnerTextStyle));
+        else if (diff == StyleDifference::RepaintIfTextOrBorderOrOutline || diff == StyleDifference::Repaint) {
+            // Repaint is expected to be propagated down to the shadow tree when non-inherited style property changes
+            // (e.g. text-decoration-color) since that's where the value actually takes effect.
+            innerTextRenderer->repaint();
+        }
     }
     textFormControlElement().updatePlaceholderVisibility();