Changeset 287712 in webkit


Ignore:
Timestamp:
Jan 6, 2022 12:21:02 PM (6 months ago)
Author:
ntim@apple.com
Message:

Unprefix -webkit-print-color-adjust CSS property
​https://bugs.webkit.org/show_bug.cgi?id=201098

Reviewed by Darin Adler.

color-adjust is also a deprecated shorthand that just contains print-color-adjust.

LayoutTests/imported/w3c:

  • web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:

Source/WebCore:

  • animation/CSSPropertyAnimation.cpp:

(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::valueForPropertyInStyle):

  • css/CSSProperties.json:
  • css/parser/CSSParserFastPaths.cpp:

(WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue):
(WebCore::CSSParserFastPaths::isKeywordPropertyID):

Source/WebInspectorUI:

  • UserInterface/Models/CSSKeywordCompletions.js:

LayoutTests:

  • fast/css/getComputedStyle/computed-style-expected.txt:
  • fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • fast/css/getComputedStyle/resources/property-names.js:
  • fast/css/print-color-adjust-expected.txt: Added.
  • fast/css/print-color-adjust.html: Added.
  • fast/css/webkit-color-adjust-expected.txt: Removed.
  • fast/css/webkit-color-adjust.html: Removed.
  • platform/glib/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/glib/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/glib/svg/css/getComputedStyle-basic-expected.txt:
  • platform/ios/fast/css/getComputedStyle/computed-style-expected.txt:
  • platform/ios/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • platform/ios/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
  • platform/ios/svg/css/getComputedStyle-basic-expected.txt:
  • svg/css/getComputedStyle-basic-expected.txt:
  • webgl/webgl-oom-paint-document-no-crash.html:
Location:
trunk
Files:
2 added
2 deleted
22 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r287711 r287712  
     12022-01-06  Tim Nguyen  <ntim@apple.com>
     2
     3        Unprefix -webkit-print-color-adjust CSS property
     4        https://bugs.webkit.org/show_bug.cgi?id=201098
     5
     6        Reviewed by Darin Adler.
     7
     8        color-adjust is also a deprecated shorthand that just contains print-color-adjust.
     9
     10        * fast/css/getComputedStyle/computed-style-expected.txt:
     11        * fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
     12        * fast/css/getComputedStyle/resources/property-names.js:
     13        * fast/css/print-color-adjust-expected.txt: Added.
     14        * fast/css/print-color-adjust.html: Added.
     15        * fast/css/webkit-color-adjust-expected.txt: Removed.
     16        * fast/css/webkit-color-adjust.html: Removed.
     17        * platform/glib/fast/css/getComputedStyle/computed-style-expected.txt:
     18        * platform/glib/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
     19        * platform/glib/svg/css/getComputedStyle-basic-expected.txt:
     20        * platform/ios/fast/css/getComputedStyle/computed-style-expected.txt:
     21        * platform/ios/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
     22        * platform/ios/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
     23        * platform/ios/svg/css/getComputedStyle-basic-expected.txt:
     24        * svg/css/getComputedStyle-basic-expected.txt:
     25        * webgl/webgl-oom-paint-document-no-crash.html:
     26
    1272022-01-06  Youenn Fablet  <youenn@apple.com>
    228

  • trunk/LayoutTests/fast/css/getComputedStyle/computed-style-expected.txt

    r287487 r287712  
    152152pointer-events: auto;
    153153position: static;
     154print-color-adjust: economy;
    154155resize: none;
    155156right: auto;
    … …  
    245246-webkit-mask-composite: source-over;
    246247-webkit-nbsp-mode: normal;
    247 -webkit-print-color-adjust: economy;
    248248-webkit-rtl-ordering: logical;
    249249-webkit-text-fill-color: rgb(0, 0, 0);

  • trunk/LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt

    r287487 r287712  
    151151pointer-events: auto
    152152position: static
     153print-color-adjust: economy
    153154resize: none
    154155right: auto
    … …  
    244245-webkit-mask-composite: source-over
    245246-webkit-nbsp-mode: normal
    246 -webkit-print-color-adjust: economy
    247247-webkit-rtl-ordering: logical
    248248-webkit-text-fill-color: rgb(0, 0, 0)

  • trunk/LayoutTests/fast/css/getComputedStyle/resources/property-names.js

    r287487 r287712  
    9696    "perspective": true,
    9797    "perspective-origin": true,
    98     "-webkit-print-color-adjust": true,
     98    "print-color-adjust": true,
    9999    "-webkit-rtl-ordering": true,
    100100    "text-combine-upright": true,

  • trunk/LayoutTests/imported/w3c/ChangeLog

    r287707 r287712  
     12022-01-06  Tim Nguyen  <ntim@apple.com>
     2
     3        Unprefix -webkit-print-color-adjust CSS property
     4        https://bugs.webkit.org/show_bug.cgi?id=201098
     5
     6        Reviewed by Darin Adler.
     7
     8        color-adjust is also a deprecated shorthand that just contains print-color-adjust.
     9
     10        * web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt:
     11
    1122022-01-06  Antoine Quint  <graouts@webkit.org>
    213

  • trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt

    r287487 r287712  
    236236PASS pointer-events
    237237PASS position
     238PASS print-color-adjust
    238239PASS quotes
    239240PASS r
    … …  
    383384PASS -webkit-mask-source-type
    384385PASS -webkit-nbsp-mode
    385 PASS -webkit-print-color-adjust
    386386PASS -webkit-rtl-ordering
    387387PASS -webkit-ruby-position

  • trunk/LayoutTests/platform/glib/fast/css/getComputedStyle/computed-style-expected.txt

    r287487 r287712  
    152152pointer-events: auto;
    153153position: static;
     154print-color-adjust: economy;
    154155resize: none;
    155156right: auto;
    … …  
    245246-webkit-mask-composite: source-over;
    246247-webkit-nbsp-mode: normal;
    247 -webkit-print-color-adjust: economy;
    248248-webkit-rtl-ordering: logical;
    249249-webkit-text-fill-color: rgb(0, 0, 0);

  • trunk/LayoutTests/platform/glib/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt

    r287487 r287712  
    151151pointer-events: auto
    152152position: static
     153print-color-adjust: economy
    153154resize: none
    154155right: auto
    … …  
    244245-webkit-mask-composite: source-over
    245246-webkit-nbsp-mode: normal
    246 -webkit-print-color-adjust: economy
    247247-webkit-rtl-ordering: logical
    248248-webkit-text-fill-color: rgb(0, 0, 0)

  • trunk/LayoutTests/platform/glib/svg/css/getComputedStyle-basic-expected.txt

    r287487 r287712  
    301301rect: style.getPropertyValue(position) : static
    302302rect: style.getPropertyCSSValue(position) : [object CSSPrimitiveValue]
     303rect: style.getPropertyValue(print-color-adjust) : economy
     304rect: style.getPropertyCSSValue(print-color-adjust) : [object CSSPrimitiveValue]
    303305rect: style.getPropertyValue(resize) : none
    304306rect: style.getPropertyCSSValue(resize) : [object CSSPrimitiveValue]
    … …  
    487489rect: style.getPropertyValue(-webkit-nbsp-mode) : normal
    488490rect: style.getPropertyCSSValue(-webkit-nbsp-mode) : [object CSSPrimitiveValue]
    489 rect: style.getPropertyValue(-webkit-print-color-adjust) : economy
    490 rect: style.getPropertyCSSValue(-webkit-print-color-adjust) : [object CSSPrimitiveValue]
    491491rect: style.getPropertyValue(-webkit-rtl-ordering) : logical
    492492rect: style.getPropertyCSSValue(-webkit-rtl-ordering) : [object CSSPrimitiveValue]
    … …  
    811811g: style.getPropertyValue(position) : static
    812812g: style.getPropertyCSSValue(position) : [object CSSPrimitiveValue]
     813g: style.getPropertyValue(print-color-adjust) : economy
     814g: style.getPropertyCSSValue(print-color-adjust) : [object CSSPrimitiveValue]
    813815g: style.getPropertyValue(resize) : none
    814816g: style.getPropertyCSSValue(resize) : [object CSSPrimitiveValue]
    … …  
    997999g: style.getPropertyValue(-webkit-nbsp-mode) : normal
    9981000g: style.getPropertyCSSValue(-webkit-nbsp-mode) : [object CSSPrimitiveValue]
    999 g: style.getPropertyValue(-webkit-print-color-adjust) : economy
    1000 g: style.getPropertyCSSValue(-webkit-print-color-adjust) : [object CSSPrimitiveValue]
    10011001g: style.getPropertyValue(-webkit-rtl-ordering) : logical
    10021002g: style.getPropertyCSSValue(-webkit-rtl-ordering) : [object CSSPrimitiveValue]

  • trunk/LayoutTests/platform/ios/fast/css/getComputedStyle/computed-style-expected.txt

    r287487 r287712  
    152152pointer-events: auto;
    153153position: static;
     154print-color-adjust: economy;
    154155resize: none;
    155156right: auto;
    … …  
    245246-webkit-mask-composite: source-over;
    246247-webkit-nbsp-mode: normal;
    247 -webkit-print-color-adjust: economy;
    248248-webkit-rtl-ordering: logical;
    249249-webkit-text-fill-color: rgb(0, 0, 0);

  • trunk/LayoutTests/platform/ios/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt

    r287487 r287712  
    151151pointer-events: auto
    152152position: static
     153print-color-adjust: economy
    153154resize: none
    154155right: auto
    … …  
    244245-webkit-mask-composite: source-over
    245246-webkit-nbsp-mode: normal
    246 -webkit-print-color-adjust: economy
    247247-webkit-rtl-ordering: logical
    248248-webkit-text-fill-color: rgb(0, 0, 0)

  • trunk/LayoutTests/platform/ios/imported/w3c/web-platform-tests/css/css-cascade/all-prop-initial-xml-expected.txt

    r287487 r287712  
    215215PASS pointer-events
    216216PASS position
     217PASS print-color-adjust
    217218PASS quotes
    218219PASS r
    … …  
    360361PASS -webkit-nbsp-mode
    361362PASS -webkit-overflow-scrolling
    362 PASS -webkit-print-color-adjust
    363363PASS -webkit-rtl-ordering
    364364PASS -webkit-ruby-position

  • trunk/LayoutTests/platform/ios/svg/css/getComputedStyle-basic-expected.txt

    r287487 r287712  
    301301rect: style.getPropertyValue(position) : static
    302302rect: style.getPropertyCSSValue(position) : [object CSSPrimitiveValue]
     303rect: style.getPropertyValue(print-color-adjust) : economy
     304rect: style.getPropertyCSSValue(print-color-adjust) : [object CSSPrimitiveValue]
    303305rect: style.getPropertyValue(resize) : none
    304306rect: style.getPropertyCSSValue(resize) : [object CSSPrimitiveValue]
    … …  
    487489rect: style.getPropertyValue(-webkit-nbsp-mode) : normal
    488490rect: style.getPropertyCSSValue(-webkit-nbsp-mode) : [object CSSPrimitiveValue]
    489 rect: style.getPropertyValue(-webkit-print-color-adjust) : economy
    490 rect: style.getPropertyCSSValue(-webkit-print-color-adjust) : [object CSSPrimitiveValue]
    491491rect: style.getPropertyValue(-webkit-rtl-ordering) : logical
    492492rect: style.getPropertyCSSValue(-webkit-rtl-ordering) : [object CSSPrimitiveValue]
    … …  
    811811g: style.getPropertyValue(position) : static
    812812g: style.getPropertyCSSValue(position) : [object CSSPrimitiveValue]
     813g: style.getPropertyValue(print-color-adjust) : economy
     814g: style.getPropertyCSSValue(print-color-adjust) : [object CSSPrimitiveValue]
    813815g: style.getPropertyValue(resize) : none
    814816g: style.getPropertyCSSValue(resize) : [object CSSPrimitiveValue]
    … …  
    997999g: style.getPropertyValue(-webkit-nbsp-mode) : normal
    9981000g: style.getPropertyCSSValue(-webkit-nbsp-mode) : [object CSSPrimitiveValue]
    999 g: style.getPropertyValue(-webkit-print-color-adjust) : economy
    1000 g: style.getPropertyCSSValue(-webkit-print-color-adjust) : [object CSSPrimitiveValue]
    10011001g: style.getPropertyValue(-webkit-rtl-ordering) : logical
    10021002g: style.getPropertyCSSValue(-webkit-rtl-ordering) : [object CSSPrimitiveValue]

  • trunk/LayoutTests/svg/css/getComputedStyle-basic-expected.txt

    r287487 r287712  
    301301rect: style.getPropertyValue(position) : static
    302302rect: style.getPropertyCSSValue(position) : [object CSSPrimitiveValue]
     303rect: style.getPropertyValue(print-color-adjust) : economy
     304rect: style.getPropertyCSSValue(print-color-adjust) : [object CSSPrimitiveValue]
    303305rect: style.getPropertyValue(resize) : none
    304306rect: style.getPropertyCSSValue(resize) : [object CSSPrimitiveValue]
    … …  
    487489rect: style.getPropertyValue(-webkit-nbsp-mode) : normal
    488490rect: style.getPropertyCSSValue(-webkit-nbsp-mode) : [object CSSPrimitiveValue]
    489 rect: style.getPropertyValue(-webkit-print-color-adjust) : economy
    490 rect: style.getPropertyCSSValue(-webkit-print-color-adjust) : [object CSSPrimitiveValue]
    491491rect: style.getPropertyValue(-webkit-rtl-ordering) : logical
    492492rect: style.getPropertyCSSValue(-webkit-rtl-ordering) : [object CSSPrimitiveValue]
    … …  
    811811g: style.getPropertyValue(position) : static
    812812g: style.getPropertyCSSValue(position) : [object CSSPrimitiveValue]
     813g: style.getPropertyValue(print-color-adjust) : economy
     814g: style.getPropertyCSSValue(print-color-adjust) : [object CSSPrimitiveValue]
    813815g: style.getPropertyValue(resize) : none
    814816g: style.getPropertyCSSValue(resize) : [object CSSPrimitiveValue]
    … …  
    997999g: style.getPropertyValue(-webkit-nbsp-mode) : normal
    9981000g: style.getPropertyCSSValue(-webkit-nbsp-mode) : [object CSSPrimitiveValue]
    999 g: style.getPropertyValue(-webkit-print-color-adjust) : economy
    1000 g: style.getPropertyCSSValue(-webkit-print-color-adjust) : [object CSSPrimitiveValue]
    10011001g: style.getPropertyValue(-webkit-rtl-ordering) : logical
    10021002g: style.getPropertyCSSValue(-webkit-rtl-ordering) : [object CSSPrimitiveValue]

  • trunk/LayoutTests/webgl/webgl-oom-paint-document-no-crash.html

    r280601 r287712  
    1111To ensure expected behavior, e.g. to observe the failure, the canvas should not be visible.
    1212To assert this, use div with border as indicator. Background cannot be used as printing
    13 disables the backgrounds and -webkit-print-color-adjust: exact is not respected in
     13disables the backgrounds and print-color-adjust: exact is not respected in
    1414WTR printing mode.
    1515-->

  • trunk/Source/WebCore/ChangeLog

    r287711 r287712  
     12022-01-06  Tim Nguyen  <ntim@apple.com>
     2
     3        Unprefix -webkit-print-color-adjust CSS property
     4        https://bugs.webkit.org/show_bug.cgi?id=201098
     5
     6        Reviewed by Darin Adler.
     7
     8        color-adjust is also a deprecated shorthand that just contains print-color-adjust.
     9
     10        * animation/CSSPropertyAnimation.cpp:
     11        (WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
     12        * css/CSSComputedStyleDeclaration.cpp:
     13        (WebCore::ComputedStyleExtractor::valueForPropertyInStyle):
     14        * css/CSSProperties.json:
     15        * css/parser/CSSParserFastPaths.cpp:
     16        (WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue):
     17        (WebCore::CSSParserFastPaths::isKeywordPropertyID):
     18
    1192022-01-06  Youenn Fablet  <youenn@apple.com>
    220

  • trunk/Source/WebCore/animation/CSSPropertyAnimation.cpp

    r287356 r287712  
    27222722        new DiscretePropertyWrapper<CaptionSide>(CSSPropertyCaptionSide, &RenderStyle::captionSide, &RenderStyle::setCaptionSide),
    27232723        new DiscretePropertyWrapper<Clear>(CSSPropertyClear, &RenderStyle::clear, &RenderStyle::setClear),
    2724         new DiscretePropertyWrapper<PrintColorAdjust>(CSSPropertyWebkitPrintColorAdjust, &RenderStyle::printColorAdjust, &RenderStyle::setPrintColorAdjust),
     2724        new DiscretePropertyWrapper<PrintColorAdjust>(CSSPropertyPrintColorAdjust, &RenderStyle::printColorAdjust, &RenderStyle::setPrintColorAdjust),
    27252725        new DiscretePropertyWrapper<ColumnFill>(CSSPropertyColumnFill, &RenderStyle::columnFill, &RenderStyle::setColumnFill),
    27262726        new DiscretePropertyWrapper<BorderStyle>(CSSPropertyColumnRuleStyle, &RenderStyle::columnRuleStyle, &RenderStyle::setColumnRuleStyle),

  • trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp

    r287678 r287712  
    30003000        case CSSPropertyColor:
    30013001            return cssValuePool.createColorValue(m_allowVisitedStyle ? style.visitedDependentColor(CSSPropertyColor) : style.color());
    3002         case CSSPropertyWebkitPrintColorAdjust:
     3002        case CSSPropertyPrintColorAdjust:
    30033003            return cssValuePool.createValue(style.printColorAdjust());
    30043004        case CSSPropertyWebkitColumnAxis:

  • trunk/Source/WebCore/css/CSSProperties.json

    r287663 r287712  
    64946494                "high-priority": true
    64956495            },
     6496            "specification": {
     6497                "category": "css-color-adjust",
     6498                "url": "https://www.w3.org/TR/css-color-adjust/#color-scheme-prop"
     6499            },
    64966500            "status": {
    6497                 "status": "in development",
     6501                "status": "supported",
    64986502                "enabled-by-default": true
    64996503            }
    … …  
    65726576            }
    65736577        },
    6574         "-webkit-print-color-adjust": {
     6578        "print-color-adjust": {
     6579            "codegen-properties": {
     6580                "aliases": [
     6581                    "-webkit-print-color-adjust",
     6582                    "color-adjust"
     6583                ]
     6584            },
    65756585            "inherited": true,
    65766586            "values": [
    … …  
    65786588                "economy"
    65796589            ],
    6580             "status": "non-standard"
     6590            "specification": {
     6591                "category": "css-color-adjust",
     6592                "url": "https://www.w3.org/TR/css-color-adjust/#print-color-adjust"
     6593            }
    65816594        },
    65826595        "range": {
    … …  
    76747687            "shortname": "CSS Color",
    76757688            "longname": "CSS Color Module",
    7676             "url": "https://www.w3.org/TR/css3-color/"
     7689            "url": "https://www.w3.org/TR/css-color/"
     7690        },
     7691        "css-color-adjust": {
     7692            "shortname": "CSS Color Adjustment",
     7693            "longname": "CSS Color Adjustment Module",
     7694            "url": "https://www.w3.org/TR/css-color-adjust/"
    76777695        },
    76787696        "css-compositing": {

  • trunk/Source/WebCore/css/parser/CSSParserFastPaths.cpp

    r287487 r287712  
    803803    case CSSPropertyWebkitLineSnap:
    804804        return valueID == CSSValueNone || valueID == CSSValueBaseline || valueID == CSSValueContain;
    805     case CSSPropertyWebkitPrintColorAdjust:
     805    case CSSPropertyPrintColorAdjust:
    806806        return valueID == CSSValueExact || valueID == CSSValueEconomy;
    807807    case CSSPropertyWebkitRtlOrdering:
    … …  
    975975    case CSSPropertyWebkitMarqueeStyle:
    976976    case CSSPropertyWebkitNbspMode:
    977     case CSSPropertyWebkitPrintColorAdjust:
     977    case CSSPropertyPrintColorAdjust:
    978978    case CSSPropertyWebkitRtlOrdering:
    979979    case CSSPropertyWebkitRubyPosition:

  • trunk/Source/WebInspectorUI/ChangeLog

    r287698 r287712  
     12022-01-06  Tim Nguyen  <ntim@apple.com>
     2
     3        Unprefix -webkit-print-color-adjust CSS property
     4        https://bugs.webkit.org/show_bug.cgi?id=201098
     5
     6        Reviewed by Darin Adler.
     7
     8        color-adjust is also a deprecated shorthand that just contains print-color-adjust.
     9
     10        * UserInterface/Models/CSSKeywordCompletions.js:
     11
    1122022-01-06  Alex Christensen  <achristensen@webkit.org>
    213

  • trunk/Source/WebInspectorUI/UserInterface/Models/CSSKeywordCompletions.js

    r287636 r287712  
    304304    "-webkit-nbsp-mode",
    305305    "-webkit-overflow-scrolling",
    306     "-webkit-print-color-adjust",
    307306    "-webkit-rtl-ordering",
    308307    "-webkit-ruby-position",
    … …  
    380379    "orphans",
    381380    "pointer-events",
     381    "print-color-adjust",
    382382    "quotes",
    383383    "resize",
    … …  
    11121112        "auto", "touch",
    11131113    ],
    1114     "-webkit-print-color-adjust": [
     1114    "print-color-adjust": [
    11151115        "economy", "exact",
    11161116    ],
Note: See TracChangeset for help on using the changeset viewer.