Changeset 287764 in webkit

Timestamp:

Jan 7, 2022 10:56:47 AM (6 months ago)

Author:

graouts@webkit.org

Message:

Transitions without an explicit property-name should not be considered
​https://bugs.webkit.org/show_bug.cgi?id=234960

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Mark WPT progression.

• web-platform-tests/css/css-transitions/events-004-expected.txt:

Source/WebCore:

When we fill the transition-property to match the number of another transition-
property, we should not consider running a transition for that property.

• style/Styleable.cpp:

(WebCore::transitionMatchesProperty):

Location:

trunk

Files:

• LayoutTests/imported/w3c/ChangeLog (modified) (1 diff)
• LayoutTests/imported/w3c/web-platform-tests/css/css-transitions/events-004-expected.txt (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/style/Styleable.cpp (modified) (1 diff)

trunk/LayoutTests/imported/w3c/ChangeLog

@@ +1 @@
+2022-01-07  Antoine Quint  <graouts@webkit.org>
+
+        Transitions without an explicit property-name should not be considered
+        https://bugs.webkit.org/show_bug.cgi?id=234960
+
+        Reviewed by Darin Adler.
+
+        Mark WPT progression.
+
+        * web-platform-tests/css/css-transitions/events-004-expected.txt:
+
 2022-01-07  Youenn Fablet  <youenn@apple.com>
 

trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-transitions/events-004-expected.txt

@@ -1 +1 @@
 
 PASS repeating lists
-FAIL truncating lists assert_approx_equals: expected 0.02 +/- 0.0005 but got 0.01
+PASS truncating lists
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2022-01-07  Antoine Quint  <graouts@webkit.org>
+
+        Transitions without an explicit property-name should not be considered
+        https://bugs.webkit.org/show_bug.cgi?id=234960
+
+        Reviewed by Darin Adler.
+
+        When we fill the transition-property to match the number of another `transition-`
+        property, we should not consider running a transition for that property.
+
+        * style/Styleable.cpp:
+        (WebCore::transitionMatchesProperty):
+
 2022-01-07  Youenn Fablet  <youenn@apple.com>
 

trunk/Source/WebCore/style/Styleable.cpp

@@ -317 +317 @@
 static bool transitionMatchesProperty(const Animation& transition, CSSPropertyID property)
 {
+    if (transition.isPropertyFilled())
+        return false;
+
     auto mode = transition.property().mode;
     if (mode == Animation::TransitionMode::None || mode == Animation::TransitionMode::UnknownProperty)