Changeset 287822 in webkit

Timestamp:

Jan 9, 2022 10:13:26 AM (6 months ago)

Author:

graouts@webkit.org

Message:

translate() function in transform property should remove trailing 0 value when parsing
​https://bugs.webkit.org/show_bug.cgi?id=235016

Reviewed by Antti Koivisto.

LayoutTests/imported/w3c:

Mark WPT progression.

• web-platform-tests/css/css-animations/KeyframeEffect-getKeyframes.tentative-expected.txt:

Source/WebCore:

• css/parser/CSSPropertyParser.cpp:

(WebCore::consumeTransformValue):

Location:

trunk

Files:

• LayoutTests/imported/w3c/ChangeLog (modified) (1 diff)
• LayoutTests/imported/w3c/web-platform-tests/css/css-animations/KeyframeEffect-getKeyframes.tentative-expected.txt (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/css/parser/CSSPropertyParser.cpp (modified) (1 diff)

trunk/LayoutTests/imported/w3c/ChangeLog

@@ +1 @@
+2022-01-09  Antoine Quint  <graouts@webkit.org>
+
+        translate() function in transform property should remove trailing 0 value when parsing
+        https://bugs.webkit.org/show_bug.cgi?id=235016
+
+        Reviewed by Antti Koivisto.
+
+        Mark WPT progression.
+
+        * web-platform-tests/css/css-animations/KeyframeEffect-getKeyframes.tentative-expected.txt:
+
 2022-01-08  Antoine Quint  <graouts@webkit.org>
 

trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-animations/KeyframeEffect-getKeyframes.tentative-expected.txt

@@ -23 +23 @@
 PASS KeyframeEffect.getKeyframes() returns expected values for animations with CSS variables as keyframe values in a shorthand property
 PASS KeyframeEffect.getKeyframes() returns expected values for animations with a CSS variable which is overriden by the value in keyframe
-FAIL KeyframeEffect.getKeyframes() returns expected values for animations with only custom property in a keyframe assert_equals: value for 'transform' on Keyframe #0 should match expected "translate(100px)" but got "translate(100px, 0px)"
+PASS KeyframeEffect.getKeyframes() returns expected values for animations with only custom property in a keyframe
 PASS KeyframeEffect.getKeyframes() reflects changes to @keyframes rules
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2022-01-09  Antoine Quint  <graouts@webkit.org>
+
+        translate() function in transform property should remove trailing 0 value when parsing
+        https://bugs.webkit.org/show_bug.cgi?id=235016
+
+        Reviewed by Antti Koivisto.
+
+        * css/parser/CSSPropertyParser.cpp:
+        (WebCore::consumeTransformValue):
+
 2022-01-09  Sam Weinig  <weinig@apple.com>
 

trunk/Source/WebCore/css/parser/CSSPropertyParser.cpp

@@ -1939 +1939 @@
             if (!parsedValue)
                 return nullptr;
+            if (is<CSSPrimitiveValue>(parsedValue)) {
+                auto isZero = downcast<CSSPrimitiveValue>(*parsedValue).isZero();
+                if (isZero && *isZero)
+                    parsedValue = nullptr;
+            }
         }
         break;