Changeset 288219 in webkit


Ignore:
Timestamp:
Jan 19, 2022 11:37:40 AM (6 months ago)
Author:
commit-queue@webkit.org
Message:

[ResourceTiming] nextHopProtocol is exposed regardless of Timing-Allow-Origin
​https://bugs.webkit.org/show_bug.cgi?id=235294

Patch by Alex Christensen <​achristensen@webkit.org> on 2022-01-19
Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

  • web-platform-tests/resource-timing/nextHopProtocol-is-tao-protected.https-expected.txt:

Source/WebCore:

Covered by an existing WPT test that starts passing.
This was recently fixed in Chromium in ​https://chromium-review.googlesource.com/c/chromium/src/+/3354335

  • page/PerformanceResourceTiming.cpp:

(WebCore::PerformanceResourceTiming::nextHopProtocol const):

Location:
trunk
Files:
1 deleted
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/imported/w3c/ChangeLog

    r288201 r288219  
     12022-01-19  Alex Christensen  <achristensen@webkit.org>
     2
     3        [ResourceTiming] nextHopProtocol is exposed regardless of Timing-Allow-Origin
     4        https://bugs.webkit.org/show_bug.cgi?id=235294
     5
     6        Reviewed by Chris Dumez.
     7
     8        * web-platform-tests/resource-timing/nextHopProtocol-is-tao-protected.https-expected.txt:
     9
    1102022-01-19  Youenn Fablet  <youenn@apple.com>
    211

  • trunk/LayoutTests/imported/w3c/web-platform-tests/resource-timing/nextHopProtocol-is-tao-protected.https-expected.txt

    r278738 r288219  
    11
    2 FAIL Add TAO-less iframe from remote origin. Make sure nextHopProtocol is the empty string assert_equals: nextHopProtocol should be the empty string expected "" but got "http/1.1"
     2PASS Add TAO-less iframe from remote origin. Make sure nextHopProtocol is the empty string
    33PASS Add TAO'd iframe from remote origin. Make sure nextHopProtocol is not the empty string
    44

  • trunk/LayoutTests/imported/w3c/web-platform-tests/resource-timing/nextHopProtocol-tao-protected.https-expected.txt

    r267647 r288219  
    11
    22
    3 FAIL Add TAO-less iframe to remote origin. Make sure nextHopProtocol is the empty string promise_test: Unhandled rejection with value: "nextHopProtocol should be the empty string"
     3PASS Add TAO-less iframe to remote origin. Make sure nextHopProtocol is the empty string
    44PASS Add TAO iframe to remote origin. Make sure nextHopProtocol is not the empty string
    55

  • trunk/Source/WebCore/ChangeLog

    r288217 r288219  
     12022-01-19  Alex Christensen  <achristensen@webkit.org>
     2
     3        [ResourceTiming] nextHopProtocol is exposed regardless of Timing-Allow-Origin
     4        https://bugs.webkit.org/show_bug.cgi?id=235294
     5
     6        Reviewed by Chris Dumez.
     7
     8        Covered by an existing WPT test that starts passing.
     9        This was recently fixed in Chromium in https://chromium-review.googlesource.com/c/chromium/src/+/3354335
     10
     11        * page/PerformanceResourceTiming.cpp:
     12        (WebCore::PerformanceResourceTiming::nextHopProtocol const):
     13
    1142022-01-19  Rob Buis  <rbuis@igalia.com>
    215

  • trunk/Source/WebCore/page/PerformanceResourceTiming.cpp

    r281860 r288219  
    100100const String& PerformanceResourceTiming::nextHopProtocol() const
    101101{
     102    if (m_resourceTiming.networkLoadMetrics().failsTAOCheck)
     103        return emptyString();
     104
    102105    return m_resourceTiming.networkLoadMetrics().protocol;
    103106}
Note: See TracChangeset for help on using the changeset viewer.