Changeset 288411 in webkit

Timestamp:

Jan 22, 2022 4:00:38 PM (6 months ago)

Author:

ysuzuki@apple.com

Message:

[JSC] Relax Date.parse requirement
​https://bugs.webkit.org/show_bug.cgi?id=235468

Reviewed by Darin Adler.

JSTests:

• stress/date-relaxed-separator.js: Added.

(shouldBe):

Source/WTF:

While the spec does not require accepting 't' / ' ' separator, ISO 8601 accepts it.
This is because ECMA262's Date format is *not* ISO 8601 (it is called simplification
of ISO 8601[1]).
This patch relaxes this strictness to accept more formats, which can be accepted in
the other engines too.

[1]: ​https://tc39.es/ecma262/#sec-date-time-string-format

• wtf/DateMath.cpp:

(WTF::parseES5DateFromNullTerminatedCharacters):

LayoutTests:

• js/date-parse-test-expected.txt:
• js/script-tests/date-parse-test.js:

Location:

trunk

Files:

• JSTests/ChangeLog (modified) (1 diff)
• JSTests/stress/date-relaxed-separator.js (added)
• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/js/date-parse-test-expected.txt (modified) (1 diff)
• LayoutTests/js/script-tests/date-parse-test.js (modified) (1 diff)
• Source/WTF/ChangeLog (modified) (1 diff)
• Source/WTF/wtf/DateMath.cpp (modified) (1 diff)

trunk/JSTests/ChangeLog

@@ +1 @@
+2022-01-21  Yusuke Suzuki  <ysuzuki@apple.com>
+
+        [JSC] Relax Date.parse requirement
+        https://bugs.webkit.org/show_bug.cgi?id=235468
+
+        Reviewed by Darin Adler.
+
+        * stress/date-relaxed-separator.js: Added.
+        (shouldBe):
+
 2022-01-19  Yusuke Suzuki  <ysuzuki@apple.com>
 

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2022-01-21  Yusuke Suzuki  <ysuzuki@apple.com>
+
+        [JSC] Relax Date.parse requirement
+        https://bugs.webkit.org/show_bug.cgi?id=235468
+
+        Reviewed by Darin Adler.
+
+        * js/date-parse-test-expected.txt:
+        * js/script-tests/date-parse-test.js:
+
 2022-01-22  Alan Bujtas  <zalan@apple.com>
 

trunk/LayoutTests/js/date-parse-test-expected.txt

@@ -28 +28 @@
 PASS Date.parse("1995-12-25T01:30:00+00:00 ") is NaN
 PASS Date.parse("1995-02-29T00:00:00Z") is NaN
-PASS Date.parse("1995-12-25 01:30:00Z") is NaN
+PASS Date.parse("1995-12-25 01:30:00Z") == 819855000000 is true
 PASS Date.parse("1995-12-25T01:30:00z") is NaN
 PASS Number(Date.parse('1970')) is 0

trunk/LayoutTests/js/script-tests/date-parse-test.js

@@ -67 +67 @@
 testDateParseExact("1995-12-25T01:30:00+00:00 ", "NaN");
 testDateParseExact("1995-02-29T00:00:00Z", "NaN");
-testDateParseExact("1995-12-25 01:30:00Z", "NaN");
+testDateParseExact("1995-12-25 01:30:00Z", "819855000000");
 testDateParseExact("1995-12-25T01:30:00z", "NaN");
 

trunk/Source/WTF/ChangeLog

@@ +1 @@
+2022-01-21  Yusuke Suzuki  <ysuzuki@apple.com>
+
+        [JSC] Relax Date.parse requirement
+        https://bugs.webkit.org/show_bug.cgi?id=235468
+
+        Reviewed by Darin Adler.
+
+        While the spec does not require accepting 't' / ' ' separator, ISO 8601 accepts it.
+        This is because ECMA262's Date format is *not* ISO 8601 (it is called simplification
+        of ISO 8601[1]).
+        This patch relaxes this strictness to accept more formats, which can be accepted in
+        the other engines too.
+
+        [1]: https://tc39.es/ecma262/#sec-date-time-string-format
+
+        * wtf/DateMath.cpp:
+        (WTF::parseES5DateFromNullTerminatedCharacters):
+
 2022-01-21  Sihui Liu  <sihui_liu@apple.com>
 

trunk/Source/WTF/wtf/DateMath.cpp

@@ -646 +646 @@
     // Look for a time portion.
     // Note: As of ES2016, when a UTC offset is missing, date-time forms are local time while date-only forms are UTC.
-    if (*currentPosition == 'T') {
+    if (*currentPosition == 'T' || *currentPosition == 't' || *currentPosition == ' ') {
         // Parse the time HH:mm[:ss[.sss]][Z|(+|-)(00:00|0000|00)]
         currentPosition = parseES5TimePortion(currentPosition + 1, hours, minutes, seconds, milliseconds, isLocalTime, timeZoneSeconds);