Changeset 288580 in webkit

Timestamp:

Jan 25, 2022 1:36:01 PM (6 months ago)

Author:

Nikita Vasilyev

Message:

Web Inspector: Collapse blackboxed call frames by default
​https://bugs.webkit.org/show_bug.cgi?id=234581
<rdar://problem/86967088>

Reviewed by Devin Rousso.

Remove "Collapse blackboxed call frames" checkbox from the experimental settings
and enable the feature by default.

• Localizations/en.lproj/localizedStrings.js:
• UserInterface/Base/Setting.js:
• UserInterface/Controllers/CallFrameTreeController.js:

(WI.CallFrameTreeController.prototype.groupBlackboxedCallFrames):

• UserInterface/Controllers/DebuggerManager.js:

(WI.DebuggerManager.prototype.shouldAutoExpandBlackboxedCallFrameGroup):

• UserInterface/Views/SettingsTabContentView.js:

(WI.SettingsTabContentView.prototype._createExperimentalSettingsView):

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• Localizations/en.lproj/localizedStrings.js (modified) (2 diffs)
• UserInterface/Base/Setting.js (modified) (1 diff)
• UserInterface/Controllers/CallFrameTreeController.js (modified) (1 diff)
• UserInterface/Controllers/DebuggerManager.js (modified) (1 diff)
• UserInterface/Views/SettingsTabContentView.js (modified) (2 diffs)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2022-01-25  Nikita Vasilyev  <nvasilyev@apple.com>
+
+        Web Inspector: Collapse blackboxed call frames by default
+        https://bugs.webkit.org/show_bug.cgi?id=234581
+        <rdar://problem/86967088>
+
+        Reviewed by Devin Rousso.
+
+        Remove "Collapse blackboxed call frames" checkbox from the experimental settings
+        and enable the feature by default.
+
+        * Localizations/en.lproj/localizedStrings.js:
+        * UserInterface/Base/Setting.js:
+        * UserInterface/Controllers/CallFrameTreeController.js:
+        (WI.CallFrameTreeController.prototype.groupBlackboxedCallFrames):
+        * UserInterface/Controllers/DebuggerManager.js:
+        (WI.DebuggerManager.prototype.shouldAutoExpandBlackboxedCallFrameGroup):
+        * UserInterface/Views/SettingsTabContentView.js:
+        (WI.SettingsTabContentView.prototype._createExperimentalSettingsView):
+
 2022-01-25  Devin Rousso  <drousso@apple.com>
 

trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js

@@ -345 +345 @@
 localizedStrings["Code"] = "Code";
 localizedStrings["Collapse All"] = "Collapse All";
-/* Setting to collapse blackboxed call frames in the debugger. */
-localizedStrings["Collapse blackboxed call frames @ Experimental Settings"] = "Collapse blackboxed call frames";
 localizedStrings["Collapse columns"] = "Collapse columns";
 localizedStrings["Collect garbage"] = "Collect garbage";
@@ -446 +444 @@
 localizedStrings["Debugger disabled during Timeline recording"] = "Debugger disabled during Timeline recording";
 localizedStrings["Debugging:"] = "Debugging:";
-/* Category label for experimental settings related to debugging. */
-localizedStrings["Debugging: @ Experimental Settings"] = "Debugging:";
 localizedStrings["Debugs"] = "Debugs";
 localizedStrings["Decoded"] = "Decoded";

trunk/Source/WebInspectorUI/UserInterface/Base/Setting.js

@@ -230 +230 @@
     experimentalEnableStylesJumpToEffective: new WI.Setting("experimental-styles-jump-to-effective", false),
     experimentalEnableStylesJumpToVariableDeclaration: new WI.Setting("experimental-styles-jump-to-variable-declaration", false),
-    experimentalCollapseBlackboxedCallFrames: new WI.Setting("experimental-collapse-blackboxed-call-frames", false),
     experimentalAllowInspectingInspector: new WI.Setting("experimental-allow-inspecting-inspector", false),
     experimentalCSSCompletionFuzzyMatching: new WI.Setting("experimental-css-completion-fuzzy-matching", true),

trunk/Source/WebInspectorUI/UserInterface/Controllers/CallFrameTreeController.js

@@ -79 +79 @@
                     continue;
 
-                if (callFrame.blackboxed && WI.settings.experimentalCollapseBlackboxedCallFrames.value) {
+                if (callFrame.blackboxed) {
                     blackboxedCallFrameGroupStartIndex ??= i;
                     continue;

trunk/Source/WebInspectorUI/UserInterface/Controllers/DebuggerManager.js

@@ -541 +541 @@
     shouldAutoExpandBlackboxedCallFrameGroup(blackboxedCallFrameGroup)
     {
-        console.assert(WI.settings.experimentalCollapseBlackboxedCallFrames.value);
         console.assert(Array.isArray(blackboxedCallFrameGroup) && blackboxedCallFrameGroup.length && blackboxedCallFrameGroup.every((callFrame) => callFrame instanceof WI.CallFrame && callFrame.blackboxed), blackboxedCallFrameGroup);
 

trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.js

@@ -403 +403 @@
         }
 
-        let supportsBlackboxingScripts = WI.DebuggerManager.supportsBlackboxingScripts();
-        if (supportsBlackboxingScripts) {
-            experimentalSettingsView.addSetting(WI.UIString("Debugging:", "Debugging: @ Experimental Settings", "Category label for experimental settings related to debugging."), WI.settings.experimentalCollapseBlackboxedCallFrames, WI.UIString("Collapse blackboxed call frames", "Collapse blackboxed call frames @ Experimental Settings", "Setting to collapse blackboxed call frames in the debugger."));
-            experimentalSettingsView.addSeparator();
-        }
-
         let diagnosticsGroup = experimentalSettingsView.addGroup(WI.UIString("Diagnostics:", "Diagnostics: @ Experimental Settings", "Category label for experimental settings related to Web Inspector diagnostics."));
         diagnosticsGroup.addSetting(WI.settings.experimentalAllowInspectingInspector, WI.UIString("Allow Inspecting Web Inspector", "Allow Inspecting Web Inspector @ Experimental Settings", "Label for setting that allows the user to inspect the Web Inspector user interface."));
@@ -436 +430 @@
             listenForChange(WI.settings.experimentalEnableStylesJumpToVariableDeclaration);
         }
-
-        if (supportsBlackboxingScripts)
-            listenForChange(WI.settings.experimentalCollapseBlackboxedCallFrames);
 
         this._createReferenceLink(experimentalSettingsView);