Changeset 288622 in webkit

Timestamp:

Jan 26, 2022 8:59:14 AM (6 months ago)

Author:

J Pascoe

Message:

[WebAuthn] Add authenticator attachment used during authentication to credential payload
​https://bugs.webkit.org/show_bug.cgi?id=235621
rdar://86538235

Reviewed by Dean Jackson.

Source/WebCore:

This patch adds the authenticator attachment used to the credential response in get/create
webauthn calls as described in the merged PR to the spec: ​https://github.com/w3c/webauthn/pull/1668/files

Modified layout tests to check for authenticator attachment = (cross-platform/platform) where appropriate
and verified response in manual calls.

• Modules/webauthn/PublicKeyCredential.cpp:

(WebCore::PublicKeyCredential::authenticatorAttachment const):

• Modules/webauthn/PublicKeyCredential.h:
• Modules/webauthn/PublicKeyCredential.idl:

LayoutTests:

Modify webauthn layout tests to check for new authenticatorAttachment field.

• http/wpt/webauthn/public-key-credential-get-success-local.https.html:
• http/wpt/webauthn/resources/util.js:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/http/wpt/webauthn/public-key-credential-get-success-local.https.html (modified) (1 diff)
• LayoutTests/http/wpt/webauthn/resources/util.js (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/Modules/webauthn/PublicKeyCredential.cpp (modified) (1 diff)
• Source/WebCore/Modules/webauthn/PublicKeyCredential.h (modified) (2 diffs)
• Source/WebCore/Modules/webauthn/PublicKeyCredential.idl (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2022-01-26  J Pascoe  <j_pascoe@apple.com>
+
+        [WebAuthn] Add authenticator attachment used during authentication to credential payload
+        https://bugs.webkit.org/show_bug.cgi?id=235621
+        rdar://86538235
+
+        Reviewed by Dean Jackson.
+
+        Modify webauthn layout tests to check for new authenticatorAttachment field.        
+        * http/wpt/webauthn/public-key-credential-get-success-local.https.html:
+        * http/wpt/webauthn/resources/util.js:
+
 2022-01-26  Wenson Hsieh  <wenson_hsieh@apple.com>
 

trunk/LayoutTests/http/wpt/webauthn/public-key-credential-get-success-local.https.html

@@ -17 +17 @@
         assert_array_equals(new Uint8Array(credential.response.userHandle), Base64URL.parse(testUserhandleBase64));
         assert_not_own_property(credential.getClientExtensionResults(), "appid");
+        assert_equals(credential.authenticatorAttachment, 'platform');
 
         // Check authData

trunk/LayoutTests/http/wpt/webauthn/resources/util.js

@@ -426 +426 @@
     assert_array_equals(Base64URL.parse(credential.id), Base64URL.parse(testHidCredentialIdBase64));
     assert_equals(credential.type, 'public-key');
+    assert_equals(credential.authenticatorAttachment, 'cross-platform')
     assert_array_equals(new Uint8Array(credential.rawId), Base64URL.parse(testHidCredentialIdBase64));
     assert_equals(bytesToASCIIString(credential.response.clientDataJSON), '{"type":"webauthn.get","challenge":"MTIzNDU2","origin":"https://localhost:9443"}');

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2022-01-26  J Pascoe  <j_pascoe@apple.com>
+
+        [WebAuthn] Add authenticator attachment used during authentication to credential payload
+        https://bugs.webkit.org/show_bug.cgi?id=235621
+        rdar://86538235
+
+        Reviewed by Dean Jackson.
+
+        This patch adds the authenticator attachment used to the credential response in get/create
+        webauthn calls as described in the merged PR to the spec: https://github.com/w3c/webauthn/pull/1668/files
+
+        Modified layout tests to check for authenticator attachment = (cross-platform/platform) where appropriate
+        and verified response in manual calls.
+
+        * Modules/webauthn/PublicKeyCredential.cpp:
+        (WebCore::PublicKeyCredential::authenticatorAttachment const):
+        * Modules/webauthn/PublicKeyCredential.h:
+        * Modules/webauthn/PublicKeyCredential.idl:
+
 2022-01-26  Wenson Hsieh  <wenson_hsieh@apple.com>
 

trunk/Source/WebCore/Modules/webauthn/PublicKeyCredential.cpp

@@ -54 +54 @@
 }
 
+AuthenticatorAttachment PublicKeyCredential::authenticatorAttachment() const
+{
+    return m_response->attachment();
+}
+
 PublicKeyCredential::PublicKeyCredential(Ref<AuthenticatorResponse>&& response)
     : BasicCredential(base64URLEncodeToString(response->rawId()->data(), response->rawId()->byteLength()), Type::PublicKey, Discovery::Remote)

trunk/Source/WebCore/Modules/webauthn/PublicKeyCredential.h

@@ -34 +34 @@
 namespace WebCore {
 
+enum class AuthenticatorAttachment;
 class AuthenticatorResponse;
 class Document;
@@ -47 +48 @@
     ArrayBuffer* rawId() const;
     AuthenticatorResponse* response() const { return m_response.ptr(); }
+    AuthenticatorAttachment authenticatorAttachment() const;
     AuthenticationExtensionsClientOutputs getClientExtensionResults() const;
 

trunk/Source/WebCore/Modules/webauthn/PublicKeyCredential.idl

@@ -32 +32 @@
     [SameObject] readonly attribute ArrayBuffer rawId;
     [SameObject] readonly attribute AuthenticatorResponse response;
+    [SameObject] readonly attribute AuthenticatorAttachment? authenticatorAttachment;
     AuthenticationExtensionsClientOutputs getClientExtensionResults();