Changeset 289108 in webkit

Timestamp:

Feb 4, 2022 3:58:52 AM (6 months ago)

Author:

svillar@igalia.com

Message:

HTMLMediaElement should dispatch the resize event asynchronously
​https://bugs.webkit.org/show_bug.cgi?id=230895

Reviewed by Darin Adler.

Source/WebCore:

The HTMLMediaElement is currently queueing a task to dispatch the resize event in the post layout phase.
There is no need to run it synchronously and we could move it to another queue were it will be run
asynchronously as it was done for other similar tasks in the past.

• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::layoutSizeChanged):

LayoutTests:

• media/modern-media-controls/media-controller/media-controller-resize.html: Remove the event

listener to avoid an extra notification.

• platform/mac/TestExpectations: Unskipped tests that pass now.
• platform/wincairo/TestExpectations: Ditto.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/media/modern-media-controls/media-controller/media-controller-resize.html (modified) (2 diffs)
• LayoutTests/platform/mac/TestExpectations (modified) (1 diff)
• LayoutTests/platform/wincairo/TestExpectations (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/html/HTMLMediaElement.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2022-02-04  Sergio Villar Senin  <svillar@igalia.com>
+
+        HTMLMediaElement should dispatch the resize event asynchronously
+        https://bugs.webkit.org/show_bug.cgi?id=230895
+
+        Reviewed by Darin Adler.
+
+        * media/modern-media-controls/media-controller/media-controller-resize.html: Remove the event
+        listener to avoid an extra notification.
+        * platform/mac/TestExpectations: Unskipped tests that pass now.
+        * platform/wincairo/TestExpectations: Ditto.
+
 2022-02-03  Myles C. Maxfield  <mmaxfield@apple.com>
 

trunk/LayoutTests/media/modern-media-controls/media-controller/media-controller-resize.html

@@ -17 +17 @@
 shouldBeEqualToString("mediaControls.style.height", "240px");
 
-shadowRoot.addEventListener("resize", () => {
+function testResize() {
     shouldBeEqualToString("mediaControls.style.width", "400px");
     shouldBeEqualToString("mediaControls.style.height", "300px");
+    shadowRoot.removeEventListener("resize", testResize);
     setTimeout(() => {
         debug("");
@@ -25 +26 @@
         finishJSTest();
     });
-});
+}
+
+shadowRoot.addEventListener("resize", testResize);
 
 debug("");

trunk/LayoutTests/platform/mac/TestExpectations

@@ -2083 +2083 @@
 [ Mojave Catalina ] imported/w3c/web-platform-tests/css/css-counter-styles/lower-armenian/css3-counter-styles-112.html [ ImageOnlyFailure ]
 
-webkit.org/b/222185 media/media-extension-with-fragment.html [ Crash ]
-
 webkit.org/b/222205 css3/calc/transforms-translate.html [ Pass ImageOnlyFailure ]
 

trunk/LayoutTests/platform/wincairo/TestExpectations

@@ -242 +242 @@
 media/track/in-band/track-in-band-srt-mkv-track-order.html [ Skip ]
 media/invalid-media-url-crash.html [ Skip ]
-media/media-extension-with-fragment.html [ Skip ]
 
 # VIDEO_PRESENTATION_MODE is disabled

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2022-02-04  Sergio Villar Senin  <svillar@igalia.com>
+
+        HTMLMediaElement should dispatch the resize event asynchronously
+        https://bugs.webkit.org/show_bug.cgi?id=230895
+
+        Reviewed by Darin Adler.
+
+        The HTMLMediaElement is currently queueing a task to dispatch the resize event in the post layout phase.
+        There is no need to run it synchronously and we could move it to another queue were it will be run
+        asynchronously as it was done for other similar tasks in the past.
+
+        * html/HTMLMediaElement.cpp:
+        (WebCore::HTMLMediaElement::layoutSizeChanged):
+
 2022-02-04  Pablo Saavedra  <psaavedra@igalia.com>
 

trunk/Source/WebCore/html/HTMLMediaElement.cpp

@@ -4655 +4655 @@
 void HTMLMediaElement::layoutSizeChanged()
 {
-    if (RefPtr frameView = document().view()) {
-        auto task = [this, protectedThis = Ref { *this }] {
-            if (auto root = userAgentShadowRoot())
-                root->dispatchEvent(Event::create("resize", Event::CanBubble::No, Event::IsCancelable::No));
-        };
-        frameView->queuePostLayoutCallback(WTFMove(task));
-    }
+    auto task = [this] {
+        if (auto root = userAgentShadowRoot())
+            root->dispatchEvent(Event::create("resize", Event::CanBubble::No, Event::IsCancelable::No));
+    };
+    queueTaskKeepingObjectAlive(*this, TaskSource::MediaElement, WTFMove(task));
 
     if (!m_receivedLayoutSizeChanged) {