Changeset 289209 in webkit

Timestamp:

Feb 7, 2022 5:51:03 AM (5 months ago)

Author:

Ziran Sun

Message:

[Forms] Use min as default value when min > max for input type="range"
​https://bugs.webkit.org/show_bug.cgi?id=236223

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Update the sub test expectation that is now passing.

• web-platform-tests/html/semantics/forms/the-input-element/range-expected.txt:

Source/WebCore:

As per spec ​https://html.spec.whatwg.org/multipage/input.html#concept-input-value-default-range,
in the case of "the maximum is less than the minimum, in which case the default value is the minimum".

• html/RangeInputType.cpp:

(WebCore::ensureMaximum):
(WebCore::RangeInputType::createStepRange const):

Location:

trunk

Files:

• LayoutTests/imported/w3c/ChangeLog (modified) (1 diff)
• LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/range-expected.txt (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/html/RangeInputType.cpp (modified) (2 diffs)

trunk/LayoutTests/imported/w3c/ChangeLog

@@ +1 @@
+2022-02-07  Ziran Sun  <zsun@igalia.com>
+
+        [Forms] Use min as default value when min > max for input type="range"
+        https://bugs.webkit.org/show_bug.cgi?id=236223
+
+        Reviewed by Darin Adler.
+
+        Update the sub test expectation that is now passing.
+        * web-platform-tests/html/semantics/forms/the-input-element/range-expected.txt:
+
 2022-02-06  Sam Weinig  <weinig@apple.com>
 

trunk/LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/range-expected.txt

@@ -15 +15 @@
 PASS default value when min and max attributes are given (= min plus half the difference between min and max)
 PASS default value with step control when both min and max attributes are given
-FAIL default value when both min and max attributes are given, while min > max assert_equals: expected "2" but got "51"
+PASS default value when both min and max attributes are given, while min > max
 PASS The default step scale factor is 1, unless min attribute has non-integer value
 PASS Step scale factor behavior when min attribute has integer value but max attribute is non-integer

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2022-02-07  Ziran Sun  <zsun@igalia.com>
+
+        [Forms] Use min as default value when min > max for input type="range"
+        https://bugs.webkit.org/show_bug.cgi?id=236223
+
+        Reviewed by Darin Adler.
+
+        As per spec https://html.spec.whatwg.org/multipage/input.html#concept-input-value-default-range,
+        in the case of "the maximum is less than the minimum, in which case the default value is the minimum".
+
+        * html/RangeInputType.cpp:
+        (WebCore::ensureMaximum):
+        (WebCore::RangeInputType::createStepRange const):
+
 2022-02-07  Joonghun Park  <jh718.park@samsung.com>
 

trunk/Source/WebCore/html/RangeInputType.cpp

@@ -76 +76 @@
 static const StepRange::StepDescription rangeStepDescription { rangeDefaultStep, rangeDefaultStepBase, rangeStepScaleFactor };
 
-static Decimal ensureMaximum(const Decimal& proposedValue, const Decimal& minimum, const Decimal& fallbackValue)
-{
-    return proposedValue >= minimum ? proposedValue : std::max(minimum, fallbackValue);
+static Decimal ensureMaximum(const Decimal& proposedValue, const Decimal& minimum)
+{
+    return proposedValue >= minimum ? proposedValue : minimum;
 }
 
@@ -119 +119 @@
     ASSERT(element());
     const Decimal minimum = parseToNumber(element()->attributeWithoutSynchronization(minAttr), rangeDefaultMinimum);
-    const Decimal maximum = ensureMaximum(parseToNumber(element()->attributeWithoutSynchronization(maxAttr), rangeDefaultMaximum), minimum, rangeDefaultMaximum);
+    const Decimal maximum = ensureMaximum(parseToNumber(element()->attributeWithoutSynchronization(maxAttr), rangeDefaultMaximum), minimum);
 
     const AtomString& precisionValue = element()->attributeWithoutSynchronization(precisionAttr);