Changeset 289226 in webkit

Timestamp:

Feb 7, 2022 9:46:17 AM (5 months ago)

Author:

graouts@webkit.org

Message:

[css-logical] [web-animations] changing direction or writing-mode should clear computed keyframes
​https://bugs.webkit.org/show_bug.cgi?id=236241

Reviewed by Dean Jackson.

LayoutTests/imported/w3c:

Mark WPT progressions.

• web-platform-tests/css/css-logical/animation-001-expected.txt:

Source/WebCore:

Any time the "direction" or "writing-mode" property changes, we must clear the computed keyframes
as we should re-resolve any logical properties used on the source keyframes.

• animation/KeyframeEffect.cpp:

(WebCore::KeyframeEffect::propertyAffectingLogicalPropertiesDidChange):

• animation/KeyframeEffect.h:
• animation/KeyframeEffectStack.cpp:

(WebCore::KeyframeEffectStack::applyKeyframeEffects):

Location:

trunk

Files:

• LayoutTests/imported/w3c/ChangeLog (modified) (1 diff)
• LayoutTests/imported/w3c/web-platform-tests/css/css-logical/animation-001-expected.txt (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/animation/KeyframeEffect.cpp (modified) (1 diff)
• Source/WebCore/animation/KeyframeEffect.h (modified) (1 diff)
• Source/WebCore/animation/KeyframeEffectStack.cpp (modified) (1 diff)

trunk/LayoutTests/imported/w3c/ChangeLog

@@ +1 @@
+2022-02-07  Antoine Quint  <graouts@webkit.org>
+
+        [css-logical] [web-animations] changing direction or writing-mode should clear computed keyframes
+        https://bugs.webkit.org/show_bug.cgi?id=236241
+
+        Reviewed by Dean Jackson.
+
+        Mark WPT progressions.
+
+        * web-platform-tests/css/css-logical/animation-001-expected.txt:
+
 2022-02-07  Antti Koivisto  <antti@apple.com>
 

trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-logical/animation-001-expected.txt

@@ -16 +16 @@
 FAIL Physical shorthands and logical shorthands can be mixed assert_equals: expected "250px" but got "150px"
 PASS Physical properties win over logical properties even when some keyframes only have logical properties
-FAIL Animations update when the writing-mode is changed assert_equals: expected "50px" but got "0px"
-FAIL Filling animations update when the writing-mode is changed assert_equals: expected "100px" but got "0px"
-FAIL Animations with implicit from values update when the writing-mode is changed assert_equals: expected "200px" but got "100px"
-FAIL Animations with overlapping physical and logical properties update when the writing-mode is changed assert_equals: expected "50px" but got "0px"
-FAIL Animations update when the writing-mode is changed through a CSS variable assert_equals: expected "50px" but got "0px"
-FAIL Animations update when the direction is changed assert_equals: expected "0px" but got "50px"
+PASS Animations update when the writing-mode is changed
+PASS Filling animations update when the writing-mode is changed
+PASS Animations with implicit from values update when the writing-mode is changed
+PASS Animations with overlapping physical and logical properties update when the writing-mode is changed
+PASS Animations update when the writing-mode is changed through a CSS variable
+PASS Animations update when the direction is changed
 FAIL Logical shorthand with variable references animates correctly assert_equals: expected "250px" but got "auto"
 PASS writing-mode is not animatable

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2022-02-07  Antoine Quint  <graouts@webkit.org>
+
+        [css-logical] [web-animations] changing direction or writing-mode should clear computed keyframes
+        https://bugs.webkit.org/show_bug.cgi?id=236241
+
+        Reviewed by Dean Jackson.
+
+        Any time the "direction" or "writing-mode" property changes, we must clear the computed keyframes
+        as we should re-resolve any logical properties used on the source keyframes.
+
+        * animation/KeyframeEffect.cpp:
+        (WebCore::KeyframeEffect::propertyAffectingLogicalPropertiesDidChange):
+        * animation/KeyframeEffect.h:
+        * animation/KeyframeEffectStack.cpp:
+        (WebCore::KeyframeEffectStack::applyKeyframeEffects):
+
 2022-02-07  Antoine Quint  <graouts@webkit.org>
 

trunk/Source/WebCore/animation/KeyframeEffect.cpp

@@ -1702 +1702 @@
 }
 
+void KeyframeEffect::propertyAffectingLogicalPropertiesDidChange()
+{
+    if (m_blendingKeyframesSource == BlendingKeyframesSource::WebAnimation)
+        clearBlendingKeyframes();
+}
+
 void KeyframeEffect::animationWasCanceled()
 {

trunk/Source/WebCore/animation/KeyframeEffect.h

@@ -127 +127 @@
     void animationTimingDidChange();
     void transformRelatedPropertyDidChange();
+    void propertyAffectingLogicalPropertiesDidChange();
     OptionSet<AcceleratedActionApplicationResult> applyPendingAcceleratedActions();
 

trunk/Source/WebCore/animation/KeyframeEffectStack.cpp

@@ -134 +134 @@
     }();
 
+    auto propertyAffectingLogicalPropertiesChanged = previousLastStyleChangeEventStyle.direction() != targetStyle.direction()
+        || previousLastStyleChangeEventStyle.writingMode() != targetStyle.writingMode();
+
     for (const auto& effect : sortedEffects()) {
         ASSERT(effect->animation());
+
+        if (propertyAffectingLogicalPropertiesChanged)
+            effect->propertyAffectingLogicalPropertiesDidChange();
+
         effect->animation()->resolve(targetStyle, resolutionContext);