Changeset 289489 in webkit


Ignore:
Timestamp:
Feb 9, 2022 10:51:23 AM (5 months ago)
Author:
Chris Dumez
Message:

Worker scripts should always be decoded as UTF-8
​https://bugs.webkit.org/show_bug.cgi?id=236319

Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

Rebaseline WPT tests that are now passing.

  • web-platform-tests/workers/semantics/encodings/001-expected.txt:
  • web-platform-tests/workers/semantics/encodings/002-expected.txt:

Source/WebCore:

Worker scripts should always be decoded as UTF-8:

No new tests, rebaselined existing tests.

  • workers/WorkerScriptLoader.cpp:

(WebCore::WorkerScriptLoader::didReceiveData):

Location:
trunk
Files:
6 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/imported/w3c/ChangeLog

    r289483 r289489  
     12022-02-09  Chris Dumez  <cdumez@apple.com>
     2
     3        Worker scripts should always be decoded as UTF-8
     4        https://bugs.webkit.org/show_bug.cgi?id=236319
     5
     6        Reviewed by Alex Christensen.
     7
     8        Rebaseline WPT tests that are now passing.
     9
     10        * web-platform-tests/workers/semantics/encodings/001-expected.txt:
     11        * web-platform-tests/workers/semantics/encodings/002-expected.txt:
     12
    1132022-02-09  Chris Dumez  <cdumez@apple.com>
    214

  • trunk/LayoutTests/imported/w3c/web-platform-tests/workers/semantics/encodings/001-expected.txt

    r225593 r289489  
    11
    2 FAIL encoding, dedicated worker assert_equals: expected "å" but got "Ã¥"
     2PASS encoding, dedicated worker
    33

  • trunk/LayoutTests/imported/w3c/web-platform-tests/workers/semantics/encodings/002-expected.txt

    r286821 r289489  
    11
    2 FAIL encoding, shared worker assert_equals: expected "å" but got "Ã¥"
     2PASS encoding, shared worker
    33

  • trunk/Source/WebCore/ChangeLog

    r289483 r289489  
     12022-02-09  Chris Dumez  <cdumez@apple.com>
     2
     3        Worker scripts should always be decoded as UTF-8
     4        https://bugs.webkit.org/show_bug.cgi?id=236319
     5
     6        Reviewed by Alex Christensen.
     7
     8        Worker scripts should always be decoded as UTF-8:
     9        - https://html.spec.whatwg.org/multipage/webappapis.html#fetch-a-classic-worker-script (Step 7)
     10
     11        No new tests, rebaselined existing tests.
     12
     13        * workers/WorkerScriptLoader.cpp:
     14        (WebCore::WorkerScriptLoader::didReceiveData):
     15
    1162022-02-09  Chris Dumez  <cdumez@apple.com>
    217

  • trunk/Source/WebCore/workers/WorkerScriptLoader.cpp

    r289483 r289489  
    198198    m_certificateInfo = response.certificateInfo() ? *response.certificateInfo() : CertificateInfo();
    199199    m_responseMIMEType = response.mimeType();
    200     m_responseEncoding = response.textEncodingName();
    201200    m_responseSource = response.source();
    202201    m_isRedirected = response.isRedirected();
    … …  
    214213        return;
    215214
    216     if (!m_decoder) {
    217         if (!m_responseEncoding.isEmpty())
    218             m_decoder = TextResourceDecoder::create("text/javascript"_s, m_responseEncoding);
    219         else
    220             m_decoder = TextResourceDecoder::create("text/javascript"_s, "UTF-8");
    221     }
     215    if (!m_decoder)
     216        m_decoder = TextResourceDecoder::create("text/javascript"_s, "UTF-8");
    222217
    223218    if (buffer.isEmpty())

  • trunk/Source/WebCore/workers/WorkerScriptLoader.h

    r289483 r289489  
    105105    WorkerScriptLoaderClient* m_client { nullptr };
    106106    RefPtr<ThreadableLoader> m_threadableLoader;
    107     String m_responseEncoding;
    108107    RefPtr<TextResourceDecoder> m_decoder;
    109108    ScriptBuffer m_script;
Note: See TracChangeset for help on using the changeset viewer.