Changeset 289666 in webkit

Timestamp:

Feb 11, 2022 1:12:49 PM (5 months ago)

Author:

graouts@webkit.org

Message:

[model] standalone model documents should be interactive
​https://bugs.webkit.org/show_bug.cgi?id=236493

Reviewed by Dean Jackson.

Source/WebCore:

We made <model> elements not be interactive by default in bug 227621,
so we need to opt into interactivity for standalone <model> documents.
All this requires is setting the "interactive" attribute, which we set
instead of the "controls" attribute which does not exist for <model>.

Test: http/tests/model/model-document-interactive.html

• html/ModelDocument.cpp:

(WebCore::ModelDocumentParser::createDocumentStructure):

LayoutTests:

Add a test that checks that the <model> element created for standalone
documents has the "interactive" attribute.

• http/tests/model/model-document-interactive-expected.txt: Added.
• http/tests/model/model-document-interactive.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/http/tests/model/model-document-interactive-expected.txt (added)
• LayoutTests/http/tests/model/model-document-interactive.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/html/ModelDocument.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2022-02-11  Antoine Quint  <graouts@webkit.org>
+
+        [model] standalone model documents should be interactive
+        https://bugs.webkit.org/show_bug.cgi?id=236493
+
+        Reviewed by Dean Jackson.
+
+        Add a test that checks that the <model> element created for standalone
+        documents has the "interactive" attribute.
+
+        * http/tests/model/model-document-interactive-expected.txt: Added.
+        * http/tests/model/model-document-interactive.html: Added.
+
 2022-02-11  Jon Lee  <jonlee@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2022-02-11  Antoine Quint  <graouts@webkit.org>
+
+        [model] standalone model documents should be interactive
+        https://bugs.webkit.org/show_bug.cgi?id=236493
+
+        Reviewed by Dean Jackson.
+
+        We made <model> elements not be interactive by default in bug 227621,
+        so we need to opt into interactivity for standalone <model> documents.
+        All this requires is setting the "interactive" attribute, which we set
+        instead of the "controls" attribute which does not exist for <model>.
+
+        Test: http/tests/model/model-document-interactive.html
+
+        * html/ModelDocument.cpp:
+        (WebCore::ModelDocumentParser::createDocumentStructure):
+
 2022-02-11  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebCore/html/ModelDocument.cpp

@@ -107 +107 @@
     auto modelElement = HTMLModelElement::create(HTMLNames::modelTag, document);
     m_modelElement = modelElement.ptr();
-    modelElement->setAttributeWithoutSynchronization(controlsAttr, emptyAtom());
+    modelElement->setAttributeWithoutSynchronization(interactiveAttr, emptyAtom());
 
     auto sourceElement = HTMLSourceElement::create(HTMLNames::sourceTag, document);