Changeset 289670 in webkit

Timestamp:

Feb 11, 2022 1:48:12 PM (5 months ago)

Author:

Devin Rousso

Message:

Web Inspector: Sources: double clicking a breakpoint icon should show the edit popover
​https://bugs.webkit.org/show_bug.cgi?id=236524

Reviewed by Patrick Angle.

This is a more convenient way to access(/discover) the breakpoint's configuration details.

• UserInterface/Views/BreakpointTreeElement.js:

(WI.BreakpointTreeElement):
(WI.BreakpointTreeElement.prototype._handleStatusImageElementDoubleClicked): Added.

• UserInterface/Views/BreakpointPopover.js:

(WI.BreakpointPopover.show): Added.
(WI.BreakpointPopover.appendContextMenuItems):
Add a convenience method to create a WI.BreakpointPopover (or subclass) for the given
breakpoint and show it over the given target element.

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Views/BreakpointPopover.js (modified) (1 diff)
• UserInterface/Views/BreakpointTreeElement.js (modified) (2 diffs)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2022-02-11  Devin Rousso  <drousso@apple.com>
+
+        Web Inspector: Sources: double clicking a breakpoint icon should show the edit popover
+        https://bugs.webkit.org/show_bug.cgi?id=236524
+
+        Reviewed by Patrick Angle.
+
+        This is a more convenient way to access(/discover) the breakpoint's configuration details.
+
+        * UserInterface/Views/BreakpointTreeElement.js:
+        (WI.BreakpointTreeElement):
+        (WI.BreakpointTreeElement.prototype._handleStatusImageElementDoubleClicked): Added.
+
+        * UserInterface/Views/BreakpointPopover.js:
+        (WI.BreakpointPopover.show): Added.
+        (WI.BreakpointPopover.appendContextMenuItems):
+        Add a convenience method to create a `WI.BreakpointPopover` (or subclass) for the given
+        breakpoint and `show` it over the given target element.
+
 2022-02-11  Devin Rousso  <drousso@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Views/BreakpointPopover.js

@@ -51 +51 @@
     // Static
 
+    static show(breakpoint, targetElement)
+    {
+        const delegate = null;
+        let popover;
+        if (breakpoint instanceof WI.EventBreakpoint)
+            popover = new WI.EventBreakpointPopover(delegate, breakpoint);
+        else if (breakpoint instanceof WI.URLBreakpoint)
+            popover = new WI.URLBreakpointPopover(delegate, breakpoint);
+        else
+            popover = new WI.BreakpointPopover(delegate, breakpoint);
+        popover.show(targetElement);
+    }
+
     static appendContextMenuItems(contextMenu, breakpoint, targetElement)
     {
         if (breakpoint.editable && targetElement) {
             contextMenu.appendItem(WI.UIString("Edit Breakpoint\u2026"), () => {
-                const delegate = null;
-                let popover;
-                if (breakpoint instanceof WI.EventBreakpoint)
-                    popover = new WI.EventBreakpointPopover(delegate, breakpoint);
-                else if (breakpoint instanceof WI.URLBreakpoint)
-                    popover = new WI.URLBreakpointPopover(delegate, breakpoint);
-                else
-                    popover = new WI.BreakpointPopover(delegate, breakpoint);
-                popover.show(targetElement);
+                WI.BreakpointPopover.show(breakpoint, targetElement);
             });
         }

trunk/Source/WebInspectorUI/UserInterface/Views/BreakpointTreeElement.js

@@ -46 +46 @@
         this.status.addEventListener("mousedown", this._statusImageElementMouseDown.bind(this));
         this.status.addEventListener("click", this._statusImageElementClicked.bind(this));
+        this.status.addEventListener("dblclick", this._handleStatusImageElementDoubleClicked.bind(this));
 
         this.updateStatus();
@@ -218 +219 @@
         this._breakpoint.disabled = !this._breakpoint.disabled;
     }
+
+    _handleStatusImageElementDoubleClicked(event)
+    {
+        WI.BreakpointPopover.show(this._breakpoint, this.status);
+    }
 };