Changeset 289686 in webkit

Timestamp:

Feb 11, 2022 5:52:57 PM (5 months ago)

Author:

Alan Bujtas

Message:

contain:content breaks fullscreen
​https://bugs.webkit.org/show_bug.cgi?id=236470
<rdar://88689388>

Reviewed by Simon Fraser.

Source/WebCore:

Paint/layout containment forms a containing block for fixed positioned block boxes. It makes all fixed
positioned descendants anchored (contained) to this layout container.
This patch enables fullscreen boxes break out of this non-ICB based layout scope (this is similar to what we
do for other, "layout scope changing" properties, see canContainFixedPositionObjects).

Test: fullscreen/fullscreen-prevented-by-containment.html

• css/fullscreen.css:

(:-webkit-full-screen-ancestor:not(iframe)):

• css/parser/CSSParserContext.cpp:

(WebCore::CSSParserContext::CSSParserContext):

LayoutTests:

• fullscreen/fullscreen-prevented-by-containment-expected.txt: Added.
• fullscreen/fullscreen-prevented-by-containment.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fullscreen/fullscreen-prevented-by-containment-expected.txt (added)
• LayoutTests/fullscreen/fullscreen-prevented-by-containment.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/css/fullscreen.css (modified) (1 diff)
• Source/WebCore/css/parser/CSSParserContext.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2022-02-11  Alan Bujtas  <zalan@apple.com>
+
+        `contain:content` breaks fullscreen
+        https://bugs.webkit.org/show_bug.cgi?id=236470
+        <rdar://88689388>
+
+        Reviewed by Simon Fraser.
+
+        * fullscreen/fullscreen-prevented-by-containment-expected.txt: Added.
+        * fullscreen/fullscreen-prevented-by-containment.html: Added.
+
 2022-02-11  Truitt Savell  <tsavell@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2022-02-11  Alan Bujtas  <zalan@apple.com>
+
+        `contain:content` breaks fullscreen
+        https://bugs.webkit.org/show_bug.cgi?id=236470
+        <rdar://88689388>
+
+        Reviewed by Simon Fraser.
+
+        Paint/layout containment forms a containing block for fixed positioned block boxes. It makes all fixed
+        positioned descendants anchored (contained) to this layout container.
+        This patch enables fullscreen boxes break out of this non-ICB based layout scope (this is similar to what we
+        do for other, "layout scope changing" properties, see canContainFixedPositionObjects).
+
+        Test: fullscreen/fullscreen-prevented-by-containment.html
+
+        * css/fullscreen.css:
+        (:-webkit-full-screen-ancestor:not(iframe)):
+        * css/parser/CSSParserContext.cpp:
+        (WebCore::CSSParserContext::CSSParserContext):
+
 2022-02-11  Commit Queue  <commit-queue@webkit.org>
 

trunk/Source/WebCore/css/fullscreen.css

@@ -49 +49 @@
     -webkit-transform-style: flat !important;
     overflow: visible !important;
+    contain: none !important;
 }
 

trunk/Source/WebCore/css/parser/CSSParserContext.cpp

@@ -52 +52 @@
         focusVisibleEnabled = true;
         inputSecurityEnabled = true;
+        containmentEnabled = true;
 #if ENABLE(CSS_TRANSFORM_STYLE_OPTIMIZED_3D)
         transformStyleOptimized3DEnabled = true;