Changeset 289886 in webkit

Timestamp:

Feb 16, 2022 4:38:35 AM (5 months ago)

Author:

Antti Koivisto

Message:

[CSS Container Queries] Serialize container shorthand in StyleProperties
​https://bugs.webkit.org/show_bug.cgi?id=236691

Reviewed by Antoine Quint.

LayoutTests/imported/w3c:

• web-platform-tests/css/css-contain/container-queries/container-parsing-expected.txt:

Source/WebCore:

Serialize element.style.container.

• css/StyleProperties.cpp:

(WebCore::StyleProperties::getPropertyValue const):

Location:

trunk

Files:

• LayoutTests/imported/w3c/ChangeLog (modified) (1 diff)
• LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-parsing-expected.txt (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/css/StyleProperties.cpp (modified) (1 diff)

trunk/LayoutTests/imported/w3c/ChangeLog

@@ +1 @@
+2022-02-16  Antti Koivisto  <antti@apple.com>
+
+        [CSS Container Queries] Serialize container shorthand in StyleProperties
+        https://bugs.webkit.org/show_bug.cgi?id=236691
+
+        Reviewed by Antoine Quint.
+
+        * web-platform-tests/css/css-contain/container-queries/container-parsing-expected.txt:
+
 2022-02-15  Nikolaos Mouchtaris  <nmouchtaris@apple.com>
 

trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-contain/container-queries/container-parsing-expected.txt

@@ -1 +1 @@
 
-FAIL e.style['container'] = "initial" should set the property value assert_not_equals: property should be set got disallowed value ""
-FAIL e.style['container'] = "inherit" should set the property value assert_not_equals: property should be set got disallowed value ""
-FAIL e.style['container'] = "unset" should set the property value assert_not_equals: property should be set got disallowed value ""
-FAIL e.style['container'] = "revert" should set the property value assert_not_equals: property should be set got disallowed value ""
-FAIL e.style['container'] = "none" should set the property value assert_not_equals: property should be set got disallowed value ""
-FAIL e.style['container'] = "none / none" should set the property value assert_not_equals: property should be set got disallowed value ""
-FAIL e.style['container'] = "inline-size" should set the property value assert_not_equals: property should be set got disallowed value ""
-FAIL e.style['container'] = "inline-size / none" should set the property value assert_not_equals: property should be set got disallowed value ""
-FAIL e.style['container'] = "size" should set the property value assert_not_equals: property should be set got disallowed value ""
-FAIL e.style['container'] = "size / block-size" should set the property value assert_not_equals: property should be set got disallowed value ""
-FAIL e.style['container'] = "inline-size / inline-size" should set the property value assert_not_equals: property should be set got disallowed value ""
-FAIL e.style['container'] = "size / size" should set the property value assert_not_equals: property should be set got disallowed value ""
+PASS e.style['container'] = "initial" should set the property value
+PASS e.style['container'] = "inherit" should set the property value
+PASS e.style['container'] = "unset" should set the property value
+PASS e.style['container'] = "revert" should set the property value
+PASS e.style['container'] = "none" should set the property value
+FAIL e.style['container'] = "none / none" should set the property value assert_equals: serialization should be canonical expected "none" but got "none / none"
+PASS e.style['container'] = "inline-size" should set the property value
+FAIL e.style['container'] = "inline-size / none" should set the property value assert_equals: serialization should be canonical expected "inline-size" but got "inline-size / none"
+PASS e.style['container'] = "size" should set the property value
+PASS e.style['container'] = "size / block-size" should set the property value
+PASS e.style['container'] = "inline-size / inline-size" should set the property value
+PASS e.style['container'] = "size / size" should set the property value
 FAIL e.style['container'] = "size state / none" should set the property value assert_not_equals: property should be set got disallowed value ""
 PASS e.style['container'] = "none none" should not set the property value

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2022-02-16  Antti Koivisto  <antti@apple.com>
+
+        [CSS Container Queries] Serialize container shorthand in StyleProperties
+        https://bugs.webkit.org/show_bug.cgi?id=236691
+
+        Reviewed by Antoine Quint.
+
+        Serialize element.style.container.
+
+        * css/StyleProperties.cpp:
+        (WebCore::StyleProperties::getPropertyValue const):
+
 2022-02-16  Alejandro G. Castro  <alex@igalia.com>
 

trunk/Source/WebCore/css/StyleProperties.cpp

@@ -244 +244 @@
     case CSSPropertyColumns:
         return getShorthandValue(columnsShorthand());
+    case CSSPropertyContainer:
+        return getShorthandValue(containerShorthand(), " / ");
     case CSSPropertyFlex:
         return getShorthandValue(flexShorthand());